application

Clone Tools

Stats

Commits this week: 6
Total Committers: 14
Last Commit: 20 Mar
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Feb 2021
2:00 pm

Peter Lucia <plucia@diality.com>

Merge DEN-4860_BLE into master

Options
    • -14
    • +11
    /cppcheck.err
    • -0
    • +1
    /scripts/run.sh
    • -0
    • +3
    /sources/gui/qml/globals/Variables.qml
    • -11
    • +13
    /sources/view/VBluetooth.cpp
    • -2
    • +2
    /sources/view/VBluetooth.h
1:58 pm

Behrouz NematiPour

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child. ...

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child.

    /*!
     * \brief   fromByteArray
     * \details converts the values from Byte Arrays to the Model data.
     * \param   vByteArray - the byte array input
     * \param   vIndex     - current index of each data section in byte array
     * \return  true on successful conversion
     */
    virtual bool         fromByteArray(const QByteArray   &vByteArray  , int *vIndex = nullptr)       = 0;
1:58 pm

Behrouz NematiPour

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child. ...

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child.

    /*!
     * \brief   fromByteArray
     * \details converts the values from Byte Arrays to the Model data.
     * \param   vByteArray - the byte array input
     * \param   vIndex     - current index of each data section in byte array
     * \return  true on successful conversion
     */
    virtual bool         fromByteArray(const QByteArray   &vByteArray  , int *vIndex = nullptr)       = 0;
1:57 pm

Peter Lucia <plucia@diality.com>

Merge master into DEN-6349_bp_hr_manual_entry

Options
    • -10
    • +14
    /cppcheck.err
    • -102
    • +109
    /cppcheck.log
    • -0
    • +2
    /denali.pro
    • -0
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -32
    • +34
    /sources/canbus/MessageInterpreter.cpp
    • -9
    • +5
    /sources/gui/GuiController.cpp
    • -1
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -5
    • +16
    /sources/model/MModel.h
    • -2
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -3
    • +9
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -0
    • +8
    /unittests/tst_models.cpp
1:56 pm

Behrouz NematiPour

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child. ...

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child.

    /*!
     * \brief   parameters
     * \return  current data values of the models.
     */
    virtual QVariantList parameters   (                                                       ) const = 0;
1:53 pm

Behrouz NematiPour

Sure, but that test is not here it is the checkCRC() function test.

Sure, but that test is not here it is the checkCRC() function test.

1:49 pm

Behrouz NematiPour

This is related to two different AUT configuration in SquishQt, 1 - while running with build scripts locally to make sure for the last time we have everything covered and that script builds the app...

This is related to two different AUT configuration in SquishQt,
1 - while running with build scripts locally to make sure for the last time we have everything covered and that script builds the app as "denaliSquish" on local and on the server as well.
2 - the other is when we are at the very first stage of the testing and coverage and building back and forth to test and cover. that one used the QtCreator built "denali".
To make it easy to work with these two configurations I made the name of the AUT as a variable so we can switch between quickly.
The last moment on pushing on the master has to have "denaliSquish".

1:21 pm

Behrouz NematiPour

UI-DEN-5777_UI Dev Convert Logging From Hours to %
UI-DEN-5777_UI Dev Convert Logging From Hours to %
1:12 pm

plucia  (deleted user)

12:42 pm

Behrouz NematiPour

12:41 pm

Behrouz NematiPour

RESOLVED

RESOLVED

12:38 pm

Behrouz NematiPour

RESOLVED

RESOLVED

12:37 pm

Behrouz NematiPour

RESOLVED

RESOLVED

12:36 pm

Behrouz NematiPour

RESOLVED

RESOLVED

10:44 am

Behrouz NematiPour

6636: ptTx_Rinseback: Implementation

- Added the PostTreatmentRinseback.qml

- Added the PostTreatmentRecirculate.qml

- Improved the StackItem.qml

- Added Rinseback/Recirculate Navigation

- Removed Diagnostics screen since it's not one screen anymore and is too old.

-

Options
    • -1
    • +1
    /denali.pro.user
    • -3
    • +10
    /denali.qrc
    • binary
    /resources/images/Accelerate.png
    • binary
    /resources/images/Decelerate.png
    • binary
    /resources/images/End.png
    • binary
    /resources/images/Pause.png
    • binary
    /resources/images/PauseDarkBlue.png
    • binary
    /resources/images/PauseLightBlue.png
    • -1
    • +1
    /sources/gui/qml/components/CheckListItem.qml
    • -3
    • +3
    /sources/gui/qml/components/ConfirmTreatmentTable.qml
    • -2
    • +2
    /sources/gui/qml/components/ConfirmTreatmentTableEntry.qml
    • -5
    • +36
    /sources/gui/qml/components/StackItem.qml
    • -4
    • +3
    /sources/gui/qml/globals/Fonts.qml
    • -0
    • +3
    /sources/gui/qml/globals/Variables.qml
    • -301
    • +0
    /sources/gui/qml/pages/Diagnostics.qml
  16. … 9 more files in changeset.
Friday 29 Jan 2021
5:17 pm

pmontazemi  (deleted user)

What has caused this change in AUT_NAME?

What has caused this change in AUT_NAME?

5:13 pm

pmontazemi  (deleted user)

Should we consider here the case where payload is not empty but has garbage values in it?

Should we consider here the case where payload is not empty but has garbage values in it?

5:09 pm

pmontazemi  (deleted user)

Add function missing header.

Add function missing header.

5:09 pm

pmontazemi  (deleted user)

Add function missing header.

Add function missing header.

5:08 pm

pmontazemi  (deleted user)

Add missing function header.

Add missing function header.

4:54 pm

pmontazemi  (deleted user)

4:20 pm

plucia  (deleted user)

I have updated .gitignore so only bledevices.conf is ignored since it will be different for each device.

I have updated .gitignore so only bledevices.conf is ignored since it will be different for each device.

4:19 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments.

Options
    • -1
    • +1
    /.gitignore
12:19 pm

Behrouz NematiPour

Merge branch 'DEN-5777_UI_DEV_ConvertLogging_From_hrs_to_%' into UI_DEV

Options
12:18 pm

Behrouz NematiPour

DEN-6619: Implementation

- Added a signal named didSDCardSpaceTooLow in the DriveWatcher which will be triggered when the free storage space available on the SD-CARD is less than 10%. (No action on UI happens currently)

- Added a flag in DriveWatcher to stop emitting the Logger while it is cleaning the Logs [[ IMPORTANT : is is handled by signal/slots for thread synchronization and safety ]].

- Added a function to find the total size of the file in a path.

- Added find function to find files with a list of filter in a path.

- Added an overloaded version of find to help find the files in a path which are exceeding the storage limit from the oldest files.

- Added error check in the read overloaded which works with Json.

- Re-implemented the FileHandler::removeLogs to clean up the logs by % instead of date.

- Removed unused global log paths from StorageGlobal.

-

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +15
    /sources/ApplicationController.cpp
    • -0
    • +2
    /sources/ApplicationController.h
    • -0
    • +16
    /sources/gui/GuiController.cpp
    • -0
    • +2
    /sources/gui/GuiController.h
    • -9
    • +24
    /sources/gui/GuiView.cpp
    • -6
    • +9
    /sources/gui/GuiView.h
    • -5
    • +24
    /sources/storage/DriveWatcher.cpp
    • -1
    • +13
    /sources/storage/DriveWatcher.h
    • -5
    • +130
    /sources/storage/FileHandler.cpp
    • -1
    • +8
    /sources/storage/FileHandler.h
    • -17
    • +41
    /sources/storage/Logger.cpp
    • -13
    • +31
    /sources/storage/Logger.h
    • -5
    • +0
    /sources/storage/StorageGlobals.cpp
    • -1
    • +1
    /sources/view/VTreatmentCreate.cpp
    • -2
    • +2
    /unittests/tst_views.cpp
12:04 pm

Behrouz NematiPour

Merge branch 'DEN-5751_Pre-TreatmentUltrafiltration' into UI_DEV

Options
11:08 am

plucia  (deleted user)

Can delete

Can delete

11:05 am

plucia  (deleted user)

Do these properties still exist?

Do these properties still exist?

11:03 am

plucia  (deleted user)

If FW responds back saying either arterial or venous pressure limit ranges are invalid, the user corrects them, and then we proceed, without doing anything upon validation success the pressure limi...

If FW responds back saying either arterial or venous pressure limit ranges are invalid, the user corrects them, and then we proceed, without doing anything upon validation success the pressure limits would still show up as invalid the next time the user enters the create treatment screen.

11:00 am

plucia  (deleted user)

How will this notification bar look if an alarm is raised but minimized? Would there be two notification bars visible?

How will this notification bar look if an alarm is raised but minimized? Would there be two notification bars visible?