application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Feb 2021
2:26 pm

Behrouz NematiPour

DEN-5759: prTx: Code Review 0

Options
    • -1
    • +0
    /sources/gui/qml/components/ConfirmTreatmentSubTable.qml
2:26 pm

pmontazemi  (deleted user)

Did you mean retained? If so, change all these to retained as well as hte name of the quint8 variable to vRetainedPercent.

Did you mean retained? If so, change all these to retained as well as hte name of the quint8 variable to vRetainedPercent.

2:25 pm

plucia  (deleted user)

Your solution requires a code change to be made and the entire denali application to have to be rebuilt every time a treatment parameter needs to be adjusted by systems. This will not serve the nee...

Your solution requires a code change to be made and the entire denali application to have to be rebuilt every time a treatment parameter needs to be adjusted by systems. This will not serve the needs of the system team. To fulfill their needs it was requested at the time to put the values in a file. You and I agreed at the time that the treatment parameter ranges should be read from a file. These two treatment parameter ranges are being read from QML which contradicts our agreed-upon decision to have them read from a file.

2:24 pm

pmontazemi  (deleted user)

"File cannot be opened for read (%1). Possible corrupted file system." 1. Rephrase and spell cannot as mentioned. 2. Add space between two sentences. 3. Add "." at end of 2nd sentence.

"File cannot be opened for read (%1). Possible corrupted file system."

1. Rephrase and spell cannot as mentioned.
2. Add space between two sentences.
3. Add "." at end of 2nd sentence.

2:20 pm

pmontazemi  (deleted user)

cannot

cannot

2:17 pm

Behrouz NematiPour

Actually, this feature (Arterial/Venous Pressure) was done before Pre-Treatment Create feature. At the moment Pre-Treatment Create has been implemented existence of these parameters has been ignore...

Actually, this feature (Arterial/Venous Pressure) was done before Pre-Treatment Create feature.
At the moment Pre-Treatment Create has been implemented existence of these parameters has been ignored and another approach has been followed.
In general, If a simple value can be defined in where it is being used the most (in this case qml) it's better to be defined there and not to call multiple setter, getter for getting a simple read only value.

2:15 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

2:15 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

2:14 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

2:14 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

2:14 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

2:10 pm

Behrouz NematiPour

UI_DVT related.

UI_DVT related.

2:10 pm

Behrouz NematiPour

UI_DVT related.

UI_DVT related.

2:09 pm

Behrouz NematiPour

UI_DVT related.

UI_DVT related.

2:09 pm

Behrouz NematiPour

UI_DVT related.

UI_DVT related.

2:09 pm

Behrouz NematiPour

UI_DVT related.

UI_DVT related.

2:09 pm

Behrouz NematiPour

UI_DVT related.

UI_DVT related.

2:09 pm

Behrouz NematiPour

UI_DVT related.

UI_DVT related.

2:08 pm

Behrouz NematiPour

UI_DVT related.

UI_DVT related.

2:08 pm

Behrouz NematiPour

UI_DVT related.

UI_DVT related.

2:08 pm

Behrouz NematiPour

UI_DVT related.

UI_DVT related.

2:07 pm

Behrouz NematiPour

Cannot find this line in the code. May have been removed already.

Cannot find this line in the code.
May have been removed already.

2:04 pm

Behrouz NematiPour

this notification bar shall not be confused with the alarm notification bar. *these are showing specific rejection reasons related to each screen request. and resides on that one. Which may even ...

this notification bar shall not be confused with the alarm notification bar.

  • these are showing specific rejection reasons related to each screen request. and resides on that one. Which may even in some cases be covered by a higher priority alarm.
  • Alarm bar is a general bar on the screen that shall always be visible regardless of the screen we are currently in.
    These two may exist at the same time and alarm may even cover those rejection requests.
2:00 pm

Peter Lucia <plucia@diality.com>

Merge DEN-4860_BLE into master

Options
    • -14
    • +11
    /cppcheck.err
    • -0
    • +1
    /scripts/run.sh
    • -0
    • +3
    /sources/gui/qml/globals/Variables.qml
    • -11
    • +13
    /sources/view/VBluetooth.cpp
    • -2
    • +2
    /sources/view/VBluetooth.h
1:58 pm

Behrouz NematiPour

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child. ...

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child.

    /*!
     * \brief   fromByteArray
     * \details converts the values from Byte Arrays to the Model data.
     * \param   vByteArray - the byte array input
     * \param   vIndex     - current index of each data section in byte array
     * \return  true on successful conversion
     */
    virtual bool         fromByteArray(const QByteArray   &vByteArray  , int *vIndex = nullptr)       = 0;
1:58 pm

Behrouz NematiPour

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child. ...

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child.

    /*!
     * \brief   fromByteArray
     * \details converts the values from Byte Arrays to the Model data.
     * \param   vByteArray - the byte array input
     * \param   vIndex     - current index of each data section in byte array
     * \return  true on successful conversion
     */
    virtual bool         fromByteArray(const QByteArray   &vByteArray  , int *vIndex = nullptr)       = 0;
1:57 pm

Peter Lucia <plucia@diality.com>

Merge master into DEN-6349_bp_hr_manual_entry

Options
    • -10
    • +14
    /cppcheck.err
    • -102
    • +109
    /cppcheck.log
    • -0
    • +2
    /denali.pro
    • -0
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -32
    • +34
    /sources/canbus/MessageInterpreter.cpp
    • -9
    • +5
    /sources/gui/GuiController.cpp
    • -1
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -5
    • +16
    /sources/model/MModel.h
    • -2
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -3
    • +9
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -0
    • +8
    /unittests/tst_models.cpp
1:56 pm

Behrouz NematiPour

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child. ...

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child.

    /*!
     * \brief   parameters
     * \return  current data values of the models.
     */
    virtual QVariantList parameters   (                                                       ) const = 0;
1:53 pm

Behrouz NematiPour

Sure, but that test is not here it is the checkCRC() function test.

Sure, but that test is not here it is the checkCRC() function test.

1:49 pm

Behrouz NematiPour

This is related to two different AUT configuration in SquishQt, 1 - while running with build scripts locally to make sure for the last time we have everything covered and that script builds the app...

This is related to two different AUT configuration in SquishQt,
1 - while running with build scripts locally to make sure for the last time we have everything covered and that script builds the app as "denaliSquish" on local and on the server as well.
2 - the other is when we are at the very first stage of the testing and coverage and building back and forth to test and cover. that one used the QtCreator built "denali".
To make it easy to work with these two configurations I made the name of the AUT as a variable so we can switch between quickly.
The last moment on pushing on the master has to have "denaliSquish".