application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 16 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Feb 2021
5:44 pm

Behrouz NematiPour

DEN-5759: Code Review 0

- Added a TODO for the DoubleSlider component to add a validation and active feature to be able to use it for PreTreatmentCreate.

Options
    • -6
    • +10
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
5:44 pm

plucia  (deleted user)

will be addressed later, RESOLVED

will be addressed later,
RESOLVED

5:44 pm

plucia  (deleted user)

will be addressed later, RESOLVED

will be addressed later,
RESOLVED

5:44 pm

plucia  (deleted user)

will be addressed later, RESOLVED

will be addressed later,
RESOLVED

5:44 pm

plucia  (deleted user)

will be addressed later RESOLVED

will be addressed later
RESOLVED

5:44 pm

plucia  (deleted user)

will be addressed later, RESOLVED

will be addressed later,
RESOLVED

5:39 pm

plucia  (deleted user)

RESOLVED

RESOLVED

5:39 pm

plucia  (deleted user)

RESOLVED

RESOLVED

5:39 pm

plucia  (deleted user)

RESOLVED

RESOLVED

5:35 pm

plucia  (deleted user)

RESOLVED

RESOLVED

5:34 pm

plucia  (deleted user)

RESOLVED

RESOLVED

4:50 pm

pmontazemi  (deleted user)

4:49 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

4:49 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

4:48 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

4:45 pm

Behrouz NematiPour

fixed.

fixed.

4:45 pm

Behrouz NematiPour

DEN-6621: Code Review 0

Options
    • -1
    • +1
    /sources/storage/Logger.h
4:42 pm

pmontazemi  (deleted user)

16GB and 2.4GB (units are Bytes).

16GB and 2.4GB (units are Bytes).

4:41 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

4:31 pm

Behrouz NematiPour

I meant "retains" and "retain". A complete sentence would be : "if 90% retains ...." or "if 90% shall retain" I prefer to have a present verb, for input and if it was output, a past verb.

I meant "retains" and "retain".
A complete sentence would be :
"if 90% retains ...." or
"if 90% shall retain"
I prefer to have a present verb, for input and if it was output, a past verb.

4:27 pm

Behrouz NematiPour

Corrected the sentences and updated "can't" to "cannot" everywhere in the file.

Corrected the sentences and updated "can't" to "cannot" everywhere in the file.

4:27 pm

Behrouz NematiPour

Corrected the sentences and updated "can't" to "cannot" everywhere in the file.

Corrected the sentences and updated "can't" to "cannot" everywhere in the file.

4:25 pm

Behrouz NematiPour

DEN-6621: Code Review 0

Options
    • -14
    • +14
    /sources/storage/FileHandler.cpp
3:48 pm

Behrouz NematiPour

It is noted. Since this is part of the Arterial/Venous pressure feature and not the preTx_Uf, will be taking care of it as part of the code clean-up and integration I need to do later. By the way, ...

It is noted.
Since this is part of the Arterial/Venous pressure feature and not the preTx_Uf, will be taking care of it as part of the code clean-up and integration I need to do later.
By the way, it's not my solution and not even my approved one.

3:47 pm

Behrouz NematiPour

See the reply above.

See the reply above.

2:32 pm

Behrouz NematiPour

if it is a constant/read-only value that will be used mostly in qml, then better to be defined in QML unless otherwise required.

if it is a constant/read-only value that will be used mostly in qml, then better to be defined in QML unless otherwise required.

2:29 pm

Behrouz NematiPour

Removed.

Removed.

2:26 pm

Behrouz NematiPour

DEN-5759: prTx: Code Review 0

Options
    • -1
    • +0
    /sources/gui/qml/components/ConfirmTreatmentSubTable.qml
2:26 pm

pmontazemi  (deleted user)

Did you mean retained? If so, change all these to retained as well as hte name of the quint8 variable to vRetainedPercent.

Did you mean retained? If so, change all these to retained as well as hte name of the quint8 variable to vRetainedPercent.

2:25 pm

plucia  (deleted user)

Your solution requires a code change to be made and the entire denali application to have to be rebuilt every time a treatment parameter needs to be adjusted by systems. This will not serve the nee...

Your solution requires a code change to be made and the entire denali application to have to be rebuilt every time a treatment parameter needs to be adjusted by systems. This will not serve the needs of the system team. To fulfill their needs it was requested at the time to put the values in a file. You and I agreed at the time that the treatment parameter ranges should be read from a file. These two treatment parameter ranges are being read from QML which contradicts our agreed-upon decision to have them read from a file.