application

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-5759: Code Review 0

- Added a TODO for the DoubleSlider component to add a validation and active feature to be able to use it for PreTreatmentCreate.

will be addressed later, RESOLVED

will be addressed later,
RESOLVED

will be addressed later, RESOLVED

will be addressed later,
RESOLVED

will be addressed later, RESOLVED

will be addressed later,
RESOLVED

will be addressed later RESOLVED

will be addressed later
RESOLVED

will be addressed later, RESOLVED

will be addressed later,
RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

fixed.

fixed.

DEN-6621: Code Review 0

16GB and 2.4GB (units are Bytes).

16GB and 2.4GB (units are Bytes).

RESOLVED.

RESOLVED.

I meant "retains" and "retain". A complete sentence would be : "if 90% retains ...." or "if 90% shall retain" I prefer to have a present verb, for input and if it was output, a past verb.

I meant "retains" and "retain".
A complete sentence would be :
"if 90% retains ...." or
"if 90% shall retain"
I prefer to have a present verb, for input and if it was output, a past verb.

Corrected the sentences and updated "can't" to "cannot" everywhere in the file.

Corrected the sentences and updated "can't" to "cannot" everywhere in the file.

Corrected the sentences and updated "can't" to "cannot" everywhere in the file.

Corrected the sentences and updated "can't" to "cannot" everywhere in the file.

DEN-6621: Code Review 0

    • -14
    • +14
    /sources/storage/FileHandler.cpp
It is noted. Since this is part of the Arterial/Venous pressure feature and not the preTx_Uf, will be taking care of it as part of the code clean-up and integration I need to do later. By the way, ...

It is noted.
Since this is part of the Arterial/Venous pressure feature and not the preTx_Uf, will be taking care of it as part of the code clean-up and integration I need to do later.
By the way, it's not my solution and not even my approved one.

See the reply above.

See the reply above.

if it is a constant/read-only value that will be used mostly in qml, then better to be defined in QML unless otherwise required.

if it is a constant/read-only value that will be used mostly in qml, then better to be defined in QML unless otherwise required.

Removed.

Removed.

DEN-5759: prTx: Code Review 0

Did you mean retained? If so, change all these to retained as well as hte name of the quint8 variable to vRetainedPercent.

Did you mean retained? If so, change all these to retained as well as hte name of the quint8 variable to vRetainedPercent.

Your solution requires a code change to be made and the entire denali application to have to be rebuilt every time a treatment parameter needs to be adjusted by systems. This will not serve the nee...

Your solution requires a code change to be made and the entire denali application to have to be rebuilt every time a treatment parameter needs to be adjusted by systems. This will not serve the needs of the system team. To fulfill their needs it was requested at the time to put the values in a file. You and I agreed at the time that the treatment parameter ranges should be read from a file. These two treatment parameter ranges are being read from QML which contradicts our agreed-upon decision to have them read from a file.