Activity application/

8:02 pm

Behrouz NematiPour

More
ac121d2
changed 2 files
master, @Environement_Swith and 181 more UI-DEN-14294-1

Code Review [ UI-DEN-14294-1 ]

Addressing the code review comments

- UI-DEN-14294-1

- UI-DEN-14294-UI BN S84

- UI-DEN-14294-UI-BN-S84

- UI-DEN-14294-UI_BN_S84

- -2
- +2
/sources/device/DeviceController.h
- History
- Source
- Diff
/sources/device/DeviceController.h
- -7
- +6
/sources/gui/qml/pages/settings/SettingsExportLogs.qml
- History
- Source
- Diff
/sources/gui/.../SettingsExportLogs.qml

7:59 pm

Behrouz NematiPour

More
3e75c21
changed 2 files
master, @Environement_Swith and 181 more UI-DEN-14294-1

Cherry Pick [DEN-13053-S82-JI : a09496, 417f94, 76d3e8 ]

- Added request for versions when UI POST is done if POST was successful

- -0
- +16
/sources/ApplicationController.cpp
- History
- Source
- Diff
/sources/ApplicationController.cpp
- -0
- +2
/sources/ApplicationController.h
- History
- Source
- Diff
/sources/ApplicationController.h

5:02 pm

Behrouz NematiPour

More
Re: UI-DEN-14294-1
replied to Sean Nash

Seems like as part of modern C++ the equal operator is no longer needed. I need to investigate more to completely remove it.

Seems like as part of modern C++ the equal operator is no longer needed.
I need to investigate more to completely remove it.

4:16 pm

This function is a slot to debug the behavior of the power dialog for now The entire qml file may later be removed. We had some conversations to combine the power message into confirmation and remo...

This function is a slot to debug the behavior of the power dialog for now
The entire qml file may later be removed.
We had some conversations to combine the power message into confirmation and remove the power qml, models, and so on.

3:23 pm

Michael Garthwaite

More
Re: UI-DEN-14294-1
commented on review

The body of this function looks all commented out. Is this function necessary?

1:54 pm

Sean Nash

More
Re: UI-DEN-14294-1
commented on review

Why commented out?

1:47 pm

Sean Nash

More
Re: UI-DEN-14294-1
commented on review

Align function bodies.

1:34 pm

Sean Nash

More
Re: UI-DEN-14294-1
commented on review

Align "=".

11:17 am

Behrouz NematiPour

More
cedf17d
changed 1 file
master, @Environement_Swith and 181 more UI-DEN-14294-1

Cherry Pick [DEN-13053-S82-JI : 4ae908] Log Messages ID added

Changed logger so that UI sent and received messages show with a hex message ID field.

- -3
- +3
/sources/canbus/MessageInterpreter.cpp
- History
- Source
- Diff
/sources/canbus/MessageInterpreter.cpp

10:34 am

Behrouz NematiPour

More
44550c6
changed 6 files
master, @Environement_Swith and 181 more UI-DEN-14294-1

Cherry Pick [DEN-13053-S82-JI : 86d954] ClousSync device Registration Error

Fixed syntax of cloudsync post in run.sh file so that cloudsync runs on post

Changed UI serial implementation to trim off any whitespace or invalid characters in serials received from HD and DG

Changed CloudSync controller to only send messages to CloudSync if device is registered

- -5
- +19
/sources/cloudsync/CloudSyncController.cpp
- History
- Source
- Diff
/sources/.../CloudSyncController.cpp
- -0
- +3
/sources/cloudsync/CloudSyncController.h
- History
- Source
- Diff
/sources/cloudsync/CloudSyncController.h
- -2
- +30
/sources/model/dg/adjustment/settings/MAdjustDGSerialNumberResponse.cpp
- History
- Source
- Diff
/sources/.../MAdjustDGSerialNumberResponse.cpp
- -0
- +1
/sources/model/dg/adjustment/settings/MAdjustDGSerialNumberResponse.h
- History
- Source
- Diff
/sources/.../MAdjustDGSerialNumberResponse.h
- -2
- +30
/sources/model/hd/adjustment/settings/MAdjustHDSerialNumberResponse.cpp
- History
- Source
- Diff
/sources/.../MAdjustHDSerialNumberResponse.cpp
- -0
- +1
/sources/model/hd/adjustment/settings/MAdjustHDSerialNumberResponse.h
- History
- Source
- Diff
/sources/.../MAdjustHDSerialNumberResponse.h

10:04 am

Behrouz NematiPour

More
e877264
changed 4 files
master, @Environement_Swith and 181 more UI-DEN-14294-1

Cherry Pick [DEN-13053-S82-JI : a98b41] Alarm Bell Icon

Replaced old alarm bell/bell-off files with new files from Behrouz and refactored their filenames.

- -1
- +1
/denali.qrc
- History
- Source
- Diff
/denali.qrc
- binary
/resources/images/bell-off.png
- History
- Source
- Diff
/resources/images/bell-off.png
- binary
/resources/images/bell-on.png
- History
- Source
/resources/images/bell-on.png
- binary
/resources/images/bell.png
- History
- Source
- Diff
/resources/images/bell.png

6:18 pm

Dara Navaei

More
UI-DEN-14294-1
started review

UI-DEN-14294_UI BN S84

5:05 pm

Dara Navaei

More
70f2a3b
changed 1 file
master, @Environement_Swith and 181 more UI-DEN-14294-1

Bamboo Commit: Updated MAlarmMapping.cpp

- -1
- +1
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

2:58 pm

Behrouz NematiPour

More
f243879
changed 0 files
master, @Environement_Swith and 181 more

Merge branch 'staging' into DEN-14294-UI-BN-S84

2:50 pm

Behrouz NematiPour

More
6d80260
changed 1 file
master, @Environement_Swith and 181 more UI-DEN-14294-1

DEN-14391: Qt 5.15.10 [setup/bootup scripts]

- Give the operator a chance to complete the setup without SD-Card and format and insert it later since the application has alarms and won't stop working if sd-card not present.