application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 09 Feb 2023
7:19 pm

Behrouz NematiPour

DEN-14736 : IMP: Updated MsgID 0x2C00

/*!

* \brief The MDGHeaters class

* \details The DG heaters data model

*

* | MSG | CAN ID | Box | Type | Ack | Src | Dst | Description |

* |:----:|:------:|:---:|:------:|:---:|:---:|:---:|:-----------: |

* |0x2C00| 0x080 | 8 | 2 Hz | N | DG | All | DG Heaters Data |

*

* | Payload ||

* | ||

* | # 1:(F32) | \ref Data::mMainPrimayHeaterDC |

* | # 2:(F32) | \ref Data::mSmallPrimaryHeaterDC |

* | # 3:(F32) | \ref Data::mTrimmerHeaterDC |

* | # 4:(F32) | \ref Data::mPrimaryTargetTemp |

* | # 5:(F32) | \ref Data::mTrimmerTargetTemp |

* | # 6:(F32) | \ref Data::mPrimaryHeaterState |

* | # 7:(F32) | \ref Data::mTrimmerHeaterState |

* | # 8:(F32) | \ref Data::mPrimaryEfficiency |

* | # 9:(F32) | \ref Data::mPrimaryCalcTargetTemp |

* | #10:(F32) | \ref Data::mTrimmerCalcCurrentTemp |

* | #11:(F32) | \ref Data::mTrimmerUseLastDC |

*

* \sa Data

*

* <h2 class="groupheader">Logging info</h2>

* | ||

* | ||

* | typeText | Datum |

* | unitText | DG |

* | infoText | Heaters |

*

*/

Options
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -3
    • +3
    /sources/gui/qml/dialogs/DiagnosticsDialog.qml
    • -9
    • +42
    /sources/model/dg/data/MDGHeatersData.cpp
    • -10
    • +33
    /sources/model/dg/data/MDGHeatersData.h
    • -3
    • +11
    /sources/view/dg/data/VDGHeatersData.cpp
    • -4
    • +12
    /sources/view/dg/data/VDGHeatersData.h
    • -16
    • +16
    /unittests/tst_models.cpp
4:39 pm

jishii  (deleted user)

4:38 pm

Behrouz NematiPour

DEN-14736 : IMP: DEN-14486

- DEN-14486 : Incorrect alarm notification appears during DG Flush

Options
    • -1
    • +1
    /cppcheck.err
    • -15
    • +15
    /cppcheck.log
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -3
    • +32
    /sources/view/hd/alarm/VAlarmActiveList.cpp
    • -1
    • +6
    /sources/view/hd/alarm/VAlarmActiveList.h
    • -0
    • +6
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -1
    • +1
    /sources/view/hd/alarm/VAlarmStatus.h
1:55 pm

Vy <vduong@sunriselabs.com>

DEN-14743 Bluetooth bug fixes - improve connection handling and message display

Options
    • -10
    • +101
    /sources/bluetooth/BluetoothInterface.cpp
    • -1
    • +2
    /sources/bluetooth/BluetoothInterface.h
    • -1
    • +1
    /sources/gui/qml/pages/settings/SettingsBluetoothCuff.qml
    • -0
    • +1
    /sources/model/settings/MBluetooth.h
    • -1
    • +5
    /sources/view/settings/VBluetooth.cpp
11:08 am

Sean Nash

So we will likely remove this TODO and comment later? RESOLVED.

So we will likely remove this TODO and comment later?
RESOLVED.

11:06 am

Sean Nash

RESOLVED.

RESOLVED.

10:07 am

Behrouz NematiPour

It was removed. UI sends an alarmTriggered to HD for that, and should not display a dialog by itself. Since on the device, if there is no other alarm HD will eventually display it, and if there is ...

It was removed.
UI sends an alarmTriggered to HD for that, and should not display a dialog by itself.
Since on the device, if there is no other alarm HD will eventually display it, and if there is HD will override it.
It was just a bug in development then, which was always displaying a useless dialog on VM that doesn't even have a physical SD Card.

10:04 am

Behrouz NematiPour

I laughed loud for a while https://devapps.diality.us/static/s73b8n/2static/images/wiki/icons/emoticons/biggrin.gif This is the spell checker dictionary. Since my spell checker was complaining and ...

I laughed loud for a while
This is the spell checker dictionary.
Since my spell checker was complaining and it was bugging me, and I always look at it like there is a bug in that area, I add her name so spell checker won't highlight it anymore.
It is a comment I have about the decision we made to remind me why I have that line of code commented.

9:24 am

Michael Garthwaite

RESOLVED.

RESOLVED.

9:22 am

Michael Garthwaite

is this alignment correct? I see you align by . above (line 35-38) but I don't see examples of aligning by ( for function calls.

is this alignment correct? I see you align by . above (line 35-38) but I don't see examples of aligning by ( for function calls.

8:41 am

Sean Nash

Why is her name in string table?

Why is her name in string table?

8:37 am

Sean Nash

Any reason this alarm is commented out?

Any reason this alarm is commented out?

Wednesday 08 Feb 2023
9:09 pm

Dara Navaei

UI-DEN-14733_UI BN S90
UI-DEN-14733_UI BN S90
9:00 pm

Behrouz NematiPour

DEN-14736 : IMP: Dry-Demo Support

- added the CLI switch -D : --enable-dry-demo

- added the CLI switch -A : --active-can-bus <CANBus>

- added the CLI switch -F : --disable-fault-screen

- will send confirmation response with ConfirmationID of 99 and as accepted(1):

- e.g. 03:32:29.560,bb00,UI,Confirm,99,1

Options
    • -1
    • +1
    /cppcheck.err
    • -17
    • +17
    /cppcheck.log
    • -55
    • +61
    /denali.pro.user
    • -0
    • +1
    /en_US.udic
    • -0
    • +31
    /main.cpp
    • -1
    • +1
    /sources/canbus/CanInterface.h
    • -0
    • +3
    /sources/gui/GuiView.h
    • -4
    • +0
    /sources/gui/qml/PowerItem.qml
    • -1
    • +15
    /sources/gui/qml/main.qml
    • -1
    • +3
    /sources/gui/qml/pages/MainStack.qml
    • -0
    • +3
    /sources/main.h
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
6:21 pm

Behrouz NematiPour

DEN-14736 : IMP: DEN-14779: In-Tx Qb, Qd, PBo, PBA Adj

Options
    • -5
    • +9
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
1:32 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -16
    • +23
    /sources/model/hd/alarm/MAlarmMapping.cpp
1:32 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /scripts/run.sh
    • -2
    • +2
    /scripts/wifi_disconnect_network.sh
    • -2
    • +2
    /scripts/wifi_generate_wpa_supplicant.sh
    • -2
    • +2
    /scripts/wifi_request_auto_assigned_ip.sh
    • -2
    • +2
    /scripts/wifi_start_wpa_supplicant.sh
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -1
    • +1
    /sources/gui/qml/pages/settings/SettingsWiFi.qml
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -2
    • +2
    /sources/model/settings/MWifiNetwork.h
    • -1
    • +1
    /sources/view/settings/VNetworkModel.cpp
    • -1
    • +1
    /sources/view/settings/VNetworkModel.h
    • -1
    • +1
    /sources/wifi/WifiInterface.cpp
    • -1
    • +1
    /sources/wifi/WifiInterface.h
1:27 pm

Behrouz NematiPour

Merge branch 'DEN-14609-UI-VD-S89' into staging

Options
11:51 am

vduong  (deleted user)

11:33 am

Tiffany Mejia , Michael Garthwaite , Behrouz NematiPour and jishii  (deleted user)

8:19 am

Behrouz NematiPour

RESOLVED

RESOLVED

8:17 am

vduong  (deleted user)

Updated

Updated

8:17 am

Vy <vduong@sunriselabs.com>

DEN-14609 Move log line into else section

Options
    • -1
    • +1
    /scripts/run.sh
1:31 am

Behrouz NematiPour

DEN-14736 : IMP: Secured the SD-Card mount

- added security recommended USB mount flags

MS_SYNCHRONOUS

MS_NOEXEC

MS_NODEV

MS_NOSUID

Options
    • -1
    • +6
    /sources/device/DeviceController.cpp
12:43 am

Behrouz NematiPour

DEN-14736 : IMP: Removed the SD-Card alarm dialog

- it is not clear what needs to be done when SD-Card fails after a successful POST.

- May need to send an alarmTrigger to HD and stop logging.

- Removed for now.

Options
    • -11
    • +2
    /sources/gui/GuiController.cpp
    • -1
    • +1
    /sources/storage/Logger.h
Tuesday 07 Feb 2023
11:36 pm

Behrouz NematiPour

DEN-14736 : IMP: Shutdown dialog / Alarm Dialog

- The shutdown dialog closure was not maximizing the minimized alarm dialog

Options
    • -0
    • +1
    /sources/gui/qml/PowerItem.qml
11:26 pm

Behrouz NematiPour

DEN-14736 : IMP: DEN-14779: In-Tx Qb, Qd, PBo, PBA Adj

Options
    • -5
    • +4
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
10:17 pm

Behrouz NematiPour

RESOLVED

RESOLVED

10:16 pm

Behrouz NematiPour

RESOLVED

RESOLVED

10:16 pm

Behrouz NematiPour

This line should be in the else block.

This line should be in the else block.