application

Clone Tools

Stats

Commits this week: 6
Total Committers: 14
Last Commit: 20 Mar
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 21 Feb 2023
3:05 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /scripts/run.sh
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
2:56 pm

Behrouz NematiPour

2:55 pm

Dara Navaei and jishii  (deleted user)

2:51 pm

Behrouz NematiPour

Merge branch 'DEN-14796-UI-BN-S91' into staging

Options
1:09 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
1:08 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
12:01 pm

Dara Navaei

UI-DEN-14796_UI BN S
UI-DEN-14796_UI BN S
10:27 am

Behrouz NematiPour

DEN-14799 IMP: General Implementation

DEN-14787: UI failing POST after upgrade

DEN-14773: UI POST failing. Touch screen not configuring.

DEN-12140: UI does not pass Touch POST

Options
    • -18
    • +18
    /scripts/run.sh
Wednesday 15 Feb 2023
4:00 pm

Vy <vduong@sunriselabs.com>

DEN-14743 Add pairing confirmation dialog

Options
    • -1
    • +19
    /sources/gui/qml/pages/settings/SettingsBluetoothCuff.qml
1:14 pm

Vy <vduong@sunriselabs.com>

DEN-14743 Modify to only require single time pairing for data sync

Options
    • -26
    • +106
    /sources/bluetooth/BluetoothInterface.cpp
    • -3
    • +16
    /sources/bluetooth/BluetoothInterface.h
    • -0
    • +1
    /sources/view/settings/VBluetooth.cpp
Friday 10 Feb 2023
10:12 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
10:12 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /cppcheck.sh
    • -1
    • +1
    /imake.sh
    • -1
    • +1
    /main.cpp
    • -1
    • +1
    /sources/canbus/CanInterface.h
    • -1
    • +1
    /sources/canbus/FrameInterface.h
    • -1
    • +1
    /sources/canbus/MessageAcknowModel.h
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +1
    /sources/cloudsync/CloudSyncController.cpp
    • -1
    • +1
    /sources/cloudsync/CloudSyncController.h
    • -1
    • +1
    /sources/device/DeviceController.cpp
    • -1
    • +1
    /sources/gui/GuiController.cpp
    • -1
    • +1
    /sources/gui/GuiView.h
    • -1
    • +1
    /sources/gui/qml/PowerItem.qml
    • -1
    • +1
    /sources/gui/qml/components/DebugDataColumn.qml
  16. … 36 more files in changeset.
9:51 am

Behrouz NematiPour

Merge branch 'DEN-14733-UI-BN-S90-2' into staging

Options
    • -2
    • +3
    /AlarmMapping.csv
    • -39
    • +1221
    /cppcheck.err
    • -69
    • +271
    /cppcheck.log
    • -118
    • +66
    /denali.pro.user
    • -0
    • +1
    /en_US.udic
    • -6
    • +0
    /imake.sh
    • -0
    • +31
    /main.cpp
    • -1
    • +1
    /sources/canbus/CanInterface.h
    • -4
    • +4
    /sources/canbus/MessageGlobals.h
    • -5
    • +5
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +6
    /sources/device/DeviceController.cpp
    • -11
    • +2
    /sources/gui/GuiController.cpp
    • -0
    • +3
    /sources/gui/GuiView.h
    • -4
    • +1
    /sources/gui/qml/PowerItem.qml
    • -3
    • +3
    /sources/gui/qml/components/DebugDataColumn.qml
  16. … 29 more files in changeset.
9:30 am

Behrouz NematiPour

Merge branch 'DEN-14517-UI-BN-S88' into staging

Options
    • -205
    • +205
    /cppcheck.log
    • -18
    • +70
    /denali.pro.user
    • -1
    • +7
    /imake.sh
9:23 am

Behrouz NematiPour

9:23 am

Behrouz NematiPour

9:23 am

Michael Garthwaite , vduong  (deleted user) and jishii  (deleted user)

9:20 am

Sean Nash and vduong  (deleted user)

9:18 am

vduong  (deleted user)

Yes, assignments break bindings. RESOLVED

Yes, assignments break bindings.

RESOLVED

9:17 am

vduong  (deleted user)

Ok, sounds good. RESOLVED

Ok, sounds good.

RESOLVED

8:23 am

Behrouz NematiPour

Good point, But you can't. The readonly properties are only working with bindings, not assignments. I am using that as a public variable.

Good point,
But you can't.
The readonly properties are only working with bindings, not assignments.
I am using that as a public variable.

8:17 am

Behrouz NematiPour

Good point, I agree with the two intervals, it would be clarifying. For the counter, though, it might not be always the case. I will start doing it in my next task, since I would like to change all...

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

8:14 am

vduong  (deleted user)

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

7:40 am

vduong  (deleted user)

Only a suggestion: It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity. For instance, here, we have ms and the next o...

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

7:16 am

vduong  (deleted user)

RESOLVED

RESOLVED

7:12 am

Behrouz NematiPour

Thanks for the feedback. Fixed.

Thanks for the feedback.
Fixed.

7:12 am

Behrouz NematiPour

CR comment: UI-DEN-14517-1#c16470

http://devapps.diality.us:8060/cru/UI-DEN-14517-1#c16470

Options
    • -1
    • +1
    /sources/cloudsync/CloudSyncController.cpp
7:03 am

vduong  (deleted user)

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

6:41 am

Behrouz NematiPour

DEN-14736 : IMP: DEN-14768 : InTx UF Adj

DEN-14768

Ultrafiltration Adjustment Screen Slider Does Not Update Maximum UF Vol after Duration Settings Adjustment

Options
    • -10
    • +12
    /sources/gui/qml/components/Slider.qml
Thursday 09 Feb 2023
10:40 pm

Behrouz NematiPour

DEN-14736 : IMP: Updated MsgID 0x2D00

/*!

* \brief The MDGTemperatures class

* \details The DG temperatures data model

*

* | MSG | CAN ID | Box | Type | Ack | Src | Dst | Description |

* |:----:|:------:|:---:|:------:|:---:|:---:|:---:|:-----------: |

* |0x2D00| 0x080 | 8 | 2 Hz | N | DG | All | DG Temperatures Data |

*

* | Payload ||

* | ||

* | #01:(F32) | \ref Data::mInletPrimaryHeater |

* | #02:(F32) | \ref Data::mHeatDisinfect |

* | #03:(F32) | \ref Data::mOutletPrimaryHeater |

* | #04:(F32) | \ref Data::mConductivitySensor1 |

* | #05:(F32) | \ref Data::mConductivitySensor2 |

* | #06:(F32) | \ref Data::mOutletRedundancy |

* | #07:(F32) | \ref Data::mInletDialysate |

* | #08:(F32) | \ref Data::mPrimaryHeaterThermoCouple |

* | #09:(F32) | \ref Data::mTrimmerHeaterThermoCouple |

* | #10:(F32) | \ref Data::mPrimaryHeaterColdJunction |

* | #11:(F32) | \ref Data::mTrimmerHeaterColdJunction |

* | #12:(F32) | \ref Data::mPrimaryHeaterInternal |

* | #13:(F32) | \ref Data::mTrimmerHeaterInternal |

* | #14:(F32) | \ref Data::mFpgaBoard |

* | #15:(F32) | \ref Data::mLoadCellA1B1 |

* | #16:(F32) | \ref Data::mLoadCellA2B2 |

* | #17:(F32) | \ref Data::mInternalTHDORTD |

* | #18:(F32) | \ref Data::mInternalTDIRTD |

* | #19:(F32) | \ref Data::mInteralTHDRTD |

* | #20:(F32) | \ref Data::mInternalCondSnsrTemp |

* | #21:(F32) | \ref Data::mBaroTempSensor |

*

* \sa Data

*

* <h2 class="groupheader">Logging info</h2>

* | ||

* | ||

* | typeText | Datum |

* | unitText | DG |

* | infoText | Temperatures |

*

*/

Options
    • -2
    • +2
    /sources/canbus/MessageGlobals.h
    • -3
    • +3
    /sources/gui/qml/components/DebugDataColumn.qml
    • -7
    • +23
    /sources/gui/qml/dialogs/DiagnosticsDialog.qml
    • -13
    • +45
    /sources/model/dg/data/MDGTemperaturesData.cpp
    • -26
    • +50
    /sources/model/dg/data/MDGTemperaturesData.h
    • -13
    • +21
    /sources/view/dg/data/VDGTemperaturesData.cpp
    • -0
    • +8
    /sources/view/dg/data/VDGTemperaturesData.h