application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 20 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 06 Jul 2020
2:15 am

Behrouz NematiPour

DEN-3874 : HW Support [Per Peman's Email]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -4
    • +4
    /main.cpp
    • -1
    • +1
    /sources/canbus/messageinterpreter.cpp
    • -1
    • +1
    /sources/main.h
    • -10
    • +10
    /unittests/tst_acknow.cpp
    • -18
    • +18
    /unittests/tst_canbus.cpp
    • -11
    • +11
    /unittests/tst_logging.cpp
    • -2
    • +2
    /unittests/tst_logging.h
    • -59
    • +59
    /unittests/tst_messaging.cpp
12:42 am

Behrouz NematiPour

DEN-3874 : HW Support [Per Peman's Email]

- Unified All the Data messages to use the newly created parent model MAbstract.

- Cleaned up the logging class.

- Removed log_once macros.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -1
    • +1
    /denali.pro.user
    • -2
    • +3
    /sources/canbus/caninterface.cpp
    • -2
    • +3
    /sources/canbus/messagebuilder.cpp
    • -257
    • +29
    /sources/canbus/messageinterpreter.cpp
    • -25
    • +13
    /sources/canbus/messageinterpreter.h
    • -1
    • +1
    /sources/gui/qml/pages/SettingsHome.qml
    • -7
    • +18
    /sources/model/MAbstract.cpp
    • -0
    • +1
    /sources/model/MAbstract.h
    • -1
    • +1
    /sources/model/dg/data/MDGDrainPumpData.h
    • -17
    • +11
    /sources/model/hd/adjustment/MTreatmentAdjustBloodDialysateResponse.cpp
    • -15
    • +15
    /sources/model/hd/adjustment/MTreatmentAdjustBloodDialysateResponse.h
    • -16
    • +11
    /sources/model/hd/adjustment/MTreatmentAdjustDurationResponse.cpp
    • -15
    • +15
    /sources/model/hd/adjustment/MTreatmentAdjustDurationResponse.h
    • -1
    • +1
    /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationEditResponse.h
    • -6
    • +4
    /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationStateResponse.cpp
  16. … 17 more files in changeset.
Saturday 04 Jul 2020
9:21 pm

Behrouz NematiPour

DEN-3874 : HW Support [Per Peman's Email]

- Another try to make the code more clean.

- Qml doesn't accept enums with first letter non-capital [id => ID_]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -1
    • +2
    /denali.pro
    • -2
    • +2
    /denali.pro.user
    • -1
    • +1
    /sources/applicationcontroller.cpp
    • -1
    • +1
    /sources/canbus/messagebuilder.cpp
    • -7
    • +7
    /sources/canbus/messagedispatcher.cpp
    • -5
    • +5
    /sources/canbus/messagedispatcher.h
    • -36
    • +36
    /sources/canbus/messageglobals.h
    • -64
    • +64
    /sources/canbus/messageinterpreter.cpp
    • -1
    • +1
    /sources/gui/guicontroller.cpp
    • -46
    • +46
    /sources/gui/guiglobals.h
    • -1
    • +4
    /sources/gui/qml/main.qml
    • -1
    • +1
    /sources/gui/qml/pages/ManagerHome.qml
    • -0
    • +47
    /sources/model/MAbstract.cpp
    • -3
    • +51
    /sources/model/MAbstract.h
    • -9
    • +5
    /sources/model/dg/data/MDGDrainPumpData.cpp
  16. … 17 more files in changeset.
Thursday 02 Jul 2020
9:47 pm

Behrouz NematiPour

DEN-3874 : HW Support [Per Peman's Email]

- Just to keep the code. Needs clean up.

- Don't forget Logs (DG, HD is different)

- So many more.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -77
    • +145
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/applicationcontroller.cpp
    • -1
    • +1
    /sources/applicationcontroller.h
    • -1
    • +1
    /sources/canbus/messagebuilder.cpp
    • -7
    • +7
    /sources/canbus/messagedispatcher.cpp
    • -5
    • +5
    /sources/canbus/messagedispatcher.h
    • -29
    • +40
    /sources/canbus/messageglobals.h
    • -98
    • +89
    /sources/canbus/messageinterpreter.cpp
    • -5
    • +4
    /sources/canbus/messageinterpreter.h
    • -1
    • +1
    /sources/gui/guicontroller.cpp
    • -1
    • +1
    /sources/gui/guicontroller.h
    • -3
    • +13
    /sources/gui/guiglobals.cpp
    • -37
    • +43
    /sources/gui/guiglobals.h
    • -4
    • +18
    /sources/gui/qml/main.qml
  16. … 127 more files in changeset.
Wednesday 01 Jul 2020
2:10 pm

Peter Lucia <plucia@diality.com>

Added back SquishQt comment

Options
    • -1
    • +1
    /sources/gui/qml/components/NotificationBar.qml
2:09 pm

Peter Lucia <plucia@diality.com>

Fixed MouseArea z order, removed unused sound item

Options
    • -24
    • +24
    /sources/gui/qml/components/SettingsItem.qml
    • -1
    • +6
    /sources/gui/qml/pages/Diagnostics.qml
    • -7
    • +5
    /sources/gui/qml/pages/SettingsHome.qml
1:54 pm

Peter Lucia <plucia@diality.com>

Aligned colors

Options
    • -4
    • +4
    /sources/gui/qml/globals/Colors.qml
1:45 pm

Peter Lucia <plucia@diality.com>

Removed spaces

Options
    • -1
    • +0
    /unittests/tst_messaging.cpp
    • -2
    • +0
    /unittests/tst_models.cpp
    • -1
    • +0
    /unittests/tst_models.h
Monday 29 Jun 2020
10:06 pm

Behrouz NematiPour

DEN-3880 : Implementation

- Added Alarm Triggered Model

- Added Alarm Cleared Model

- Added Treatment State Model

- "UI," as Event Source to the Initialized and Some Other Event Messages for better logging

- Updated Ack messages and made them nicer for logging.

- Added DGCheckIn as a message to be logged.

- Stored Unit texts as a read only property in Variables qml file which had multiple definition multiple places.

- Changed the toString of models to use comma instead of parenthesis to be easily used in Excel as a CSV file format.

- Found a bug in TreatmentAdjustmentUltrafiltrationConfirm Screen slot which had volume defined as int that actually is a float value and causes the float to be truncated also the volume should be traslated int the VTreatmentAdjustmentUltrafiltratinConfirm to mL from Liter. Although HD wasn't using that value and was not complaining about it.

- Changed the current pew-set Volume value in the TreatmentAdjustmentUltrafiltrationEdit screen to be the current max value which is actually going to be changed by user.

- Changed to use the reference Volume to be used as the current collected volume in the Ultrafiltration section of the main treatment screen and the other Ultrafiltration adjustment screen that using it (Start. Paused, Edit).

- Added toString to the request models to be used for logging.

- Refactored the Message Interpreter response methods to be unique like the other improved latest methods (get<Method>s removed) [Reordered, Document cleanup, and so].

- Updated the manual in the MModel header for creating a model in regards to refactoring above.

- Updated Response Models in regards to the refactoring above.

- Made each byte space separator in Flags class in Types class for cleaner logging (will be used empty string in Alarm Status for logging).

- Changed the logging folder to be log folder (not event, error) and changed the log file extension for events/data to be .log and for errors to be .err.

- log file format modified to be CSV.

- Removed a not used fromByteArrayState method of mtreatmentadjustmentultrafiltrationconfirmresponse , mtreatmentadjustmentultrafiltrationeditresponse.

________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -0
    • +6
    /denali.pro
    • -4
    • +4
    /denali.pro.user
    • -3
    • +4
    /main.cpp
    • -1
    • +1
    /sources/applicationcontroller.cpp
    • -4
    • +18
    /sources/canbus/caninterface.cpp
    • -1
    • +1
    /sources/canbus/caninterface.h
    • -1
    • +1
    /sources/canbus/frameinterface.cpp
    • -6
    • +20
    /sources/canbus/messagebuilder.cpp
    • -1
    • +1
    /sources/canbus/messagebuilder.h
    • -6
    • +8
    /sources/canbus/messagedispatcher.cpp
    • -0
    • +3
    /sources/canbus/messageglobals.h
    • -459
    • +362
    /sources/canbus/messageinterpreter.cpp
    • -63
    • +38
    /sources/canbus/messageinterpreter.h
    • -1
    • +1
    /sources/gui/guicontroller.cpp
    • -0
    • +3
    /sources/gui/guiglobals.h
  16. … 48 more files in changeset.
4:02 pm

Peter Lucia <plucia@diality.com>

Added explanations to coco begin validated clauses

Options
    • -1
    • +1
    /sources/canbus/messagedispatcher.cpp
    • -1
    • +1
    /sources/view/valarmstatus.cpp
    • -1
    • +1
    /sources/view/valarmstatus.h
3:51 pm

Peter Lucia <plucia@diality.com>

Updated models and messaging tests for 100% code coverage. Fixed alarm status spacing.

Options
    • -1
    • +1
    /denali.pro.user
    • -36
    • +36
    /sources/model/malarmstatus.cpp
    • -2
    • +4
    /unittests/tst_messaging.cpp
    • -1
    • +1
    /unittests/tst_messaging.h
    • -0
    • +15
    /unittests/tst_models.cpp
    • -0
    • +2
    /unittests/tst_models.h
12:09 pm

Peter Lucia <plucia@diality.com>

Improved code coverage to 99.967%

Options
    • -4
    • +4
    /denali.pro.user
    • -0
    • +2
    /sources/canbus/messagedispatcher.cpp
    • -0
    • +2
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +0
    /sources/gui/guiview.h
    • -0
    • +2
    /sources/view/valarmstatus.cpp
    • -3
    • +1
    /sources/view/valarmstatus.h
    • -0
    • +42
    /unittests/tst_messaging.cpp
    • -0
    • +2
    /unittests/tst_messaging.h
Friday 26 Jun 2020
2:03 pm

Peter Lucia <plucia@diality.com>

Changed -q flag to disable hd communication timeout only, squishqt, code coverage changes

Options
    • -5
    • +5
    /main.cpp
    • -1
    • +2
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -1
    • +1
    /sources/main.h
    • -3
    • +4
    /sources/view/valarmstatus.cpp
    • -0
    • +4
    /sources/view/valarmstatus.h
Thursday 25 Jun 2020
5:55 pm

Peter Lucia <plucia@diality.com>

Updates to support unit testing

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /denali.qrc
    • -0
    • +7
    /main.cpp
    • -83
    • +0
    /sources/gui/qml/components/NotificationBar2.qml
    • -0
    • +83
    /sources/gui/qml/components/NotificationBarSmall.qml
    • -1
    • +1
    /sources/gui/qml/components/TouchArea.qml
    • -0
    • +1
    /sources/gui/qml/main.qml
    • -2
    • +5
    /sources/gui/qml/pages/SettingsHome.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentBase.qml
    • -0
    • +1
    /sources/main.h
    • -0
    • +5
    /sources/view/valarmstatus.cpp
9:44 am

Peter Lucia <plucia@diality.com>

Updated alarm ID an messages

Options
    • -52
    • +61
    /sources/model/malarmstatus.cpp
9:22 am

Peter Lucia <plucia@diality.com>

Merged master into UI Alarms.

Options
    • -2
    • +33
    /denali.pro
    • -106
    • +270
    /denali.pro.user
    • -1
    • +18
    /denali.qrc
    • -18
    • +33
    /main.cpp
    • -34
    • +2
    /sources/applicationcontroller.cpp
    • -8
    • +9
    /sources/applicationcontroller.h
    • -4
    • +80
    /sources/canbus/messagedispatcher.cpp
    • -4
    • +10
    /sources/canbus/messagedispatcher.h
    • -0
    • +15
    /sources/canbus/messageglobals.h
    • -20
    • +225
    /sources/canbus/messageinterpreter.cpp
    • -10
    • +2
    /sources/gui/guicontroller.cpp
    • -13
    • +3
    /sources/gui/guicontroller.h
    • -1
    • +18
    /sources/gui/guiglobals.h
    • -13
    • +0
    /sources/gui/guiview.h
    • -1
    • +6
    /sources/gui/qml/components/ModalDialog.qml
  16. … 11 more files in changeset.
Tuesday 23 Jun 2020
5:55 pm

Behrouz NematiPour

Merge branch 'DEN-3149_TreatmentUltrafiltrationAdjustment'

Options
5:18 pm

Behrouz NematiPour

DEN-3158 : Code Review 0

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.h
    • -1
    • +1
    /unittests/tst_canbus.cpp
    • -3
    • +0
    /unittests/tst_messaging.h
    • -8
    • +8
    /unittests/tst_models.cpp
    • -2
    • +2
    /unittests/tst_views.cpp
2:18 pm

Behrouz NematiPour

DEN-3157 : Code Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -1
    • +1
    /sources/model/mtreatmentadjustrequests.h
    • -12
    • +6
    /sources/view/vtreatmentadjustmentultrafiltrationstate.cpp
    • -0
    • +31
    /unittests/tst_views.cpp
    • -0
    • +2
    /unittests/tst_views.h
10:38 am

Peter Lucia <plucia@diality.com>

Added spaces

Options
    • -1
    • +3
    /sources/canbus/messageinterpreter.cpp
10:27 am

Peter Lucia <plucia@diality.com>

Removed unused import, renamed pressed to click

Options
    • -4
    • +4
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -2
    • +2
    /sources/gui/qml/main.qml
    • -1
    • +0
    /sources/gui/qml/pages/SettingsHome.qml
9:23 am

Peter Lucia <plucia@diality.com>

Updated valarmstatus.cpp

Options
    • -5
    • +3
    /sources/view/valarmstatus.cpp
8:56 am

Peter Lucia <plucia@diality.com>

Removed ColorOverlay and QGraphicalEffects

Options
    • -1
    • +1
    /resources/images/bell-off.svg
    • -1
    • +1
    /resources/images/bell.svg
    • -21
    • +2
    /sources/gui/qml/components/NotificationBar.qml
    • -10
    • +0
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -0
    • +1
    /sources/gui/qml/globals/Variables.qml
Monday 22 Jun 2020
9:13 pm

Behrouz NematiPour

DEN-3157 : Code Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -5
    • +5
    /denali.pro.user
    • -2
    • +2
    /sources/canbus/frameinterface.cpp
    • -7
    • +7
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +2
    /sources/gui/qml/pages/SettingsHome.qml
    • -0
    • +7
    /sources/model/mloadcellreadings.h
    • -0
    • +7
    /sources/model/mtemperaturesensors.h
    • -1
    • +1
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.h
    • -3
    • +7
    /sources/view/vtreatmentadjustmentultrafiltrationstate.cpp
    • -0
    • +10
    /unittests/tst_canbus.cpp
    • -0
    • +2
    /unittests/tst_canbus.h
    • -1
    • +26
    /unittests/tst_messaging.cpp
    • -1
    • +4
    /unittests/tst_messaging.h
    • -5
    • +312
    /unittests/tst_models.cpp
    • -0
    • +16
    /unittests/tst_models.h
2:12 pm

Peter Lucia <plucia@diality.com>

Fixed z order of mouse area

Options
    • -6
    • +6
    /sources/gui/qml/components/NotificationBar.qml
12:44 pm

Behrouz NematiPour

DEN-3157 : Code Coverage

- DEN-3158 : Code Review 0

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -2
    • +0
    /sources/gui/qml/components/UltrafiltrationButton.qml
    • -0
    • +222
    /unittests/tst_messaging.cpp
    • -1
    • +28
    /unittests/tst_messaging.h
    • -3
    • +3
    /unittests/tst_models.cpp
    • -1
    • +0
    /unittests/tst_models.h
11:04 am

Peter Lucia <plucia@diality.com>

Using message globals in applicationcontroller.h, moved guicontroller.h import to .cpp

Options
    • -0
    • +1
    /sources/applicationcontroller.cpp
    • -1
    • +1
    /sources/applicationcontroller.h
8:52 am

Peter Lucia <plucia@diality.com>

Moved #includes to cpp files.

Options
    • -0
    • +5
    /sources/applicationcontroller.cpp
    • -5
    • +0
    /sources/applicationcontroller.h
8:46 am

Peter Lucia <plucia@diality.com>

Address code review comments

Options
    • -2
    • +2
    /sources/gui/guiglobals.h
    • -59
    • +56
    /sources/gui/qml/components/NotificationBar.qml
    • -0
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -1
    • +1
    /sources/gui/qml/main.qml
4:36 am

Behrouz NematiPour

DEN-3156 Integration Testing

- 90.849% (1916/2109)

________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/canbus/messageinterpreter.h
    • -2
    • +4
    /sources/gui/qml/pages/SettingsHome.qml
    • -1
    • +4
    /sources/view/vtreatmentadjustmentultrafiltrationconfirm.h
    • -0
    • +2
    /sources/view/vtreatmentultrafiltration.h