application / sources

canbus

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 17 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 20 Sep 2021
9:03 pm

Behrouz NematiPour

Code Review Comments

- QApplication typo

- Added a UI version of the Log Macros.

Options
    • -1
    • +1
    ./CanInterface.cpp
    • -2
    • +2
    ./FrameInterface.cpp
    • -2
    • +2
    ./MessageAcknowModel.cpp
    • -2
    • +2
    ./MessageDispatcher.cpp
    • -4
    • +3
    ./MessageInterpreter.cpp
  6. … 9 more files in changeset.
8:47 pm

Behrouz NematiPour

1) This sleep helps the Bluetooth driver to load properly. 2) After many, many tests figured the Bluetooth device needs a power cycle after it is loaded and find out if giving it a 5-second delay b...

1) This sleep helps the Bluetooth driver to load properly.
2) After many, many tests figured the Bluetooth device needs a power cycle after it is loaded and find out if giving it a 5-second delay before setting the "hci" device to up, then it works fine and doesn't need the power cycle anymore. I timed the boot up and it's still under 30 seconds.
3) Yes it shouldn't break the loading of the other prototypes, since they may never even need it.

3:06 pm

pmontazemi  (deleted user)

QApplication is misspelled

QApplication is misspelled

3:06 pm

pmontazemi  (deleted user)

1) What is this sleep for? 2) How did you come up with its value? (I assume this is in seconds?) 3) Is this value consistent among all 4 prototypes and the development boards that we have?

1) What is this sleep for?
2) How did you come up with its value? (I assume this is in seconds?)
3) Is this value consistent among all 4 prototypes and the development boards that we have?

Thursday 16 Sep 2021
2:17 pm

Behrouz NematiPour

UI-DEN-9626_DEV Bluetooth Cuff Integration
UI-DEN-9626_DEV Bluetooth Cuff Integration
Monday 06 Sep 2021
10:08 pm

Behrouz NematiPour

DEN-9659: Implementation [POST]

- Created a separate file for the Bluetooth screen since it became bigger.

- Moved the WiFi and Bluetooth start in the Application controller and handled by POST events.

- Added a 5 second sleep for the Bluetooth Device to get ready in run.sh

- Added WiFi POST in run.sh

- Moved lambda functions for POST into slots.

- Added signals in the ApplicationPOST for passed items to be used in the ApplciationController to start WiFi and Bluetooth interfaces.

- Added isValid to the BluetoothInterface to make sure the Bluetooth Adapter is ready for the Interface to setup (Is set by ApplicationController with the information Provided by ApplicationPOST).

- Improved the Bluetooth interface implementation

- Added Rinseback safety volume parameter

- Modified the SAFE_CALL's methods to be public slots.

- Removed the SerialNumber listener from VBluetooth.

- Improved the VBluetooth code and added the connection to the BluetoothController.

Options
    • -1
    • +1
    ./MessageGlobals.h
  2. … 20 more files in changeset.
Wednesday 01 Sep 2021
8:07 pm

Behrouz NematiPour

Monday 30 Aug 2021
11:44 am

Sean Nash and pmontazemi  (deleted user)

8:21 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

Friday 20 Aug 2021
12:07 pm

Behrouz NematiPour

Adding the Acknowledge initialize log

Options
    • -0
    • +1
    ./MessageAcknowModel.cpp
Monday 16 Aug 2021
9:41 am

Behrouz NematiPour

DEN-9418: Code Review 0

- Cherry picked the code review updated from post branch

- Correcting the message IDs enum comments.

Options
    • -1
    • +2
    ./MessageDispatcher.cpp
    • -18
    • +18
    ./MessageGlobals.h
  3. … 2 more files in changeset.
9:37 am

Behrouz NematiPour

DEN-9418: Code Review 0

- Cherry picked the code review updated from post branch

- Function comments.

- Removed unused BLE alarm from alarm generator.

Options
    • -2
    • +2
    ./MessageGlobals.h
  2. … 6 more files in changeset.
Friday 13 Aug 2021
11:11 am

Sean Nash

RESOLVED.

RESOLVED.

11:11 am

Sean Nash

RESOLVED.

RESOLVED.

11:10 am

Sean Nash

RESOLVED.

RESOLVED.

11:10 am

Sean Nash

RESOLVED.

RESOLVED.

11:10 am

Sean Nash

RESOLVED.

RESOLVED.

11:00 am

Sean Nash

RESOLVED.

RESOLVED.

Thursday 12 Aug 2021
2:58 pm

Behrouz NematiPour

Updated.

Updated.

2:57 pm

Behrouz NematiPour

Added.

Added.

2:57 pm

Behrouz NematiPour

Added.

Added.

2:56 pm

Behrouz NematiPour

Added.

Added.

2:55 pm

Behrouz NematiPour

Added.

Added.

2:54 pm

Behrouz NematiPour

DEN-9418: Code Review 0

Options
    • -2
    • +2
    ./MessageGlobals.h
  2. … 6 more files in changeset.
2:49 pm

Behrouz NematiPour

It has been removed. We should reserve our Alarm System mostly for critical HW issues during treatment.

It has been removed.
We should reserve our Alarm System mostly for critical HW issues during treatment.

2:34 pm

Sean Nash

RESOLVED.

RESOLVED.

2:34 pm

Sean Nash

I mean, all others appear to be in the following order: 1) number of params and 2) size of params. So to be consistent, shouldn't this be 1 * 15 (1 param, 15 bytes)?

I mean, all others appear to be in the following order: 1) number of params and 2) size of params.
So to be consistent, shouldn't this be 1 * 15 (1 param, 15 bytes)?

2:32 pm

Sean Nash

RESOLVED.

RESOLVED.

2:32 pm

Sean Nash

RESOLVED.

RESOLVED.

2:32 pm

Sean Nash

RESOLVED.

RESOLVED.