Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-13969 Set property to expand margin for the RangeSlider item

DEN-14876 Separated signal handling for the highlight rectangle and root element of the RangeSlider to eliminate jumping behavior

DEN-13969 Restore commented out property in Slider.qml

DEN-14235 : No Option for Blood Pressure Measurement Off

  1. … 1 more file in changeset.
DEN-13977 : Increase the active area of the sliders OFF switch

- Another possibly easier way to increase the touch area.

DEN-13969 Update slider code to handle decimal sliders

DEN-13969 Added logic to adjust handler position and handling of steps less than handle width

    • -1
    • +3
    ./components/SliderCreateTreatment.qml
DEN-14858 : UI should navigate to Standby screen on Fault state

  1. … 3 more files in changeset.
DEN-14012 : Blood Pressure Measurement Interval UI update

  1. … 4 more files in changeset.
UI-DEN-14796_UI BN S91_2
UI-DEN-14796_UI BN S91_2
DEN-13977 Remove debugging red background color of switch

DEN-13969 Expand touch area to include left/right sides of handler and a slight bit beyond

DEN-13977 Increase the active area of the sliders OFF switch

UI-DEN-14838_UI VD S91 [ Sliders ]
UI-DEN-14838_UI VD S91 [ Sliders ]
DEN-14743 Add pairing confirmation dialog

    • -1
    • +19
    ./pages/settings/SettingsBluetoothCuff.qml
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 43 more files in changeset.
Merge branch 'DEN-14733-UI-BN-S90-2' into staging

    • -10
    • +13
    ./pages/treatment/TreatmentStack.qml
  1. … 37 more files in changeset.
Yes, assignments break bindings. RESOLVED

Yes, assignments break bindings.

RESOLVED

Ok, sounds good. RESOLVED

Ok, sounds good.

RESOLVED

Good point, But you can't. The readonly properties are only working with bindings, not assignments. I am using that as a public variable.

Good point,
But you can't.
The readonly properties are only working with bindings, not assignments.
I am using that as a public variable.

Good point, I agree with the two intervals, it would be clarifying. For the counter, though, it might not be always the case. I will start doing it in my next task, since I would like to change all...

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

Only a suggestion: It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity. For instance, here, we have ms and the next o...

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

RESOLVED

RESOLVED

Thanks for the feedback. Fixed.

Thanks for the feedback.
Fixed.

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.