Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-9418: Code Review 0

    • -1
    • +1
    ./qml/pages/treatment/TreatmentStack.qml
  1. … 3 more files in changeset.
It has only one parameter and is 15 bytes long. By definition, it is different than the others. 0x9900 153 0x020 Rsp Y HD UI HD serial number ASCII text - 15 bytes, not null term 0x8800 136 0x070...

It has only one parameter and is 15 bytes long.
By definition, it is different than the others.

0x9900 153 0x020 Rsp Y HD UI HD serial number ASCII text - 15 bytes, not null term
0x8800 136 0x070 Rsp Y DG UI DG serial number ASCII text - 15 bytes, not null term
It is a red line and has already been removed.

It is a red line and has already been removed.

If this is test code, add TODO to remove later.

If this is test code, add TODO to remove later.

Why not - 40? Can we remove?

Why not - 40? Can we remove?

Why commented out? Can we remove?

Why commented out? Can we remove?

Comment doesn't match code.

Comment doesn't match code.

Should this be 1 * 15 for consistency?

Should this be 1 * 15 for consistency?

Comment doesn't match code.

Comment doesn't match code.

Comment doesn't match code.

Comment doesn't match code.

Comment doesn't match code.

Comment doesn't match code.

Comment doesn't match code.

Comment doesn't match code.

No comment?

No comment?

Comment doesn't match code.

Comment doesn't match code.

Comment doesn't match code.

Comment doesn't match code.

Magic number?

Magic number?

This is not the version of the code presented in the demo and now it reads the actual HWClock, not the system clock is being kept by the Linux system. The first one was using the date which has bee...

This is not the version of the code presented in the demo and now it reads the actual HWClock, not the system clock is being kept by the Linux system.
The first one was using the date which has been noted, and it has been changed to the current implementation.

1. Replace couldn't with could not; 2. We decided to explore other means to obtain the true RTC clock rather than the MPU's Linux clock. What were the results of that exploration and where is it re...

1. Replace couldn't with could not;
2. We decided to explore other means to obtain the true RTC clock rather than the MPU's Linux clock. What were the results of that exploration and where is it reflected in this code?

DEN-9649: Implementation - Yocto configuration

- Addressed some frequent code review comments

- Fixed the UI POST AlarmTriggered message

- Added the deleteLater for the QQuickViewer pointer _viewer.

  1. … 106 more files in changeset.
RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Has been addressed in : http://dvm-linux02:7990/projects/UI/repos/application/commits/3ad21b53b6b15cc0c88661cf17ba454fe0a302b1
Has been addressed in : http://dvm-linux02:7990/projects/UI/repos/application/commits/3ad21b53b6b15cc0c88661cf17ba454fe0a302b1
Has been addressed in : http://dvm-linux02:7990/projects/UI/repos/application/commits/3ad21b53b6b15cc0c88661cf17ba454fe0a302b1
DEN-9614: Meetings & Support - General Support

Bug_Fixes :

- Fixed the issue in the log having null characters in the version message

- Fixing the issue with the bottom main menu not showing up after navigating back and forth from home screen.

- Removed the touchable property from the Treatment Review screen items.

New_Features :

-

Known_Bugs :

- N/A [Initial push]

Changes :

- Adding the acknowledge directly sending to the DG device by UI.

  1. … 10 more files in changeset.
UI-DEN-9411_UI Dev POST
UI-DEN-9411_UI Dev POST
DEN-9416: Implementations

- Added a newly added parameter of the BloodPrime (Safety Vol).

- UI POST is done.

- Out of 10 tests

1 - CANBus

2 - Touch Screen

3 - SD-Card

4 - RTC

tests are done.

- The

5 - File System integrity

will be done as part of CyberSecurity.

- The

6 - Bluetooth

will be added when the feature itself added to the application.

- The

7 - WiFi

is in progress and having issue correctly detect it.

- Some tests are listed to be added later in case required, like

8 - Display

9 - Ethernet

10- Sound

test couldn't find a way to test it yet.

- On each unsuccessful test an alarm will be triggered.

- UI alarms are in range of [250 - 259]

  1. … 17 more files in changeset.