application / sources

gui

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 10 Feb
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 05 Mar 2023
7:46 pm

Behrouz NematiPour

7:45 pm

vduong  (deleted user)

RESOLVED

RESOLVED

7:39 pm

vduong  (deleted user)

RESOLVED

RESOLVED

7:39 pm

vduong  (deleted user)

RESOLVED

RESOLVED

7:38 pm

Behrouz NematiPour

The reason is separation and keeping the logic of the Slider and its ON/OFF switch clear and non-confusing, and independent. Like right now that I had a wrong fix and I easily just changed the conn...

The reason is separation and keeping the logic of the Slider and its ON/OFF switch clear and non-confusing, and independent.
Like right now that I had a wrong fix and I easily just changed the connection related to the fix I had not changed the Slider implementation itself.

Saturday 04 Mar 2023
9:09 am

vduong  (deleted user)

Friday 03 Mar 2023
5:57 pm

vduong  (deleted user)

I disagree. If we bind the value here to the "active" property, the value it takes is whatever "active" has when the component gets created.

I disagree. If we bind the value here to the "active" property, the value it takes is whatever "active" has when the component gets created.

4:36 pm

Behrouz NematiPour

Unfortunately, we can't and it created a binding loop. I tried it.

Unfortunately, we can't and it created a binding loop.
I tried it.

4:35 pm

Behrouz NematiPour

This is the default value of the heparinStopTime. If you bind to the active of the dispensing switch nothing will happen, since the switch by default is active=false and if active is not changed, n...

This is the default value of the heparinStopTime.
If you bind to the active of the dispensing switch nothing will happen, since the switch by default is active=false and if active is not changed, no signal, therefore no property change will happen, and the enable remains unchanged, as true.

3:59 pm

vduong  (deleted user)

Binding here for instance, enabled: _heparinDispensingRateSwitch.active

Binding here for instance, enabled: _heparinDispensingRateSwitch.active

3:58 pm

vduong  (deleted user)

I believe we can bind the active state of _heparinDispensingRateSwitch and _heparinStopTime together.

I believe we can bind the active state of _heparinDispensingRateSwitch and _heparinStopTime together.

3:57 pm

vduong  (deleted user)

Is there a specific reason to why we are opting to use a connection here instead of handling the signal in the component body? (ie: line 181 further down?)

Is there a specific reason to why we are opting to use a connection here instead of handling the signal in the component body? (ie: line 181 further down?)

3:06 pm

jishii  (deleted user) , Sean Nash and Michael Garthwaite

2:01 pm

Dara Navaei

UI-DEN-14866_UI BN S92
UI-DEN-14866_UI BN S92
12:09 pm

Behrouz NematiPour

12:01 pm

jishii  (deleted user) and Tiffany Mejia

Monday 27 Feb 2023
1:58 pm

Dara Navaei

UI-DEN-14796_UI BN S91_2
UI-DEN-14796_UI BN S91_2
Friday 24 Feb 2023
6:01 pm

Dara Navaei

UI-DEN-14838_UI VD S91 [ Sliders ]
UI-DEN-14838_UI VD S91 [ Sliders ]
Friday 10 Feb 2023
9:23 am

Behrouz NematiPour

9:23 am

Behrouz NematiPour

9:23 am

Michael Garthwaite , vduong  (deleted user) and jishii  (deleted user)

9:20 am

Sean Nash and vduong  (deleted user)

9:18 am

vduong  (deleted user)

Yes, assignments break bindings. RESOLVED

Yes, assignments break bindings.

RESOLVED

9:17 am

vduong  (deleted user)

Ok, sounds good. RESOLVED

Ok, sounds good.

RESOLVED

8:23 am

Behrouz NematiPour

Good point, But you can't. The readonly properties are only working with bindings, not assignments. I am using that as a public variable.

Good point,
But you can't.
The readonly properties are only working with bindings, not assignments.
I am using that as a public variable.

8:17 am

Behrouz NematiPour

Good point, I agree with the two intervals, it would be clarifying. For the counter, though, it might not be always the case. I will start doing it in my next task, since I would like to change all...

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

8:14 am

vduong  (deleted user)

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

7:40 am

vduong  (deleted user)

Only a suggestion: It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity. For instance, here, we have ms and the next o...

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

7:16 am

vduong  (deleted user)

RESOLVED

RESOLVED

7:12 am

Behrouz NematiPour

Thanks for the feedback. Fixed.

Thanks for the feedback.
Fixed.