MAdjustHDServiceModeResponse.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
UI-DEN-SUNRISE
UI-DEN-SUNRISE
RESOLVED.

RESOLVED.

Thanks, Will update my comment.

Thanks,
Will update my comment.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Your comment has ???. Trying to help.

Your comment has ???. Trying to help.

Fixed too.

Fixed too.

Great catch, Thank a lot Sean for catching that. It is fixed.

Great catch,
Thank a lot Sean for catching that.
It is fixed.

Not clear what you want me to do here?

Not clear what you want me to do here?

In post-treatment, there are a few states to work through to ensure reservoirs get drained: /* Post-Treatment drain reservoirs state machine. */ typedef enum Drain_States { DRAIN_DG_DEPRIME_STATE ...

In post-treatment, there are a few states to work through to ensure reservoirs get drained:

/* Post-Treatment drain reservoirs state machine. */
typedef enum Drain_States
{
DRAIN_DG_DEPRIME_STATE = 0, ///< Drain DG De-prime dialysate lines of excess fluid state.
DRAIN_RESERVOIR_SWITCH_STATE, ///< Switch reservoir state.
DRAIN_RESERVOIR_START_DRAIN_STATE, ///< Drain reservoir start drain state.
DRAIN_RESERVOIR_DRAIN_STATE, ///< Drain first reservoir state.
DRAIN_RESERVOIR_COMPLETE_STATE, ///< Drain complete state.
NUM_OF_DRAIN_STATES ///< Number of drain states.
} DRAIN_STATE_T;

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

UI-DEN-14936_UI BN S93
UI-DEN-14936_UI BN S93
UI-DEN-14936_UI BN S93
UI-DEN-14936_UI BN S93
RESOLVED.

RESOLVED.

Sure Sean, if that is the decision, will do it soon and create a case for that. I also believe some other CL Switches need to be removed, which were only implemented for our testing at the time (CA...

Sure Sean, if that is the decision, will do it soon and create a case for that.
I also believe some other CL Switches need to be removed, which were only implemented for our testing at the time (CANBus).

Issue DEN-13441 - MR: Make the Dialin log permanent with no switch [CL switches review/removal] has been successfully created

If this is to log Dialin messages, we should always do that (no switch). If a Dialin command is given/responded to, we definitely want to know about that - so want to see it in the log. Dialin comm...

If this is to log Dialin messages, we should always do that (no switch). If a Dialin command is given/responded to, we definitely want to know about that - so want to see it in the log. Dialin commands are always one-shot type messages, so will not impact log size.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED

RESOLVED