MTreatmentRangesData.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED. My understanding is that this will be connected in a future story

RESOLVED.
My understanding is that this will be connected in a future story

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Done

Done

Removed.

Removed.

Is there a reason these shouldn't be deleted?

Is there a reason these shouldn't be deleted?

RESOLVED.

RESOLVED.

To make it consistent these could also be red and white without double quotes

To make it consistent these could also be red and white without double quotes

done

done

Thanks for reminding that. updated all the other ones as well. done.

Thanks for reminding that.
updated all the other ones as well.
done.

Great question. There would be another connection for the message "Treatment Parameters validation" and that will update the properties here when that message with parameters received. It would be ...

Great question.
There would be another connection for the message "Treatment Parameters validation" and that will update the properties here when that message with parameters received.
It would be an extra :
ACTION_VIEW_CONNECTION(AdjustPressuresLimitsResponseData);
with the correct model as a parameter and another:
void VTreatmentAdjustmentPressuresLimits::onActionReceive(const AdjustPressuresLimitsResponseData &vData)
with that model as parameter.

The message ID is in decimal not hex

The message ID is in decimal not hex

Once the user has selected the arterial and venous pressure limits in pre-treatment, before they try to adjust them, how are the values they chose in pre-treatment displayed here?

Once the user has selected the arterial and venous pressure limits in pre-treatment, before they try to adjust them, how are the values they chose in pre-treatment displayed here?

Remove extra line.

Remove extra line.

UI-DEN-4691_Inline Blood Pressure Adjustments
UI-DEN-4691_Inline Blood Pressure Adjustments
RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

This is not UI Application Software naming conventions. This enum comes from HDDefs.h@223 as part of the Firmware shared code with Software on Common repo. In short, it is not our code.

This is not UI Application Software naming conventions.
This enum comes from HDDefs.h@223 as part of the Firmware shared code with Software on Common repo.
In short, it is not our code.

done.

done.

in Qml codes when needs to have private members since we don't have that concept, a QtObject item with id "_private" will be created. "_" is for private and private is to emphasis on the private si...

in Qml codes when needs to have private members since we don't have that concept, a QtObject item with id "_private" will be created.
"_" is for private and private is to emphasis on the private since there is no actual private keyword in Qt<6 available.
And there should be a unique one in each context.

If it was necessary to rename Saline_States to Saline_Bolus_States, shouldn't you rename GuiSalineStates to GuiSalineBolusStates as well?

If it was necessary to rename Saline_States to Saline_Bolus_States, shouldn't you rename GuiSalineStates to GuiSalineBolusStates as well?

Why is this named _private? Could there be a better name?

Why is this named _private? Could there be a better name?

Better to not use global variables unless absolutely necessary

Better to not use global variables unless absolutely necessary

UI-DEN-5283_Saline Bolus FW Modification
UI-DEN-5283_Saline Bolus FW Modification