Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Bamboo Commit: Updated MAlarmMapping.cpp

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Bamboo Commit: Updated MAlarmMapping.cpp

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 15 more files in changeset.
DEN-14012 : Blood Pressure Measurement Interval UI update

  1. … 5 more files in changeset.
UI-DEN-14796_UI BN S91_2
UI-DEN-14796_UI BN S91_2
DEN-14743 Add bluetooth pairing agent code to retain pairing status in bluez

  1. … 8 more files in changeset.
Bamboo Commit: Updated MAlarmMapping.cpp

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 1 more file in changeset.
Bamboo Commit: Updated MAlarmMapping.cpp

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Bamboo Commit: Updated MAlarmMapping.cpp

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 42 more files in changeset.
Merge branch 'DEN-14733-UI-BN-S90-2' into staging

    • -13
    • +45
    ./dg/data/MDGTemperaturesData.cpp
  1. … 35 more files in changeset.
Yes, assignments break bindings. RESOLVED

Yes, assignments break bindings.

RESOLVED

Ok, sounds good. RESOLVED

Ok, sounds good.

RESOLVED

Good point, But you can't. The readonly properties are only working with bindings, not assignments. I am using that as a public variable.

Good point,
But you can't.
The readonly properties are only working with bindings, not assignments.
I am using that as a public variable.

Good point, I agree with the two intervals, it would be clarifying. For the counter, though, it might not be always the case. I will start doing it in my next task, since I would like to change all...

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

Only a suggestion: It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity. For instance, here, we have ms and the next o...

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

RESOLVED

RESOLVED

Thanks for the feedback. Fixed.

Thanks for the feedback.
Fixed.

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.