application / sources

model

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 05 Feb
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 29 Mar 2023
3:50 pm

Sean Nash

In post-treatment, there are a few states to work through to ensure reservoirs get drained: /* Post-Treatment drain reservoirs state machine. */ typedef enum Drain_States { DRAIN_DG_DEPRIME_STATE ...

In post-treatment, there are a few states to work through to ensure reservoirs get drained:

/* Post-Treatment drain reservoirs state machine. */
typedef enum Drain_States
{
DRAIN_DG_DEPRIME_STATE = 0, ///< Drain DG De-prime dialysate lines of excess fluid state.
DRAIN_RESERVOIR_SWITCH_STATE, ///< Switch reservoir state.
DRAIN_RESERVOIR_START_DRAIN_STATE, ///< Drain reservoir start drain state.
DRAIN_RESERVOIR_DRAIN_STATE, ///< Drain first reservoir state.
DRAIN_RESERVOIR_COMPLETE_STATE, ///< Drain complete state.
NUM_OF_DRAIN_STATES ///< Number of drain states.
} DRAIN_STATE_T;

3:29 pm

Sean Nash

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

3:27 pm

Sean Nash

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

Tuesday 28 Mar 2023
3:49 pm

vduong  (deleted user)

Resolved.

Resolved.

12:49 pm

Behrouz NematiPour

Please use Changed and align

Please use Changed
and align

Thursday 23 Mar 2023
8:01 am

Dara Navaei

UI-DEN-14937-UI-VD-S93 [TxCreateRejection]
UI-DEN-14937-UI-VD-S93 [TxCreateRejection]
Tuesday 21 Mar 2023
8:35 pm

Behrouz NematiPour

4:25 am

Behrouz NematiPour

UI-DEN-14936_UI BN S93
UI-DEN-14936_UI BN S93
4:09 am

Behrouz NematiPour

Thursday 16 Mar 2023
9:08 am

Tiffany Mejia

Wednesday 15 Mar 2023
4:01 am

Dara Navaei

UI-DEN-14936_UI BN S93
UI-DEN-14936_UI BN S93
Tuesday 14 Mar 2023
11:45 am

vduong  (deleted user) and jishii  (deleted user)

10:17 am

Dara Navaei

10:07 am

Dara Navaei

UI-DEN-14866_UI BN S92
UI-DEN-14866_UI BN S92
Friday 03 Mar 2023
12:09 pm

Behrouz NematiPour

12:01 pm

jishii  (deleted user) and Tiffany Mejia

Monday 27 Feb 2023
1:58 pm

Dara Navaei

UI-DEN-14796_UI BN S91_2
UI-DEN-14796_UI BN S91_2
Friday 10 Feb 2023
9:23 am

Behrouz NematiPour

9:23 am

Behrouz NematiPour

9:23 am

Michael Garthwaite , vduong  (deleted user) and jishii  (deleted user)

9:20 am

Sean Nash and vduong  (deleted user)

9:18 am

vduong  (deleted user)

Yes, assignments break bindings. RESOLVED

Yes, assignments break bindings.

RESOLVED

9:17 am

vduong  (deleted user)

Ok, sounds good. RESOLVED

Ok, sounds good.

RESOLVED

8:23 am

Behrouz NematiPour

Good point, But you can't. The readonly properties are only working with bindings, not assignments. I am using that as a public variable.

Good point,
But you can't.
The readonly properties are only working with bindings, not assignments.
I am using that as a public variable.

8:17 am

Behrouz NematiPour

Good point, I agree with the two intervals, it would be clarifying. For the counter, though, it might not be always the case. I will start doing it in my next task, since I would like to change all...

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

8:14 am

vduong  (deleted user)

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

7:40 am

vduong  (deleted user)

Only a suggestion: It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity. For instance, here, we have ms and the next o...

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

7:16 am

vduong  (deleted user)

RESOLVED

RESOLVED

7:12 am

Behrouz NematiPour

Thanks for the feedback. Fixed.

Thanks for the feedback.
Fixed.

7:03 am

vduong  (deleted user)

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.