Activity application/sources

Good point, I agree with the two intervals, it would be clarifying. For the counter, though, it might not be always the case. I will start doing it in my next task, since I would like to change all...

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

8:14 am

vduong (deleted user)

More
Re: UI-DEN-14733-2
commented on review

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

7:40 am

vduong (deleted user)

More
Re: UI-DEN-14517-1
commented on review

Only a suggestion: It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity. For instance, here, we have ms and the next o...

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

7:16 am

vduong (deleted user)

RESOLVED

7:12 am

Behrouz NematiPour

More
Re: UI-DEN-14517-1
replied to vduong (deleted user)

Thanks for the feedback. Fixed.

Thanks for the feedback.
Fixed.

7:12 am

Behrouz NematiPour

More
73d6195
changed 1 file
master, @Environement_Swith and 177 more UI-DEN-14517-1

CR comment: UI-DEN-14517-1#c16470

http://devapps.diality.us:8060/cru/UI-DEN-14517-1#c16470

- -1
- +1
./cloudsync/CloudSyncController.cpp
- History
- Source
- Diff
./cloudsync/CloudSyncController.cpp

7:03 am

vduong (deleted user)

More
Re: UI-DEN-14517-1
commented on review

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

6:41 am

Behrouz NematiPour

DEN-14736 : IMP: DEN-14768 : InTx UF Adj

DEN-14768

Ultrafiltration Adjustment Screen Slider Does Not Update Maximum UF Vol after Duration Settings Adjustment

- -10
- +12
./gui/qml/components/Slider.qml
- History
- Source
- Diff
./gui/qml/components/Slider.qml

10:40 pm

Behrouz NematiPour

DEN-14736 : IMP: Updated MsgID 0x2D00

/*!

* \brief The MDGTemperatures class

* \details The DG temperatures data model

*

* | MSG | CAN ID | Box | Type | Ack | Src | Dst | Description |

* |:----:|:------:|:---:|:------:|:---:|:---:|:---:|:-----------: |

* |0x2D00| 0x080 | 8 | 2 Hz | N | DG | All | DG Temperatures Data |

*

* | Payload ||

* | ||

* | #01:(F32) | \ref Data::mInletPrimaryHeater |

* | #02:(F32) | \ref Data::mHeatDisinfect |

* | #03:(F32) | \ref Data::mOutletPrimaryHeater |

* | #04:(F32) | \ref Data::mConductivitySensor1 |

* | #05:(F32) | \ref Data::mConductivitySensor2 |

* | #06:(F32) | \ref Data::mOutletRedundancy |

* | #07:(F32) | \ref Data::mInletDialysate |

* | #08:(F32) | \ref Data::mPrimaryHeaterThermoCouple |

* | #09:(F32) | \ref Data::mTrimmerHeaterThermoCouple |

* | #10:(F32) | \ref Data::mPrimaryHeaterColdJunction |

* | #11:(F32) | \ref Data::mTrimmerHeaterColdJunction |

* | #12:(F32) | \ref Data::mPrimaryHeaterInternal |

* | #13:(F32) | \ref Data::mTrimmerHeaterInternal |

* | #14:(F32) | \ref Data::mFpgaBoard |

* | #15:(F32) | \ref Data::mLoadCellA1B1 |

* | #16:(F32) | \ref Data::mLoadCellA2B2 |

* | #17:(F32) | \ref Data::mInternalTHDORTD |

* | #18:(F32) | \ref Data::mInternalTDIRTD |

* | #19:(F32) | \ref Data::mInteralTHDRTD |

* | #20:(F32) | \ref Data::mInternalCondSnsrTemp |

* | #21:(F32) | \ref Data::mBaroTempSensor |

*

* \sa Data

*

* <h2 class="groupheader">Logging info</h2>

* | ||

* | typeText | Datum |

* | unitText | DG |

* | infoText | Temperatures |

*

*/

- -2
- +2
./canbus/MessageGlobals.h
- History
- Source
- Diff
./canbus/MessageGlobals.h
- -3
- +3
./gui/qml/components/DebugDataColumn.qml
- History
- Source
- Diff
./gui/qml/components/DebugDataColumn.qml
- -7
- +23
./gui/qml/dialogs/DiagnosticsDialog.qml
- History
- Source
- Diff
./gui/qml/dialogs/DiagnosticsDialog.qml
- -13
- +45
./model/dg/data/MDGTemperaturesData.cpp
- History
- Source
- Diff
./model/dg/data/MDGTemperaturesData.cpp
- -26
- +50
./model/dg/data/MDGTemperaturesData.h
- History
- Source
- Diff
./model/dg/data/MDGTemperaturesData.h
- -13
- +21
./view/dg/data/VDGTemperaturesData.cpp
- History
- Source
- Diff
./view/dg/data/VDGTemperaturesData.cpp
- -0
- +8
./view/dg/data/VDGTemperaturesData.h
- History
- Source
- Diff
./view/dg/data/VDGTemperaturesData.h

8:56 pm

Behrouz NematiPour

DEN-14736 : IMP: Updated MsgID 0x2000

/*!

* \brief The MDGPressures class

* \details The DG pressures data model

*

* | MSG | CAN ID | Box | Type | Ack | Src | Dst | Description |

* |:----:|:------:|:---:|:------:|:---:|:---:|:---:|:-----------: |

* |0x2000| 0x080 | 8 | 1 Hz | N | DG | All | DG Pressures Data |

*

* | Payload ||

* | ||

* | #1:(F32) | \ref Data::mROInletPSI |

* | #2:(F32) | \ref Data::mROOutletPSI |

* | #3:(F32) | \ref Data::mDrainInletPSI |

* | #4:(F32) | \ref Data::mDrainOutletPSI |

* | #5:(F32) | \ref Data::mBarometricPSI |

*

* \sa Data

*

* <h2 class="groupheader">Logging info</h2>

* | ||

* | typeText | Datum |

* | unitText | DG |

* | infoText | Pressures |

*

*/

- -10
- +15
./gui/qml/dialogs/DiagnosticsDialog.qml
- History
- Source
- Diff
./gui/qml/dialogs/DiagnosticsDialog.qml
- -12
- +16
./model/dg/data/MDGPressuresData.cpp
- History
- Source
- Diff
./model/dg/data/MDGPressuresData.cpp
- -4
- +7
./model/dg/data/MDGPressuresData.h
- History
- Source
- Diff
./model/dg/data/MDGPressuresData.h
- -4
- +5
./view/dg/data/VDGPressuresData.cpp
- History
- Source
- Diff
./view/dg/data/VDGPressuresData.cpp
- -4
- +5
./view/dg/data/VDGPressuresData.h
- History
- Source
- Diff
./view/dg/data/VDGPressuresData.h

8:55 pm

Behrouz NematiPour

DEN-14736 : IMP: Updated MsgID 0x5C00

/*!

* \brief The MTreatmentStates class

* \details The treatment states data model

* These are states of the current treatment.

* It also includes the ultrafiltration states, saline bolus states.

*

* | MSG | CAN ID | Box | Type | Ack | Src | Dst | Description |

* |:----:|:------:|:---:|:------:|:---:|:---:|:---:|:-----------: |

* |0x5C00| 0x040 | 7 | 1 Hz | N | HD | All | Pre-Treatment States Data |

*

* | Payload ||

* | ||

* | #1:(U32) | \ref Data::mSubMode |

* | #2:(U32) | \ref Data::mWaterSampleState |

* | #3:(U32) | \ref Data::mSelfTestConsumablesState |

* | #4:(U32) | \ref Data::mSelfTestNoCartridgeState |

* | #5:(U32) | \ref Data::mInstallationState |

* | #6:(U32) | \ref Data::mSelfTestDryState |

* | #7:(U32) | \ref Data::mPrimeState |

* | #8:(U32) | \ref Data::mRecirculateState |

* | #9:(U32) | \ref Data::mPatientConnectionState |

* | #9:(U32) | \ref Data::mWetSelfTestsState |

* | #9:(U32) | \ref Data::mPreTreatmentRsrvrState |

*

* \sa Data

* \sa HD_Pre_Treatment_Mode_States

* \sa HD_Pre_Treatment_Sample_Water_States

* \sa HD_Pre_Treatment_Consumable_Self_Test_States

* \sa HD_Pre_Treatment_No_Cart_Self_Tests_States

* \sa HD_Pre_Treatment_Dry_Self_Tests_States

* \sa HD_Pre_Treatment_Prime_States

* \sa HD_Pre_Treatment_Recirc_States

*

* <h2 class="groupheader">Logging info</h2>

* | ||

* | typeText | Datum |

* | unitText | HD |

* | infoText | PreTreatmentStates |

*

*/

- -1
- +1
./canbus/MessageGlobals.h
- History
- Source
- Diff
./canbus/MessageGlobals.h
- -0
- +8
./model/hd/data/pretreatment/MPreTreatmentStatesData.cpp
- History
- Source
- Diff
./model/hd/.../MPreTreatmentStatesData.cpp
- -29
- +35
./model/hd/data/pretreatment/MPreTreatmentStatesData.h
- History
- Source
- Diff
./model/hd/.../MPreTreatmentStatesData.h
- -0
- +2
./view/hd/data/pretreatment/VPreTreatmentStatesData.cpp
- History
- Source
- Diff
./view/hd/.../VPreTreatmentStatesData.cpp
- -0
- +2
./view/hd/data/pretreatment/VPreTreatmentStatesData.h
- History
- Source
- Diff
./view/hd/.../VPreTreatmentStatesData.h

7:19 pm

Behrouz NematiPour

DEN-14736 : IMP: Updated MsgID 0x2C00

/*!

* \brief The MDGHeaters class

* \details The DG heaters data model

*

* | MSG | CAN ID | Box | Type | Ack | Src | Dst | Description |

* |:----:|:------:|:---:|:------:|:---:|:---:|:---:|:-----------: |

* |0x2C00| 0x080 | 8 | 2 Hz | N | DG | All | DG Heaters Data |

*

* | Payload ||

* | ||

* | # 1:(F32) | \ref Data::mMainPrimayHeaterDC |

* | # 2:(F32) | \ref Data::mSmallPrimaryHeaterDC |

* | # 3:(F32) | \ref Data::mTrimmerHeaterDC |

* | # 4:(F32) | \ref Data::mPrimaryTargetTemp |

* | # 5:(F32) | \ref Data::mTrimmerTargetTemp |

* | # 6:(F32) | \ref Data::mPrimaryHeaterState |

* | # 7:(F32) | \ref Data::mTrimmerHeaterState |

* | # 8:(F32) | \ref Data::mPrimaryEfficiency |

* | # 9:(F32) | \ref Data::mPrimaryCalcTargetTemp |

* | #10:(F32) | \ref Data::mTrimmerCalcCurrentTemp |

* | #11:(F32) | \ref Data::mTrimmerUseLastDC |

*

* \sa Data

*

* <h2 class="groupheader">Logging info</h2>

* | ||

* | typeText | Datum |

* | unitText | DG |

* | infoText | Heaters |

*

*/

- -1
- +1
./canbus/MessageGlobals.h
- History
- Source
- Diff
./canbus/MessageGlobals.h
- -3
- +3
./gui/qml/dialogs/DiagnosticsDialog.qml
- History
- Source
- Diff
./gui/qml/dialogs/DiagnosticsDialog.qml
- -9
- +42
./model/dg/data/MDGHeatersData.cpp
- History
- Source
- Diff
./model/dg/data/MDGHeatersData.cpp
- -10
- +33
./model/dg/data/MDGHeatersData.h
- History
- Source
- Diff
./model/dg/data/MDGHeatersData.h
- -3
- +11
./view/dg/data/VDGHeatersData.cpp
- History
- Source
- Diff
./view/dg/data/VDGHeatersData.cpp
- -4
- +12
./view/dg/data/VDGHeatersData.h
- History
- Source
- Diff
./view/dg/data/VDGHeatersData.h
… 1 more file in changeset.

4:39 pm

jishii (deleted user)

More
UI-DEN-14733-2
resumed reviewing

4:38 pm

Behrouz NematiPour

DEN-14736 : IMP: DEN-14486

- DEN-14486 : Incorrect alarm notification appears during DG Flush

- -1
- +1
./model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
./model/hd/alarm/MAlarmMapping.cpp
- -3
- +32
./view/hd/alarm/VAlarmActiveList.cpp
- History
- Source
- Diff
./view/hd/alarm/VAlarmActiveList.cpp
- -1
- +6
./view/hd/alarm/VAlarmActiveList.h
- History
- Source
- Diff
./view/hd/alarm/VAlarmActiveList.h
- -0
- +6
./view/hd/alarm/VAlarmStatus.cpp
- History
- Source
- Diff
./view/hd/alarm/VAlarmStatus.cpp
- -1
- +1
./view/hd/alarm/VAlarmStatus.h
- History
- Source
- Diff
./view/hd/alarm/VAlarmStatus.h
… 2 more files in changeset.

1:55 pm

Vy <vduong@sunriselabs.com>

More
c447018
changed 5 files
DEN-14743-UI-VD-S90

DEN-14743 Bluetooth bug fixes - improve connection handling and message display

- -10
- +101
./bluetooth/BluetoothInterface.cpp
- History
- Source
- Diff
./bluetooth/BluetoothInterface.cpp
- -1
- +2
./bluetooth/BluetoothInterface.h
- History
- Source
- Diff
./bluetooth/BluetoothInterface.h
- -1
- +1
./gui/qml/pages/settings/SettingsBluetoothCuff.qml
- History
- Source
- Diff
./gui/qml/.../SettingsBluetoothCuff.qml
- -0
- +1
./model/settings/MBluetooth.h
- History
- Source
- Diff
./model/settings/MBluetooth.h
- -1
- +5
./view/settings/VBluetooth.cpp
- History
- Source
- Diff
./view/settings/VBluetooth.cpp

11:08 am

Sean Nash

So we will likely remove this TODO and comment later? RESOLVED.

So we will likely remove this TODO and comment later?
RESOLVED.

sources

Stats

Commits this week: 8

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Dara Navaei

Vy <vduong@sunriselabs.com>

Vy <vduong@sunriselabs.com>

Dara Navaei

Dara Navaei

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Michael Garthwaite , vduong (deleted user) and jishii (deleted user)

Sean Nash and vduong (deleted user)

vduong (deleted user)

vduong (deleted user)

Behrouz NematiPour

Behrouz NematiPour

vduong (deleted user)

vduong (deleted user)

vduong (deleted user)

Behrouz NematiPour

Behrouz NematiPour

vduong (deleted user)

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

jishii (deleted user)

Behrouz NematiPour

Vy <vduong@sunriselabs.com>

Sean Nash