common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 28 Dec 2020
10:46 am

Dara Navaei

DEN-6081 added another alarm ID for flow rate out of lower range

Options
    • -1
    • +4
    /AlarmDefs.h
    • -7
    • +17
    /DGDefs.h
Monday 21 Dec 2020
2:06 pm

Behrouz NematiPour

quick_fix_01

- changed the enum index to 49 to be like the previous so the test won't fail.

Options
    • -1
    • +1
    /AlarmDefs.h
12:12 pm

Behrouz NematiPour

quick_fix_01

- During the headless SquishQt test found out that a change on the common repo made the build failed.

- The modification was deletion of ALARM_ID_TEMPERATURE_SENSORS_INCONSISTENT enum item.

It has been reverted back to make the build work with application master branch but checking out to this branch for the use of common codes.

Options
    • -16
    • +20
    /AlarmDefs.h
Friday 18 Dec 2020
3:47 pm

Sean Nash

Merge branch 'Sprint33' into develop

Options
3:47 pm

Sean Nash

DEN-5674: Added msg ID for auto-ACK to enum. Updated some alarm properties in alarm table.

Options
    • -1
    • +1
    /AlarmDefs.h
    • -0
    • +2
    /MsgDefs.h
11:28 am

Sean Nash

DEN-5674: Fixed alignment of alarms table header.

Options
    • -1
    • +1
    /AlarmDefs.h
Thursday 17 Dec 2020
4:20 pm

qnguyen  (deleted user)

It is at the beginning of Prime sub-mode.

It is at the beginning of Prime sub-mode.

4:17 pm

Sean Nash

Where did command to start reservoir 2 as active get moved to?

Where did command to start reservoir 2 as active get moved to?

4:05 pm

Sean Nash

Merge branch 'Sprint33' into develop

Options
1:28 pm

Quang Nguyen <qnguyen@diality.com>

DEN-5381: Added reservoir one fill complete state for prime sub-mode

Options
    • -0
    • +1
    /HDDefs.h
1:26 pm

qnguyen  (deleted user)

Moved into its own state.

Moved into its own state.

1:14 pm

qnguyen  (deleted user)

Removed.

Removed.

1:13 pm

qnguyen  (deleted user)

Done.

Done.

1:13 pm

qnguyen  (deleted user)

Done.

Done.

1:12 pm

qnguyen  (deleted user)

Added common into code review.

Added common into code review.

10:56 am

Sean Nash

I think this waiting for DG should be done in its own state.

I think this waiting for DG should be done in its own state.

10:48 am

Sean Nash

Should be an elseif?

Should be an elseif?

10:47 am

Sean Nash

I didn't see these states defined in this module. Where is the enum declared? If in common, I don't see common code in this code review project.

I didn't see these states defined in this module. Where is the enum declared? If in common, I don't see common code in this code review project.

10:44 am

Sean Nash

Moved to common AlarmDefs.h.

Moved to common AlarmDefs.h.

10:38 am

Sean Nash

Should reset state to start state here or we won't be able to do a second treatment.

Should reset state to start state here or we won't be able to do a second treatment.

9:22 am

pmontazemi  (deleted user)

If commented code, either remove it or add TODO comment to remember to either uncomment it or delete it in the future.

If commented code, either remove it or add TODO comment to remember to either uncomment it or delete it in the future.

9:21 am

pmontazemi  (deleted user)

Where were these moved to?

Where were these moved to?

8:40 am

qnguyen  (deleted user)

HD-DEN-5381_HD Prime Blood Side
HD-DEN-5381_HD Prime Blood Side
Wednesday 16 Dec 2020
2:28 pm

Sean Nash

DEN-5674: Obsoleted unused alarm ID.

Options
    • -19
    • +19
    /AlarmDefs.h
11:41 am

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Remove unused standby states

Options
    • -4
    • +0
    /HDDefs.h
11:41 am

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Remove unused standby states

Options
    • -4
    • +0
    /HDDefs.h
Monday 14 Dec 2020
10:48 am

Sean Nash

Merge branch 'Sprint33' into develop

Options
10:48 am

Sean Nash

DEN-5674: Moved alarm lamp self test from early to later in sequence.

Options
    • -1
    • +1
    /HDDefs.h
10:47 am

Sean Nash

DEN-5674: Moved alarm lamp self test from early to later in sequence.

Options
    • -1
    • +1
    /HDDefs.h
Friday 11 Dec 2020
1:56 pm

Sean Nash

Merge branch 'Sprint33' into develop

Options