common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 21 Jan 2021
11:20 am

Sean Nash

Merge branch 'Sprint37' into develop

Options
10:40 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

qnguyen  (deleted user)

Before, the HD sends target temperature using another message. So now we add the target temperature to this command, so DG can handle the full command.

Before, the HD sends target temperature using another message. So now we add the target temperature to this command, so DG can handle the full command.

10:37 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:28 am

pmontazemi  (deleted user)

What made us change our mind and pass in set temperature command compared to before (just turning OFF and ON)?

What made us change our mind and pass in set temperature command compared to before (just turning OFF and ON)?

10:20 am

qnguyen  (deleted user)

Added the switch statement. Added comment and TODO.

Added the switch statement.
Added comment and TODO.

10:19 am

qnguyen  (deleted user)

Reverted the deletion.

Reverted the deletion.

10:19 am

qnguyen  (deleted user)

Reverted the deletion.

Reverted the deletion.

9:46 am

Sean Nash

Heat disinfect may need this function to set target temp to 85°C.

Heat disinfect may need this function to set target temp to 85°C.

9:45 am

Sean Nash

How will DG control the trimmer heater (e.g. in heat disinfect mode) without this function? Trimmer heater not always started by HD command message.

How will DG control the trimmer heater (e.g. in heat disinfect mode) without this function? Trimmer heater not always started by HD command message.

9:20 am

Sean Nash

Consider having a switch statement here for each reject reason code. Maybe we're only handling the invalid parameter reason for now, but we may change our minds later. You can group the rest of the...

Consider having a switch statement here for each reject reason code. Maybe we're only handling the invalid parameter reason for now, but we may change our minds later. You can group the rest of the reasons+default with just a comment that our state machines will detect and handle failure of DG to advance for now. This will make it clear that we didn't forget about the other cases.

Wednesday 20 Jan 2021
7:26 pm

qnguyen  (deleted user)

Signals have been forwarded to appropriate sub-mode to handle.

Signals have been forwarded to appropriate sub-mode to handle.

7:22 pm

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Added pre-treatment re-circulate start state

Options
    • -1
    • +3
    /HDDefs.h
6:35 pm

Sean Nash

DEN-5887: Added new alarms for load cell acceleration events.

Options
    • -0
    • +4
    /AlarmDefs.h
12:38 pm

qnguyen  (deleted user)

Function has been moved to heater module. Target temperature has been added as part of the trimmer heater start command.

Function has been moved to heater module.
Target temperature has been added as part of the trimmer heater start command.

11:43 am

qnguyen  (deleted user)

These states rely on valves setting change on the transition of the previous state. Therefore, we need to start from the beginning state.

These states rely on valves setting change on the transition of the previous state. Therefore, we need to start from the beginning state.

10:41 am

Sean Nash

Maybe new reason like dialysate temperature not set?

Maybe new reason like dialysate temperature not set?

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

pmontazemi  (deleted user)

Why are there several cases with same outcome in this function?

Why are there several cases with same outcome in this function?

10:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 19 Jan 2021
5:08 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'Sprint33' into master

Options