common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 08 Feb 2021
12:02 pm

qnguyen  (deleted user)

Corrected.

Corrected.

11:42 am

qnguyen  (deleted user)

Done.

Done.

11:19 am

qnguyen  (deleted user)

Done.

Done.

11:06 am

qnguyen  (deleted user)

Done.

Done.

9:51 am

Sean Nash

If not yet in fill mode, will dgCmdResp persist to next time?

If not yet in fill mode, will dgCmdResp persist to next time?

9:50 am

Sean Nash

Is this response persistent? Or does this function consume the response? Even if persistent, I suspect a new response will replace previous response and this makes me nervous. I think it would be s...

Is this response persistent? Or does this function consume the response? Even if persistent, I suspect a new response will replace previous response and this makes me nervous. I think it would be safer to have a separate flag for each possible response so there is no race condition.

9:46 am

Sean Nash

This flag does not appear to be a "result". Rename to primeCompleted.

This flag does not appear to be a "result". Rename to primeCompleted.

9:43 am

Sean Nash

This is now included in the header file so we can remove here.

This is now included in the header file so we can remove here.

9:29 am

Sean Nash

This function is too big. Create static functions to handle these switch cases.

This function is too big. Create static functions to handle these switch cases.

9:26 am

Sean Nash

Rate is mL/min, not mL.

Rate is mL/min, not mL.

Friday 05 Feb 2021
9:24 am

Dara Navaei

Thursday 04 Feb 2021
8:59 am

qnguyen  (deleted user)

When we run blood pump in forward direction, we should see negative on arterial and positive on venous. This limit here is to stop blood pump even if the time to run the blood has not been reached.

When we run blood pump in forward direction, we should see negative on arterial and positive on venous.
This limit here is to stop blood pump even if the time to run the blood has not been reached.

Wednesday 03 Feb 2021
6:14 pm

qnguyen  (deleted user)

Done. Also moved the function to FPGA module.

Done. Also moved the function to FPGA module.

6:14 pm

qnguyen  (deleted user)

Done.

Done.

6:10 pm

qnguyen  (deleted user)

Done.

Done.

6:10 pm

qnguyen  (deleted user)

Reworded.

Reworded.

5:22 pm

qnguyen  (deleted user)

Renamed.

Renamed.

5:17 pm

qnguyen  (deleted user)

If the sensor is bad, we will go to fault. In this case, the calibration does not matter anymore.

If the sensor is bad, we will go to fault. In this case, the calibration does not matter anymore.

5:16 pm

qnguyen  (deleted user)

Agree. All multi-lines state have been moved to a static function.

Agree. All multi-lines state have been moved to a static function.

4:50 pm

qnguyen  (deleted user)

Done.

Done.

4:50 pm

qnguyen  (deleted user)

Done. It is a tolerance on pressure difference after we return back to normal state from pressure self-tests.

Done. It is a tolerance on pressure difference after we return back to normal state from pressure self-tests.

4:48 pm

qnguyen  (deleted user)

Done. This is not a self-test for blood pump occlusion sensor (OB). This is for PBa and PBo pressure sensors.

Done. This is not a self-test for blood pump occlusion sensor (OB). This is for PBa and PBo pressure sensors.

4:47 pm

qnguyen  (deleted user)

Done.

Done.

4:47 pm

qnguyen  (deleted user)

Done.

Done.

Tuesday 02 Feb 2021
10:37 am

Dara Navaei

DG-DEN-5980_Non Volatile Data Management (2 of 2)
DG-DEN-5980_Non Volatile Data Management (2 of 2)
Monday 01 Feb 2021
11:56 pm

Sean Nash

Fair point.

Fair point.

11:52 pm

Sean Nash

Consider returning a OPN_CLS_STATE_T instead of BOOL for readability.

Consider returning a OPN_CLS_STATE_T instead of BOOL for readability.

11:50 pm

Sean Nash

What is this state? Where did it get set? Why aren't we going back to recirc state?

What is this state? Where did it get set? Why aren't we going back to recirc state?

11:45 pm

Sean Nash

Can this wait for door close be a state within the self-test no cartridge sub-mode? Also need to wait for user to open the door at the end of self-test no cartridge sub-mode or beginning of cartrid...

Can this wait for door close be a state within the self-test no cartridge sub-mode? Also need to wait for user to open the door at the end of self-test no cartridge sub-mode or beginning of cartridge install sub-mode and then close the door again at end of cartridge install sub-mode. I see that some of these sub-modes don't have states, but probably should or will eventually. The 3 self-test sub-modes can have their own state machines in SelfTests.c. I think Recirc and Cartridge Install sub-modes may need their own .c files (PreTreatmentRecirc.c and DisposableInstall.c?) with state machines of their own as well.

11:40 pm

Sean Nash

Move execPrime() to end - only if no door open and no alarm stop signal.

Move execPrime() to end - only if no door open and no alarm stop signal.