Activity common/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	18
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 03 Jun 2021

10:29 am

Sean Nash

More
b506e30
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 197 more

Fixed merge conflicts.

- -484
- +499
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

10:27 am

qnguyen (deleted user)

More
Re: HD-DEN-8103-1
replied to Sean Nash

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface. Sample water sub-mode has to check before DG started.

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface.
Sample water sub-mode has to check before DG started.

9:56 am

Sean Nash

More
0071ba7
changed 2 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more HD-DEN-7605-2

DEN-7605: Added POST test for alarm audio.

- -0
- +2
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -3
- +4
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h

9:07 am

Sean Nash

More
Re: HD-DEN-8103-1
commented on review

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

9:03 am

Sean Nash

More
Re: HD-DEN-8103-1
commented on review

Is this different than alarmStatus.noNewTreatment?

Is this different than alarmStatus.noNewTreatment?

9:01 am

Sean Nash

More
Re: HD-DEN-8103-1
commented on review

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

Wednesday 02 Jun 2021

11:35 pm

Quang Nguyen <qnguyen@diality.com>

More
75964e8
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more HD-DEN-7605-2 HD-DEN-8103-1

DEN-8103: Updated alarms rank

- -68
- +70
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

11:16 am

Sean Nash

More
03fae27
changed 0 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more

Merge branch 'staging' of ssh://dvm-linux02:7999/comm/common into staging

11:16 am

Sean Nash

More
46088dc
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more HD-DEN-7605-2

DEN-7605: Moved FPGA POST test to last test executed.

- -1
- +1
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h

11:10 am

Sean Nash

More
8d8bf64
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 197 more

Moved FPGA POST to last test.

- -1
- +1
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h

Tuesday 01 Jun 2021

3:52 pm

Sean Nash

More
8bad77e
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 197 more

Rolled back prior merge - not ready.

- -507
- +494
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

2:37 pm

Sean Nash

More
26cdd89
changed 0 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 197 more

Merge branch 'staging' into develop

9:59 am

Dara Navaei

More
e23fe34
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more HD-DEN-7605-2

DEN-8030 remove RO pump ramp up persistent alarm since it is not used anymore

- -1
- +0
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

Monday 31 May 2021

4:31 pm

Dara Navaei

More
0ba9faa
changed 3 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more HD-DEN-7605-2

DEN-8030 added messages and enums to support UI disinfect screens

- -0
- +1
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -9
- +26
/DGDefs.h
- History
- Source
- Diff
/DGDefs.h
- -0
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

Sunday 30 May 2021

2:39 pm

Dara Navaei

More
6fa58ea
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more HD-DEN-7605-2

DEN-8030 added another state to chemical disinfect

- -0
- +1
/DGDefs.h
- History
- Source
- Diff
/DGDefs.h

Saturday 29 May 2021

2:03 am

Quang Nguyen <qnguyen@diality.com>

More
3533905
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more HD-DEN-7605-2 HD-DEN-8103-1

DEN-8103: Added filter flush time period override message

- -0
- +1
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

1:06 am

qnguyen (deleted user)

More
Re: HD-DEN-8103-1
replied to Sean Nash

Removed.

Removed.

Friday 28 May 2021

3:32 pm

Sean Nash

More
Re: HD-DEN-8103-1
commented on review

I think rather than 37, these should be the lowest high priority rank (i.e. 49) so we can add new alarms and not have to renumber these. Also, I think the range for high priority alarms should have...

I think rather than 37, these should be the lowest high priority rank (i.e. 49) so we can add new alarms and not have to renumber these. Also, I think the range for high priority alarms should have room for more than 50 alarms. Maybe high priority could be 1..499, medium priority 500..599, and low priority 600..699.

3:23 pm

Sean Nash

More
Re: HD-DEN-8103-1
commented on review

Dara, do we need these handlers or not?

Dara, do we need these handlers or not?

3:23 pm

Sean Nash

More
Re: HD-DEN-8103-1
commented on review

We should delete this dead code as well.

We should delete this dead code as well.

10:34 am

qnguyen (deleted user)

More
Re: HD-DEN-7605-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen (deleted user)

More
Re: HD-DEN-7605-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 27 May 2021

10:31 am

pmontazemi (deleted user)

More
Re: HD-DEN-7605-2
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:32 am

Quang Nguyen <qnguyen@diality.com>

More
c736e43
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more HD-DEN-7605-2 HD-DEN-8103-1

DEN-8103: Re-arranged alarms and added alarm id to alarm table

- -490
- +499
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

Wednesday 26 May 2021

4:59 pm

Sean Nash

More
6cbd966
changed 0 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 197 more

Merge branch 'staging' into develop

3:40 pm

Sean Nash

More
33e10fc
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more HD-DEN-7605-2

Fixed merge conflicts.

- -1
- +5
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

3:39 pm

Sean Nash

More
28bcd5f
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more DG-UCOMMITS-38

DEN-7605: Added alarm for DG reservoir not ready.

- -1
- +3
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

Tuesday 25 May 2021

2:00 pm

Sean Nash

More
cd07589
changed 1 file
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more HD-DEN-7605-2

DEN-7860: Changed rinseback bubble alarms from fault to alarm.

- -2
- +2
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

1:01 pm

Sean Nash

More
0bac185
changed 0 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 197 more

Merge branch 'staging' into develop

12:54 pm

Sean Nash

More
01cecd3
changed 0 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 203 more

Merge branch 'staging' of ssh://dvm-linux02:7999/comm/common into staging

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-06 22:21 -0700