common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 06 Jun 2021
4:07 pm

Dara Navaei

DEN-8030 updated the messages list

Options
    • -2
    • +0
    /MsgDefs.h
Friday 04 Jun 2021
12:49 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Changed DG alarms to not fault alarms

Options
    • -93
    • +73
    /AlarmDefs.h
10:31 am

qnguyen  (deleted user)

Should we call setAlarmAudio here? This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

Should we call setAlarmAudio here?
This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

10:19 am

qnguyen  (deleted user)

The flag is latched by using OR with the local updated noNewTreatment status.

The flag is latched by using OR with the local updated noNewTreatment status.

10:15 am

Sean Nash

But now in order to use the status flag, I think we can't allow that flag to go from TRUE to FALSE - need to latch it.

But now in order to use the status flag, I think we can't allow that flag to go from TRUE to FALSE - need to latch it.

Thursday 03 Jun 2021
10:55 am

qnguyen  (deleted user)

Removed this extra flag and used alarm status noNewTreatment flag.

Removed this extra flag and used alarm status noNewTreatment flag.

10:54 am

qnguyen  (deleted user)

Removed this extra flag.

Removed this extra flag.

10:51 am

qnguyen  (deleted user)

Done.

Done.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:29 am

Sean Nash

Fixed merge conflicts.

Options
    • -484
    • +499
    /AlarmDefs.h
10:27 am

qnguyen  (deleted user)

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface. Sample water sub-mode has to check before DG started.

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface.
Sample water sub-mode has to check before DG started.

9:56 am

Sean Nash

DEN-7605: Added POST test for alarm audio.

Options
    • -0
    • +2
    /AlarmDefs.h
    • -3
    • +4
    /HDDefs.h
9:07 am

Sean Nash

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

9:03 am

Sean Nash

Is this different than alarmStatus.noNewTreatment?

Is this different than alarmStatus.noNewTreatment?

9:01 am

Sean Nash

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

Wednesday 02 Jun 2021
11:35 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Updated alarms rank

Options
    • -68
    • +70
    /AlarmDefs.h
11:16 am

Sean Nash

Merge branch 'staging' of ssh://dvm-linux02:7999/comm/common into staging

Options
11:16 am

Sean Nash

DEN-7605: Moved FPGA POST test to last test executed.

Options
    • -1
    • +1
    /HDDefs.h
11:10 am

Sean Nash

Moved FPGA POST to last test.

Options
    • -1
    • +1
    /HDDefs.h
Tuesday 01 Jun 2021
3:52 pm

Sean Nash

Rolled back prior merge - not ready.

Options
    • -507
    • +494
    /AlarmDefs.h
2:37 pm

Sean Nash

Merge branch 'staging' into develop

Options
9:59 am

Dara Navaei

DEN-8030 remove RO pump ramp up persistent alarm since it is not used anymore

Options
    • -1
    • +0
    /AlarmDefs.h
Monday 31 May 2021
4:31 pm

Dara Navaei

DEN-8030 added messages and enums to support UI disinfect screens

Options
    • -0
    • +1
    /AlarmDefs.h
    • -9
    • +26
    /DGDefs.h
    • -0
    • +2
    /MsgDefs.h
Sunday 30 May 2021
2:39 pm

Dara Navaei

DEN-8030 added another state to chemical disinfect

Options
    • -0
    • +1
    /DGDefs.h
Saturday 29 May 2021
2:03 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Added filter flush time period override message

Options
    • -0
    • +1
    /MsgDefs.h
1:06 am

qnguyen  (deleted user)

Removed.

Removed.

Friday 28 May 2021
3:32 pm

Sean Nash

I think rather than 37, these should be the lowest high priority rank (i.e. 49) so we can add new alarms and not have to renumber these. Also, I think the range for high priority alarms should have...

I think rather than 37, these should be the lowest high priority rank (i.e. 49) so we can add new alarms and not have to renumber these. Also, I think the range for high priority alarms should have room for more than 50 alarms. Maybe high priority could be 1..499, medium priority 500..599, and low priority 600..699.

3:23 pm

Sean Nash

Dara, do we need these handlers or not?

Dara, do we need these handlers or not?

3:23 pm

Sean Nash

We should delete this dead code as well.

We should delete this dead code as well.