Activity common/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	18
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 08 Jun 2021

9:39 am

Dara Navaei

More
e00c1be
changed 0 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more

Merge branch 'staging' of ssh://dvm-linux02:7999/comm/common into staging

9:39 am

Dara Navaei

More
1e8d46a
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-7605-2

DEN-8030 added a message def for reading the disinfect states in HD

- -0
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

9:36 am

Dara Navaei

More
9b15808
changed 0 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more

Merge branch 'staging' of ssh://dvm-linux02:7999/comm/common into staging

9:35 am

Dara Navaei

More
a8c777f
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-7605-2

DEN-8030 updated the flush UI states

- -3
- +7
/DGDefs.h
- History
- Source
- Diff
/DGDefs.h

Monday 07 Jun 2021

8:31 pm

Quang Nguyen <qnguyen@diality.com>

More
1509e55
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-7605-2 HD-DEN-8103-1

DEN-8103: Added DG alarm fault to alarm state record

- -233
- +233
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

8:13 pm

Dara Navaei

More
be5272a
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-7605-2

Merge branch 'staging' of ssh://dvm-linux02:7999/comm/common into staging

- -0
- +6
/DGDefs.h
- History
- Source
- Diff
/DGDefs.h

8:13 pm

Dara Navaei

More
7d02c87
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more UI-UCOMMITS-26

DEN-8030 added flush mode UI states

- -3
- +13
/DGDefs.h
- History
- Source
- Diff
/DGDefs.h

1:29 pm

Sean Nash

More
80149ea
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 197 more

Merge branch 'staging' into develop

- -153
- +135
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

1:20 pm

Dara Navaei

More
8d66bad
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-7605-2

DEN-8030 merged the changes

- -0
- +6
/DGDefs.h
- History
- Source
- Diff
/DGDefs.h
- -0
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

10:35 am

Sean Nash

More
Re: HD-DEN-8103-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

More
Re: HD-DEN-8103-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

qnguyen (deleted user)

More
Re: HD-DEN-8103-1
replied to Sean Nash

Per Dara Navaei, we will need to implement this functions.

Per Dara Navaei, we will need to implement this functions.

10:34 am

Sean Nash

More
Re: HD-DEN-8103-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

More
Re: HD-DEN-8103-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen (deleted user)

More
Re: HD-DEN-7605-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:27 am

Sean Nash

More
Re: HD-DEN-7605-2
replied to qnguyen (deleted user)

Good point. Test will need to be longer than 50ms anyway - FPGA ramps the sound and there is a ~250ms time constant in the electronics. But I will want the sound to at least get started immediately.

Good point. Test will need to be longer than 50ms anyway - FPGA ramps the sound and there is a ~250ms time constant in the electronics. But I will want the sound to at least get started immediately.

Sunday 06 Jun 2021

4:07 pm

Dara Navaei

More
d4adbd1
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-7605-2

DEN-8030 updated the messages list

- -2
- +0
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

Friday 04 Jun 2021

12:49 pm

Quang Nguyen <qnguyen@diality.com>

More
9e697fb
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-7605-2 HD-DEN-8103-1

DEN-8103: Changed DG alarms to not fault alarms

- -93
- +73
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

10:31 am

qnguyen (deleted user)

More
Re: HD-DEN-7605-2
commented on review

Should we call setAlarmAudio here? This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

Should we call setAlarmAudio here?
This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

10:19 am

qnguyen (deleted user)

More
Re: HD-DEN-8103-1
replied to Sean Nash

The flag is latched by using OR with the local updated noNewTreatment status.

The flag is latched by using OR with the local updated noNewTreatment status.

10:15 am

Sean Nash

More
Re: HD-DEN-8103-1
replied to qnguyen (deleted user)

But now in order to use the status flag, I think we can't allow that flag to go from TRUE to FALSE - need to latch it.

But now in order to use the status flag, I think we can't allow that flag to go from TRUE to FALSE - need to latch it.

Thursday 03 Jun 2021

10:55 am

qnguyen (deleted user)

More
Re: HD-DEN-8103-1
replied to Sean Nash

Removed this extra flag and used alarm status noNewTreatment flag.

Removed this extra flag and used alarm status noNewTreatment flag.

10:54 am

qnguyen (deleted user)

More
Re: HD-DEN-8103-1
replied to Sean Nash

Removed this extra flag.

Removed this extra flag.

10:51 am

qnguyen (deleted user)

More
Re: HD-DEN-8103-1
replied to Sean Nash

Done.

Done.

10:33 am

Sean Nash

More
Re: HD-DEN-8103-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

More
Re: HD-DEN-8103-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:29 am

Sean Nash

More
b506e30
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 197 more

Fixed merge conflicts.

- -484
- +499
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

10:27 am

qnguyen (deleted user)

More
Re: HD-DEN-8103-1
replied to Sean Nash

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface. Sample water sub-mode has to check before DG started.

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface.
Sample water sub-mode has to check before DG started.

9:56 am

Sean Nash

More
0071ba7
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-7605-2

DEN-7605: Added POST test for alarm audio.

- -0
- +2
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -3
- +4
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h

9:07 am

Sean Nash

More
Re: HD-DEN-8103-1
commented on review

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-12 08:12 -0800