Activity common/

5:16 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

5:13 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

5:07 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

5:05 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

We should probably keep the = 0;

4:01 pm

Dara Navaei

More
Re: DG-DEN-11750-1
commented on review

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

3:57 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

Notices the 170 files that need to be reviewed https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

Notices the 170 files that need to be reviewed

https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

3:47 pm

Dara Navaei

More
DG-DEN-11750-1
started review

DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up

11:21 am

Sean Nash , hnguyen (deleted user) and Dara Navaei

More
HD-DEN-11980-1
finished reviewing

10:30 am

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

1:55 pm

Michael Garthwaite

More
Re: HD-DEN-11980-1
replied to Sean Nash

Please see comment below regarding the changes in common from this code review.

1:54 pm

Dara and I have found out that this code review for common is misconfigured. The source and destination branches are misconfigured. The branch to review should have been from DEN-11980_sw_dev_sprin...

Dara and I have found out that this code review for common is misconfigured. The source and destination branches are misconfigured. The branch to review should have been from DEN-11980_sw_dev_sprint_64 and the "branch from" should have been from staging. This code review has staging as the branch to review with master as the "branch review."

12:34 pm