Activity common/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	18
Last Commit:	19 Nov
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 30 Aug 2022

8:37 pm

Dara Navaei

More
db65d65
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 193 more

Merge branch 'staging' of ssh://dvm-linux02:7999/comm/common into staging

- -1
- +1
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

8:37 pm

Dara Navaei

More
a47f953
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 193 more UI-UCOMMITS-4

DEN-13460 added new alarms for the FPGA persistent alarms

- -8
- +16
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

2:33 pm

Sean Nash

More
a5a95b5
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 193 more

Merge branch 'staging' of ssh://dvm-linux02:7999/comm/common into staging

- -3
- +3
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

2:33 pm

Sean Nash

More
d880012
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 193 more UI-UCOMMITS-26

DEN-13460: updated alarm properties.

- -1
- +1
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

Monday 29 Aug 2022

7:22 pm

Sean Nash

More
ea9fac0
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 193 more DG-UCOMMITS-38

DEN-13460: Obsoleted alarm 220 (battery charge low).

- -3
- +3
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

Friday 26 Aug 2022

3:02 pm

Michael Garthwaite

More
HD-DEN-12609-2
Closed

2:59 pm

Dara Navaei and Sean Nash

More
HD-DEN-12609-2
finished reviewing

2:14 pm

Darren Cox

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:13 pm

Darren Cox

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:13 pm

Darren Cox

More
Re: HD-DEN-12609-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

More
Re: HD-DEN-12609-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

More
Re: HD-DEN-12609-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:06 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:19 am

Michael Garthwaite

More
Re: HD-DEN-12609-2
replied to Sean Nash

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarm...

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarmTriggered() to clear it only if has been raised previously.

Open to discussion in code walkthrough.

10:14 am

Michael Garthwaite

More
Re: HD-DEN-12609-2
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

10:13 am

Michael Garthwaite

More
Re: HD-DEN-12609-2
replied to Sean Nash

Understood. Fixed. Thanks!

Understood. Fixed. Thanks!

Thursday 25 Aug 2022

4:40 pm

Sean Nash

I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.

I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.

4:37 pm

Sean Nash

Still see lines of code like this one that require a space after if (i.e. "if(..." should be "if (...").

Still see lines of code like this one that require a space after if (i.e. "if(..." should be "if (...").

4:35 pm

Sean Nash

More
Re: HD-DEN-12609-2
commented on review

Remove all of these new blank lines.

Remove all of these new blank lines.

3:21 pm

Dara Navaei

More
86368d5
changed 0 files
develop

Merge branch 'staging' into develop

2:08 pm

Dara Navaei

More
0bdaaa9
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 193 more HD-DEN-12609-2

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -1
- +1
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h

11:25 am

Darren Cox <darren_m@cox.net>

More
b52b142
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 193 more HD-DEN-12609-2

DEN-13712 Update Alarm flags for disinfect.

- -4
- +4
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

11:03 am

Dara Navaei

More
540ee70
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 193 more HD-DEN-12609-2

DEN-13460 updated the fault states

- -6
- +6
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

Wednesday 24 Aug 2022

5:56 pm

Dara Navaei

More
e952d76
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 193 more HD-DEN-12609-2

DEN-13460 merged the remote changes

- -4
- +4
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -1
- +3
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h

4:58 pm

Dara Navaei

More
2e9d0f6
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 193 more HD-DEN-12609-2

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -2
- +2
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h

4:52 pm

Dara Navaei

More
DG-DEN-12974-1
Closed

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2025-12-24 15:23 -0800