common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 10 Jan 2023
3:24 pm

Dara Navaei

DEN-14497 updated the chemical disinfect alarms and defs

Options
    • -9
    • +9
    /AlarmDefs.h
    • -12
    • +13
    /DGDefs.h
1:02 pm

Dara Navaei

HD-DEN-14549_System Fault After Resuming Heparin Then Starting Saline Bolus During Treatment
HD-DEN-14549_System Fault After Resuming Heparin Then Starting Saline Bolus During Treatment
8:30 am

Sean Nash

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum). Could also create a redundant 0 enum like below and use the "first" enum to initial...

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum).
Could also create a redundant 0 enum like below and use the "first" enum to initialize a loop iterator safely:
enum list
{
FIRST_TEMP_SENSOR = 0,
TPI_SENSOR = FIRST_TEMP_SENSOR,
TPO_SENSOR,
TD1_SENSOR,
....
}
RESOLVED in CODE WALKTHROUGH.

8:24 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 09 Jan 2023
11:37 am

wbracken  (deleted user)

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typ...

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typedef THERMISTORS_TEMP_SENSORS_T. Changed load cells to use U08 to be consistent with temperature and pressure monitoring.

Should probably change temperature, pressure and load cells to use correct typedef.

Also, it looks like why the typedefs weren't used was in order to set the initial value of the iterator to 0 (i.e, the first sensor in the list). Seems like there should be a value that is the first item in the list, i.e. TEMPSENSORS_FIRST_SENSOR.

11:07 am

wbracken  (deleted user)

Removed.

Removed.

10:15 am

Sean Nash

Remove blank line.

Remove blank line.

Friday 06 Jan 2023
4:02 pm

Sean Nash

Why change this to U08?

Why change this to U08?

10:58 am

wbracken  (deleted user)

Add to header and alignment.

Add to header and alignment.

Thursday 05 Jan 2023
4:57 pm

Dara Navaei

Merge branch 'DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7' of ssh://dvm-linux02:7999/comm/common into DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7

Options
4:57 pm

Dara Navaei

DEN-14497 updated the order of the HD POST enums

Options
    • -2
    • +2
    /HDDefs.h
4:36 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /AlarmDefs.h
4:29 pm

jtaylor  (deleted user)

4:29 pm

jtaylor  (deleted user)

Branch removed. This "bugfix" branch was created in error.

Branch removed. This "bugfix" branch was created in error.

4:10 pm

Sean Nash

4:07 pm

Sean Nash

Fixed merge conflict.

Options
    • -1
    • +1
    /HDDefs.h
    • -2
    • +2
    /MsgDefs.h
4:01 pm

Dara Navaei and wbracken  (deleted user)

4:01 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:00 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:00 pm

Sean Nash

Function header updated. Assignment statements do not require alignment.

Function header updated. Assignment statements do not require alignment.

3:59 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

3:55 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

3:54 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

3:49 pm

wbracken  (deleted user)

Assignment alignment.

Assignment alignment.

3:47 pm

wbracken  (deleted user)

Assignment alignment in module.

Assignment alignment in module.

3:46 pm

wbracken  (deleted user)

Assignment statement alignment

Assignment statement alignment

3:45 pm

wbracken  (deleted user)

Assignment statements.

Assignment statements.

3:45 pm

Sean Nash

Alignment of what?

Alignment of what?

3:44 pm

Sean Nash

Not clear what you mean.

Not clear what you mean.

3:31 pm

Sean Nash

DEN-14086: Removed obsolete DPi flow vs. motor speed alarm.

Options
    • -4
    • +4
    /AlarmDefs.h