Activity common/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	18
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 31 Mar 2023

4:13 pm

Dara Navaei

More
b70df75
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more DG-DEN-14999-2

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/comm/common into DEN-14999-alarm-table-updates

- -1
- +1
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

4:13 pm

Dara Navaei

More
47c425f
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more UI-UCOMMITS-4

DEN-14999 updated the alarms table of properties

- -64
- +64
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

4:02 pm

Dara Navaei

More
3d089c4
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more DG-DEN-14999-2

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

4:00 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
cdce857
changed 0 files
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more

Merge branch 'DEN-14646-fpga-alarm-properties-and-timing-3' into staging

3:35 pm

wbracken (deleted user)

More
DG-DEN-14646-1
Closed

3:32 pm

jtaylor (deleted user) , dcox (deleted user) and Sean Nash

More
DG-DEN-14646-1
finished reviewing

3:18 pm

Michael Garthwaite

More
DG-DEN-14999-2
resumed reviewing

3:18 pm

Sean Nash

More
9601152
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more DG-DEN-14999-2

DEN-14999: fixed typo.

- -1
- +1
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

1:45 pm

dcox (deleted user)

More
Re: DG-DEN-14646-1
replied to wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:44 pm

jtaylor (deleted user)

More
Re: DG-DEN-14646-1
replied to wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:43 pm

jtaylor (deleted user)

More
Re: DG-DEN-14646-1
replied to wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:42 pm

wbracken (deleted user)

More
Re: DG-DEN-14646-1
replied to jtaylor (deleted user)

Corrected

Corrected

1:42 pm

wbracken (deleted user)

More
Re: DG-DEN-14646-1
replied to jtaylor (deleted user)

Corrected

Corrected

1:42 pm

wbracken (deleted user)

More
Re: DG-DEN-14646-1
replied to dcox (deleted user)

Corrected

Corrected

1:03 pm

dcox (deleted user)

More
Re: DG-DEN-14646-1
commented on review

Does TODO need to be resolved?

Does TODO need to be resolved?

1:01 pm

jtaylor (deleted user)

More
Re: DG-DEN-14646-1
commented on review

Extra space before the last paren.

Extra space before the last paren.

12:59 pm

jtaylor (deleted user)

More
Re: DG-DEN-14646-1
commented on review

Missing space.

Missing space.

11:27 am

Sean Nash

More
d8b7f32
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more DG-DEN-14999-2

DEN-14999: Updates to alarm properties.

- -173
- +173
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

9:14 am

Michael Garthwaite

More
Re: DG-DEN-14999-2
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:03 am

Sean Nash

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

8:54 am

Michael Garthwaite

More
Re: DG-DEN-14999-2
commented on review

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

Thursday 30 Mar 2023

9:01 pm

Dara Navaei

More
1c20d02
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more DG-DEN-14999-2

Merge branch 'DEN-14999-alarm-table-updates' of ssh://devapps.diality.us:7999/comm/common into DEN-14999-alarm-table-updates

- -12
- +12
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

9:01 pm

Dara Navaei

More
0f0751a
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more DG-UCOMMITS-38

DEN-14999 updated the alarms table

- -10
- +10
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

8:52 pm

Sean Nash

More
ed9e5cf
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more DG-DEN-14999-2

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/comm/common into DEN-14999-alarm-table-updates

- -4
- +4
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

8:52 pm

Sean Nash

More
d6e0430
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more UI-UCOMMITS-4

DEN-14999: removed alarms 273, 274.

- -8
- +8
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

8:19 pm

Dara Navaei

More
06acc4a
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more DG-DEN-14999-2

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/comm/common into DEN-14999-alarm-table-updates

- -16
- +16
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

8:19 pm

Dara Navaei

More
64bee74
changed 2 files
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more DG-DEN-14999-2

DEN-14999 updated the alarms table

- -4
- +4
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -2
- +2
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h

8:18 pm

Dara Navaei

More
9d5fc34
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 143 more DG-DEN-14999-2

DEN-14999 updated the alarms table

- -16
- +16
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

7:04 pm

Sean Nash

More
Re: DG-DEN-14646-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:02 pm

Dara Navaei

More
e40c19d
changed 1 file
develop

Merge branch 'DEN-14999-alarm-table-updates' into develop

- -21
- +21
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-27 13:09 -0700