common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 19 Apr 2023
12:14 pm

Behrouz NematiPour

Merge branch 'DEN-14947-UI-VD-S94-Misc' into staging

Options
    • -0
    • +4
    /AlarmDefs.h
12:10 pm

vduong  (deleted user)

12:09 pm

Behrouz NematiPour , Dara Navaei , Sean Nash , Michael Garthwaite , jishii  (deleted user) and Tiffany Mejia

11:32 am

Sean Nash

RESOLVED.

RESOLVED.

11:29 am

vduong  (deleted user)

I moved it to the end of the table

I moved it to the end of the table

11:28 am

Vy <vduong@sunriselabs.com>

DEN-14947 Correct Year check placement per CR feedback

Options
    • -1
    • +1
    /AlarmDefs.h
11:21 am

Sean Nash

I reviewed. One comment re: improper placement in table. RESOLVED.

I reviewed. One comment re: improper placement in table.
RESOLVED.

11:15 am

Sean Nash

Wrong place. This table should be in enum order so this should be added to end of table.

Wrong place. This table should be in enum order so this should be added to end of table.

10:58 am

Behrouz NematiPour

this CR needs Sean Nash, and/or Dara Navaei review for the AlarmDefs.h.

this CR needs Sean Nash, and/or Dara Navaei review for the AlarmDefs.h.

12:02 am

Dara Navaei

HD-DEN-14325_FW Blood Leak Alarm Triggers When Cartridge Lever IS Unlocked
HD-DEN-14325_FW Blood Leak Alarm Triggers When Cartridge Lever IS Unlocked
Tuesday 18 Apr 2023
2:29 pm

Dara Navaei

DEN-14325 updated the alarms title table

Options
    • -322
    • +322
    /AlarmDefs.h
12:26 pm

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:24 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:23 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:24 am

Dara Navaei

Merge branch 'DEN-15166-fw-add-drain-pump-maxon-board-rpm-check-cbit' into develop

Options
    • -2
    • +2
    /HDDefs.h
10:08 am

Dara Navaei

DEN-15182 added a new state in DG standby

Options
    • -0
    • +1
    /DGDefs.h
10:05 am

Dara Navaei

Please check the code again.

Please check the code again.

8:37 am

Dara Navaei

Done

Done

8:35 am

Dara Navaei

Done

Done

8:34 am

Dara Navaei

Done

Done

8:33 am

Dara Navaei

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

8:32 am

Dara Navaei

Done

Done

8:31 am

Sean Nash

request will remain if inlet alarms active. is that what we want?

request will remain if inlet alarms active. is that what we want?

8:31 am

Dara Navaei

Yes we do not support Beta in release.

Yes we do not support Beta in release.

8:28 am

Sean Nash

Looks like we will not read ADC channels at all if release build.

Looks like we will not read ADC channels at all if release build.

8:26 am

jtaylor  (deleted user)

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.