common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
Is this needed? Why would a worn cartridge fail pressure test?

Is this needed? Why would a worn cartridge fail pressure test?

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

UI Staging Unreviewed Commits
UI Staging Unreviewed Commits
Recommend being more direct in naming: TEST_CONFIG_USE_WET_CARTRIDGE TEST_CONFIG_USE_WORN_CARTRIDGE

Recommend being more direct in naming:
TEST_CONFIG_USE_WET_CARTRIDGE
TEST_CONFIG_USE_WORN_CARTRIDGE

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Remove extra blank line.

Remove extra blank line.

HD-DEN-15267_Request Create Dialin Command TO Enable Air Bubble Alarm IN Service Mode Air Bubble
HD-DEN-15267_Request Create Dialin Command TO Enable Air Bubble Alarm IN Service Mode Air Bubble
Please see changes.

Please see changes.

Done

Done

Is #if temporary?

Is #if temporary?

Are these #if temporary?

Are these #if temporary?

Looks like merge issues not resolved.

Looks like merge issues not resolved.

Is the merge correct?

Is the merge correct?

HD-DEN-14892_Add Bootloader TO Existing DG Firmware
HD-DEN-14892_Add Bootloader TO Existing DG Firmware
Let's discuss how test config is being used in this case. It seems like it's all over the place to me.

Let's discuss how test config is being used in this case. It seems like it's all over the place to me.

Remove extra blank line.

Remove extra blank line.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!