common

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I don't see these two functions in the .c file. Are they not yet implemented?

I don't see these two functions in the .c file. Are they not yet implemented?

Why 2 of these?

Why 2 of these?

What does this do? Why 64 (not 32)?

What does this do? Why 64 (not 32)?

DG-DEN-15274_HD DG Test Configuration Setup
DG-DEN-15274_HD DG Test Configuration Setup
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This was updated but not pushed.

This was updated but not pushed.

This was a mistake. I fixed it.

This was a mistake. I fixed it.

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
Is this needed? Why would a worn cartridge fail pressure test?

Is this needed? Why would a worn cartridge fail pressure test?

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

UI Staging Unreviewed Commits
UI Staging Unreviewed Commits
Recommend being more direct in naming: TEST_CONFIG_USE_WET_CARTRIDGE TEST_CONFIG_USE_WORN_CARTRIDGE

Recommend being more direct in naming:
TEST_CONFIG_USE_WET_CARTRIDGE
TEST_CONFIG_USE_WORN_CARTRIDGE

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.