common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 24 Aug 2023
1:48 pm

Sean Nash

1:31 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:33 pm

wbracken  (deleted user) and jtaylor  (deleted user)

10:43 am

jtaylor  (deleted user)

Wednesday 23 Aug 2023
2:14 pm

Sean Nash

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for ala...

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for alarm checks.
We do control to flow for treatment modes. Control to pressure is used in some cleaning modes. Not sure we want this alarm enforced in cleaning modes.

2:09 pm

Sean Nash

Remove blank line.

Remove blank line.

2:09 pm

Sean Nash

Put declarations at top of function. Use our BOOL type. Put ternary in ().

Put declarations at top of function. Use our BOOL type. Put ternary in ().

2:07 pm

Sean Nash

No point to having non-zero clear persistence - it's a fault.

No point to having non-zero clear persistence - it's a fault.

Tuesday 22 Aug 2023
5:36 pm

wbracken  (deleted user) and Sean Nash

2:29 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:17 pm

Vinayakam Mani

Updated.

Updated.

11:17 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:17 am

Sean Nash

Rename function to name of state (like others).

Rename function to name of state (like others).

11:05 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 21 Aug 2023
6:05 pm

Vinayakam Mani

Done.

Done.

6:04 pm

Vinayakam Mani

Done.

Done.

1:45 pm

Sean Nash

Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface tha...

Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface that we're using for other DG commands to make sure DG got and accepted the command (and sometimes retrying if not).

1:38 pm

Sean Nash

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".

11:27 am

Michael Garthwaite

11:24 am

wbracken  (deleted user) and Sean Nash

11:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:49 am

jtaylor  (deleted user)

Suggest aligning comments in the block above

Suggest aligning comments in the block above

Friday 18 Aug 2023
12:35 pm

Michael Garthwaite

Removed #define. Thanks!

Removed #define. Thanks!

12:04 pm

Dara Navaei

HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
11:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:13 am

Sean Nash

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

9:58 am

Sean Nash

I don't see where this #define is ever used. Remove if not needed.

I don't see where this #define is ever used. Remove if not needed.

Thursday 17 Aug 2023
6:05 pm

Dara Navaei

DG-DEN-15973_Alarm 48 UF Rate Tare Error Triggered During Treatment
DG-DEN-15973_Alarm 48 UF Rate Tare Error Triggered During Treatment
6:04 pm

Dara Navaei

DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
9:09 am

Sean Nash