common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Extra blank lines?

Extra blank lines?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

HD-STT-2824_Vtchd 504 Verify Alarm IS Set Point Not Set After 3 Trials
HD-STT-2824_Vtchd 504 Verify Alarm IS Set Point Not Set After 3 Trials
Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

Please remove the blank line.

Please remove the blank line.

UI-DEN-16288_UI BN S104 [ ready - common ]
UI-DEN-16288_UI BN S104 [ ready - common ]
HD-DEN-15792_HD Software Design Description
HD-DEN-15792_HD Software Design Description
DG-DIAL-281_Requesting Heat Disinfect Timer Overrides
DG-DIAL-281_Requesting Heat Disinfect Timer Overrides
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the chec...

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the check as it looks to be able to handle different modes, but again doesn't have access to the last set PWM value.

Corrected

Corrected

Corrected

Corrected

Corrected

Corrected

DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT
DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for ala...

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for alarm checks.
We do control to flow for treatment modes. Control to pressure is used in some cleaning modes. Not sure we want this alarm enforced in cleaning modes.