dd-firmware / firmware / App / Controllers

DryBiCart.c

Clone Tools

Stats

Commits this week: 18
Total Committers: 7
Last Commit: 01 Aug
Commits this week: 18

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Jul
12:08 pm

Vinayakam Mani

Add the header description.

Add the header description.

12:04 pm

Vinayakam Mani

Do we need to transition to next state DD_PREGEN_DRY_BICART_INITIAL_FILL here?

Do we need to transition to next state DD_PREGEN_DRY_BICART_INITIAL_FILL here?

11:57 am

Vinayakam Mani

Remove empty lines.

Remove empty lines.

11:49 am

Vinayakam Mani

Add comments across the file.

Add comments across the file.

11:42 am

Vinayakam Mani

Add comment.

Add comment.

11:41 am

Vinayakam Mani

Add a test support for Pregen fill request.

Add a test support for Pregen fill request.

11:27 am

Vinayakam Mani

Update header description for all newly added functions.

Update header description for all newly added functions.

11:04 am

Vinayakam Mani

You may need to check other flags such as DryBicartFillRequested( Initial Fill), bicarbChamberFillRequested (Filling Chamber F), instead of 'bicarbChamberPregenFillRequested'. Keep Drain and Depres...

You may need to check other flags such as DryBicartFillRequested( Initial Fill), bicarbChamberFillRequested (Filling Chamber F), instead of 'bicarbChamberPregenFillRequested'. Keep Drain and DepressurizeRequest flag as is. This makes sure at any given point, dryBicartExec calls one of the service only.

11:02 am

Vinayakam Mani

Same here adding 'bicarbChamberPregenFillRequested' flag.

Same here adding 'bicarbChamberPregenFillRequested' flag.

11:02 am

Vinayakam Mani

Same here adding 'bicarbChamberPregenFillRequested' flag.

Same here adding 'bicarbChamberPregenFillRequested' flag.

11:01 am

Vinayakam Mani

Same here adding 'bicarbChamberPregenFillRequested' flag.

Same here adding 'bicarbChamberPregenFillRequested' flag.

10:59 am

Vinayakam Mani

Retain the previous( dryBicartFillRequested) and add 'bicarbChamberPregenFillRequested' flag here.

Retain the previous( dryBicartFillRequested) and add 'bicarbChamberPregenFillRequested' flag here.

10:53 am

Vinayakam Mani

PregenFillExecState? may be creating a new fault ID for pregen fill.

PregenFillExecState? may be creating a new fault ID for pregen fill.

10:51 am

Vinayakam Mani

Update description as required.

Update description as required.

10:51 am

Vinayakam Mani

Add comment.

Add comment.

10:50 am

Vinayakam Mani

Add comment.

Add comment.

10:50 am

Vinayakam Mani

Add comment.

Add comment.

Wednesday 29 Jul
5:37 pm

Vendor - TEL - Jashwant Gantyada

4:32 pm

Vinayakam Mani and Vendor - TEL - Sameer Poyil

4:20 pm

Vendor - TEL - Jashwant Gantyada

added a common function

added a common function

4:20 pm

Vendor - TEL - Jashwant Gantyada

did as suggested

did as suggested

4:20 pm

Vendor - TEL - Jashwant Gantyada

added comment

added comment

4:19 pm

Vendor - TEL - Jashwant Gantyada

added a function similar to this

added a function similar to this

3:56 pm

Vendor - TEL - Sameer Poyil

Also need a function for Spent side only open for drain

Also need a function for Spent side only open for drain

3:55 pm

Vendor - TEL - Sameer Poyil

could you please arrange Fresh side and Spend side valve together ?

could you please arrange Fresh side and Spend side valve together ?

2:41 pm

Vendor - TEL - Sameer Poyil

please document this too

please document this too

2:39 pm

Vendor - TEL - Sameer Poyil

this variable is removed now ,

this variable is removed now ,

2:37 pm

Vinayakam Mani

Could you please move 10.0F aligned to the rest of the declaration. I see Drybicart persistence duration (500ms) is as well not aligned.

Could you please move 10.0F aligned to the rest of the declaration. I see Drybicart persistence duration (500ms) is as well not aligned.

2:34 pm

Vendor - TEL - Sameer Poyil

yes . but need to change from fill water state to IDLE state , and Vent state to IDLE state, implement common in a function and call from both state

yes . but need to change from fill water state to IDLE state , and Vent state to IDLE state, implement common in a function and call from both state

2:28 pm

Vendor - TEL - Jashwant Gantyada

added

added