dd-firmware / firmware / App / Controllers

PistonPumpControl.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 07:27
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Sep
3:07 pm

ven.smathamala  (deleted user)

2:56 pm

Sean Nash and Vinayakam Mani

Friday 29 Aug
11:05 am

Sean Nash

Fixed.

Fixed.

10:51 am

ven.smathamala  (deleted user)

Fixed .

Fixed .

10:37 am

Vinayakam Mani

I guess, you should still need 'TestingActivated' check, due to a reason when system team wants to change the states as part of their testing.

I guess, you should still need 'TestingActivated' check, due to a reason when system team wants to change the states as part of their testing.

10:35 am

Vinayakam Mani

timePerStep is not initialized with the values and being used here.

timePerStep is not initialized with the values and being used here.

Monday 25 Aug
11:53 am

ven.smathamala  (deleted user)

Swapped.

Swapped.

11:51 am

ven.smathamala  (deleted user)

Fixed.

Fixed.

11:49 am

ven.smathamala  (deleted user)

Fixed.

Fixed.

Friday 22 Aug
4:04 pm

Vinayakam Mani

It should be equal to true? ( getTestConfigStatus( TEST_CONFIG_DISABLE_BC_PRESSURE_ALARMS ) == TRUE )

It should be equal to true?

( getTestConfigStatus( TEST_CONFIG_DISABLE_BC_PRESSURE_ALARMS ) == TRUE )

3:41 pm

Vinayakam Mani

Add open and close parenthesis.

Add open and close parenthesis.

1:30 pm

Sean Nash

Beta and Alpha are swapped here. Beta should be -14.... and Alpha should be 0.0.

Beta and Alpha are swapped here. Beta should be -14.... and Alpha should be 0.0.

11:59 am

Shyam Kumar Mathamala <ven.smathamala@diality.com>

LDT-1735: Implemented Dialin Test Config for BETA_HW, Balancing Chanmber Pressure Alarms. Removed Test Pumps Build Switch

Options
    • -75
    • +0
    ./PistonPumpControl.h
  2. … 11 more files in changeset.
Wednesday 20 Aug
10:02 am

Dara Navaei

DD-LDT-1735_Test Config Support For DD
DD-LDT-1735_Test Config Support For DD
Tuesday 05 Aug
1:42 pm

Vinayakam Mani

12:46 pm

Michael Garthwaite , Sean Nash and Dara Navaei

Monday 04 Aug
12:58 pm

Vinayakam Mani

DD-LDT-1473_Ultrafiltration DD
DD-LDT-1473_Ultrafiltration DD
10:07 am

Michael Garthwaite

Thanks. Resolved

Thanks. Resolved

9:47 am

Vinayakam Mani

it is moved to DDDef.h, UI team is looking for this mapping for their (diagnostics page) development.

it is moved to DDDef.h, UI team is looking for this mapping for their (diagnostics page) development.

9:34 am

Michael Garthwaite

Where did this valve enum go?

Where did this valve enum go?

Friday 01 Aug
4:42 pm

Vinayakam Mani

Done.

Done.

4:39 pm

Vinayakam Mani

I have introduced two additional build flags in 'DDCommon.h' (ENABLE_ALARM_1 and ENABLE_ALARM_2) to currently stop triggering alarms due to hardware support etc., so. it should be safe for now. if ...

I have introduced two additional build flags in 'DDCommon.h' (ENABLE_ALARM_1 and ENABLE_ALARM_2) to currently stop triggering alarms due to hardware support etc., so. it should be safe for now. if still any specific alarms triggers, will try to disable those alarms.

4:06 pm

Sean Nash

2 blank lines above and below test support banners.

2 blank lines above and below test support banners.

4:05 pm

Sean Nash

Is this safe to enable now?

Is this safe to enable now?

Tuesday 29 Jul
10:23 pm

Sean Nash

Consider doing this in update compensated rate function (only once every 2 minutes when rate actually changes).

Consider doing this in update compensated rate function (only once every 2 minutes when rate actually changes).

Monday 28 Jul
2:15 pm

Vinayakam Mani

Done.

Done.

2:14 pm

Vinayakam Mani

LDT-1473 code review update

Options
    • -1
    • +0
    ./PistonPumpControl.h
2:08 pm

Vinayakam Mani

Done.

Done.

2:03 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:00 pm

Vinayakam Mani

Done

Done