dd-firmware / firmware / App / Modes

ModePostGenDialysate.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 2
Last Commit: 07:27
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 05 Dec
1:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModePostGenDialysate.c
  2. … 121 more files in changeset.
Tuesday 22 Apr
2:42 pm

Vinayakam Mani

2:32 pm

Sean Nash and Michael Garthwaite

2:07 pm

Vinayakam Mani

Done.

Done.

2:07 pm

Vinayakam Mani

Done.

Done.

2:07 pm

Vinayakam Mani

Done.

Done.

2:06 pm

Vinayakam Mani

Done.

Done.

1:18 pm

Vinayakam Mani

Done

Done

1:16 pm

Sean Nash

Same as Gen Dialysate - this should be else if and switch statement should be in a final else.

Same as Gen Dialysate - this should be else if and switch statement should be in a final else.

1:14 pm

Sean Nash

stop should be capitalized.

stop should be capitalized.

1:14 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

I think these two conditions above the switch statement should end the state processing. So the second condition should be an else if and combined i.e. if ( ( genDialysateState != DD_GEND_DIALYSATE...

I think these two conditions above the switch statement should end the state processing.
So the second condition should be an else if and combined i.e. if ( ( genDialysateState != DD_GEND_DIALYSATE_DELIVERY_PAUSE ) && ( TRUE == areInletWaterConditionsAlarmsActive() ) ).
And then another else where the switch statement should go.
Hydraulic chamber and updating treatment settings should maybe be moved above all of this so they always happen.

11:43 am

Vinayakam Mani

Done.

Done.

10:34 am

Sean Nash

Want Gen Dialysate mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

Want Gen Dialysate mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

10:33 am

Sean Nash

Want Pre Gen mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

Want Pre Gen mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

10:26 am

Vinayakam Mani

LDT-319 code review comments incorporation

Options
    • -3
    • +3
    ./ModePostGenDialysate.c
  2. … 5 more files in changeset.
8:57 am

Sean Nash

Signal Pre Gen mode and let it request standby mode.

Signal Pre Gen mode and let it request standby mode.

8:56 am

Sean Nash

Should signal Gen Dialysate mode and let it request transition to standby.

Should signal Gen Dialysate mode and let it request transition to standby.

Monday 21 Apr
5:52 pm

Vinayakam Mani

Done. Somehow its aligned in CCS editor.

Done. Somehow its aligned in CCS editor.

5:51 pm

Vinayakam Mani

Done. somehow I see its all aligned in CCS editor.

Done. somehow I see its all aligned in CCS editor.

5:49 pm

Vinayakam Mani

LDT-319 code update

Options
    • -3
    • +7
    ./ModePostGenDialysate.c
  2. … 10 more files in changeset.
5:35 pm

Vinayakam Mani

Done.

Done.

5:35 pm

Vinayakam Mani

Done.

Done.

5:34 pm

Vinayakam Mani

Done.

Done.

5:34 pm

Vinayakam Mani

Done.

Done.

5:34 pm

Vinayakam Mani

Done.

Done.

5:34 pm

Vinayakam Mani

Done.

Done.

10:20 am

Sean Nash

Add a message sent detail.

Add a message sent detail.

10:19 am

Sean Nash

postGenDialysateState is an input.

postGenDialysateState is an input.

10:19 am

Sean Nash

Align comment.

Align comment.