PressureSensor.h

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

As discussed, will be evaluated once we get more details on the sensor configuration/controls.

As discussed, will be evaluated once we get more details on the sensor configuration/controls.

Done.

Done.

Yes, Currently HDD listing this pressure sensor. Once HDD cleanup is done, we may remove/comment the source as required.

Yes, Currently HDD listing this pressure sensor. Once HDD cleanup is done, we may remove/comment the source as required.

This is just added for the sake of code review creation, the actual changes were already merged in to staging.

This is just added for the sake of code review creation, the actual changes were already merged in to staging.

Who will be calling this function? Is there any chance this function can be called more than once in a single task iteration? Is it possible to request a write at one address and then immediately r...

Who will be calling this function? Is there any chance this function can be called more than once in a single task iteration? Is it possible to request a write at one address and then immediately request another write at another address? If so, I think the second write request will overwrite the first - you would need to add a write request queue that the write state machine could handle one job at a time.

Should each conductivity sensor have its own state? It doesn't look like the state can be shared by all sensors.

Should each conductivity sensor have its own state? It doesn't look like the state can be shared by all sensors.

Dara's build script should be updating these for us.

Dara's build script should be updating these for us.

Where are the messages for conductivity and pressure overrides? Are you looking for Michael to add those?

Where are the messages for conductivity and pressure overrides? Are you looking for Michael to add those?

Isn't bicarb bag de-scoped?

Isn't bicarb bag de-scoped?

Replace TD with DD.

Replace TD with DD.

Remove "ed" from "filtered".

Remove "ed" from "filtered".

Is there only 1 pressure sensor? Initialization looks wrong. Should the whole structure get initialized - maybe in init function?

Is there only 1 pressure sensor? Initialization looks wrong. Should the whole structure get initialized - maybe in init function?

Add a blank line between declarations and code.

Add a blank line between declarations and code.