dd-firmware / firmware / App / Services

AlarmMgmtDD.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 6
Last Commit: 01 Aug
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Jul
7:14 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

updated now

updated now

12:08 pm

Vinayakam Mani

Add the header description.

Add the header description.

12:04 pm

Vinayakam Mani

Do we need to transition to next state DD_PREGEN_DRY_BICART_INITIAL_FILL here?

Do we need to transition to next state DD_PREGEN_DRY_BICART_INITIAL_FILL here?

11:57 am

Vinayakam Mani

Remove empty lines.

Remove empty lines.

11:49 am

Vinayakam Mani

Add comments across the file.

Add comments across the file.

11:42 am

Vinayakam Mani

Add comment.

Add comment.

11:41 am

Vinayakam Mani

Add a test support for Pregen fill request.

Add a test support for Pregen fill request.

11:27 am

Vinayakam Mani

Update header description for all newly added functions.

Update header description for all newly added functions.

11:04 am

Vinayakam Mani

You may need to check other flags such as DryBicartFillRequested( Initial Fill), bicarbChamberFillRequested (Filling Chamber F), instead of 'bicarbChamberPregenFillRequested'. Keep Drain and Depres...

You may need to check other flags such as DryBicartFillRequested( Initial Fill), bicarbChamberFillRequested (Filling Chamber F), instead of 'bicarbChamberPregenFillRequested'. Keep Drain and DepressurizeRequest flag as is. This makes sure at any given point, dryBicartExec calls one of the service only.

11:02 am

Vinayakam Mani

Same here adding 'bicarbChamberPregenFillRequested' flag.

Same here adding 'bicarbChamberPregenFillRequested' flag.

11:02 am

Vinayakam Mani

Same here adding 'bicarbChamberPregenFillRequested' flag.

Same here adding 'bicarbChamberPregenFillRequested' flag.

11:01 am

Vinayakam Mani

Same here adding 'bicarbChamberPregenFillRequested' flag.

Same here adding 'bicarbChamberPregenFillRequested' flag.

10:59 am

Vinayakam Mani

Retain the previous( dryBicartFillRequested) and add 'bicarbChamberPregenFillRequested' flag here.

Retain the previous( dryBicartFillRequested) and add 'bicarbChamberPregenFillRequested' flag here.

10:53 am

Vinayakam Mani

PregenFillExecState? may be creating a new fault ID for pregen fill.

PregenFillExecState? may be creating a new fault ID for pregen fill.

10:51 am

Vinayakam Mani

Update description as required.

Update description as required.

10:51 am

Vinayakam Mani

Add comment.

Add comment.

10:50 am

Vinayakam Mani

Add comment.

Add comment.

10:50 am

Vinayakam Mani

Add comment.

Add comment.

Wednesday 29 Jul
2:34 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:34 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:34 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:33 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:33 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:33 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

4:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
Monday 27 Jul
10:06 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

We are checking level status 3 times in same function. So Vinay suggested to use local variable to avoid the inconsistent states across the function.

We are checking level status 3 times in same function. So Vinay suggested to use local variable to avoid the inconsistent states across the function.

3:58 pm

Sean Nash

keep a blank line between declaration(s) and code.

keep a blank line between declaration(s) and code.

3:57 pm

Sean Nash

If level can be overridden, you should use get function.

If level can be overridden, you should use get function.

3:55 pm

Sean Nash

Add blank line before banner.

Add blank line before banner.

Friday 24 Jul
10:11 am

Vinayakam Mani

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?