ROInterface.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done.

Done.

Done.

Done.

Remove extra blank line.

Remove extra blank line.

isPressureDroppedDuringFill not initialized in init function.

isPressureDroppedDuringFill not initialized in init function.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Currently testing is ongoing. Will try to remove it end of this sprint.

Currently testing is ongoing. Will try to remove it end of this sprint.

Done.

Done.

Done.

Done.

Align comment.

Align comment.

Should we range check pumpId and trigger s/w fault if out of range?

Should we range check pumpId and trigger s/w fault if out of range?

I think these can just be done once after else.

I think these can just be done once after else.

Are we done with temporary code? Can we just remove it?

Are we done with temporary code? Can we just remove it?

Change name (RO to FP)?

Change name (RO to FP)?

Change function name (RO to FP)?

Change function name (RO to FP)?

Update comment too.

Update comment too.

If you get a chance, try to find out which message (ID) is having the CRC error and where it's coming from (which channel) and why it's failing CRC check (e.g. was a frame missing?)

If you get a chance, try to find out which message (ID) is having the CRC error and where it's coming from (which channel) and why it's failing CRC check (e.g. was a frame missing?)

Done.

Done.

Done.

Done.

I remember seeing once some CRC error. To continue development, disabled fault mode for a while.

I remember seeing once some CRC error. To continue development, disabled fault mode for a while.

Reverted.

Reverted.

Reverted.

Reverted.

these changes made for testing purposes. reverted to original.

these changes made for testing purposes. reverted to original.

Done.

Done.

Done.

Done.

Done.

Done.