dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 03 Aug 2021
2:41 pm

Dara Navaei

DEN-9054 added a default to a variable in switches.c

Options
    • -8
    • +7
    /firmware/App/Controllers/Switches.c
9:50 am

Dara Navaei

DEN-9054 removed the message argument in the system and service record handlers

Options
    • -2
    • +2
    /firmware/App/Services/SystemComm.c
    • -4
    • +2
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.h
9:48 am

Dara Navaei

Fixed the maxBufferLength variable.

Fixed the maxBufferLength variable.

9:43 am

Dara Navaei

Done.

Done.

9:42 am

Dara Navaei

Done.

Done.

9:34 am

qnguyen  (deleted user)

Unused parameter.

Unused parameter.

9:33 am

qnguyen  (deleted user)

Looks like the parameter is not being used.

Looks like the parameter is not being used.

9:28 am

qnguyen  (deleted user)

maxBufferLength variable is not needed in this case and the comment is not matched the code. Suggest revert this change to line 2139.

maxBufferLength variable is not needed in this case and the comment is not matched the code.
Suggest revert this change to line 2139.

Monday 02 Aug 2021
10:34 am

Dara Navaei

Bamboo Commit: Updated dg_build_history.log with build number and build date

Options
    • -2
    • +2
    /firmware/dg_build_history.log
10:34 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:25 am

Dara Navaei

DEN-9054 Implemented the debounce code in the switches

Options
    • -2
    • +3
    /firmware/App/Controllers/Switches.c
    • -34
    • +23
    /firmware/App/Controllers/Thermistors.c
Saturday 31 Jul 2021
4:44 pm

Dara Navaei

DEN-9054 merged stagin

Options
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Controllers/Fans.c
    • -2
    • +2
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/Pressures.c
    • -8
    • +2
    /firmware/App/Controllers/ROPump.c
    • -3
    • +3
    /firmware/App/Controllers/UVReactors.c
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -2
    • +2
    /firmware/App/Modes/ModeFlush.c
    • -3
    • +3
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -3
    • +3
    /firmware/App/Modes/ModeInitPOST.c
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.c
    • -96
    • +3
    /firmware/App/Services/AlarmMgmt.h
    • -0
    • +135
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -1
    • +13
    /firmware/App/Services/FPGA.c
    • -0
    • +2
    /firmware/App/Services/FPGA.h
  16. … 6 more files in changeset.
3:50 pm

Dara Navaei

DEN-9054 implemented debouncing for the DG switches and implemented FPGA GPIO power

Options
    • -22
    • +67
    /firmware/App/Controllers/Switches.c
    • -1
    • +2
    /firmware/App/Controllers/Switches.h
    • -3
    • +23
    /firmware/App/Services/FPGA.c
    • -2
    • +2
    /firmware/DG.dil
    • -1
    • +1
    /firmware/include/gio.h
    • -1
    • +1
    /firmware/source/gio.c
9:03 am

Dara Navaei

The signal is debounced for 50ms. I added a debounce for a longer time.

The signal is debounced for 50ms. I added a debounce for a longer time.

Friday 30 Jul 2021
9:35 pm

Dara Navaei

The calibration structures are populated during POST. The initialization will be addressed in DEN-9480.

The calibration structures are populated during POST. The initialization will be addressed in DEN-9480.

5:56 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-8886-hd_dg_dev-self-tests-2-of-2' into develop

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -10
    • +10
    /firmware/App/Services/WatchdogMgmt.c
5:55 pm

Sean Nash

DEN-8886: Disable WD POST recovery check until issue can be resolved with EE team.

Options
    • -7
    • +7
    /firmware/App/Services/WatchdogMgmt.c
5:48 pm

Sean Nash

DEN-8886: Increased WD POST recovery time to allow 24V more time to come back up.

Options
    • -1
    • +1
    /firmware/App/Services/WatchdogMgmt.c
4:48 pm

Sean Nash

DEN-8886: Fix watchdog test to verify the correct 24V channel.

Options
    • -2
    • +2
    /firmware/App/Services/WatchdogMgmt.c
3:20 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-9054-dg-hd_dev-dg-hd-switches' into develop

Options
    • -0
    • +7
    /firmware/.launches/DG.launch
    • -6
    • +109
    /firmware/App/Controllers/ConductivitySensors.c
    • -104
    • +27
    /firmware/App/Controllers/Fans.c
    • -91
    • +197
    /firmware/App/Controllers/Heaters.c
    • -39
    • +128
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Controllers/UVReactors.c
    • -4
    • +3
    /firmware/App/DGCommon.h
    • -16
    • +41
    /firmware/App/Modes/ModeFlush.c
    • -26
    • +45
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -19
    • +35
    /firmware/App/Modes/ModeInitPOST.c
    • -38
    • +42
    /firmware/App/Modes/ModeRecirculate.c
    • -6
    • +5
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -0
    • +50
    /firmware/App/Services/FPGA.c
    • -1
    • +5
    /firmware/App/Services/FPGA.h
    • -0
    • +13
    /firmware/App/Services/SystemComm.c
  16. … 4 more files in changeset.
2:10 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-8886-hd_dg_dev-self-tests-2-of-2' into develop

Options
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -1
    • +0
    /firmware/App/DGCommon.h
    • -2
    • +4
    /firmware/App/Modes/ModeRecirculate.c
    • -64
    • +4
    /firmware/App/Services/Interrupts.c
    • -21
    • +4
    /firmware/App/Services/SystemComm.c
    • -0
    • +34
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
    • -10
    • +39
    /firmware/App/Services/WatchdogMgmt.c
2:07 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Changed according to lab test

Options
    • -13
    • +18
    /firmware/App/Modes/ModeFill.c
    • -1
    • +1
    /firmware/App/Services/Reservoirs.c
1:48 pm

Dara Navaei

Done.

Done.

10:55 am

Sean Nash

Need function header.

Need function header.

10:54 am

Sean Nash

Should we debounce switches before changing states? Check with Noe to see if FPGA is already debouncing these signals.

Should we debounce switches before changing states? Check with Noe to see if FPGA is already debouncing these signals.

10:38 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.