dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Aug 2021
11:04 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Addressed code reviews

Options
    • -0
    • +1
    /firmware/App/Modes/ModeDrain.c
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -10
    • +1
    /firmware/App/Services/Interrupts.c
    • -4
    • +4
    /firmware/App/Services/Reservoirs.c
10:58 pm

qnguyen  (deleted user)

To check for HD communication.

To check for HD communication.

4:47 pm

qnguyen  (deleted user)

Removed. This windowed count is removed in branch DEN-8886. There is no definition for it anymore.

Removed. This windowed count is removed in branch DEN-8886. There is no definition for it anymore.

4:47 pm

qnguyen  (deleted user)

Removed. This alarm is removed in branch DEN-8886.

Removed. This alarm is removed in branch DEN-8886.

4:45 pm

qnguyen  (deleted user)

The mode fill is calling this function to get the base weight before a fill (for load cell vs integrated flow check). The large filter takes too long and mode fill sometimes get higher value if dra...

The mode fill is calling this function to get the base weight before a fill (for load cell vs integrated flow check).
The large filter takes too long and mode fill sometimes get higher value if drain and fill happens too fast.

4:42 pm

qnguyen  (deleted user)

Done. Should we remove this build flag all together since no V2 system available anymore?

Done. Should we remove this build flag all together since no V2 system available anymore?

4:40 pm

qnguyen  (deleted user)

AlarmMgmt checks for HD communication (in SystemComm) before broadcast trigger message (prevent NACK issue).

AlarmMgmt checks for HD communication (in SystemComm) before broadcast trigger message (prevent NACK issue).

4:38 pm

qnguyen  (deleted user)

HD normally looks at this state to command fill or drain. We would want to wait until the flush lines to be done before drain or fill.

HD normally looks at this state to command fill or drain. We would want to wait until the flush lines to be done before drain or fill.

12:57 pm

Sean Nash

Change large to small in brief. Why is this changing? Who calls this function?

Change large to small in brief.
Why is this changing? Who calls this function?

12:53 pm

Sean Nash

Change to #ifdef?

Change to #ifdef?

12:50 pm

Sean Nash

Is there a problem with this alarm? Add TODO?

Is there a problem with this alarm? Add TODO?

12:50 pm

Sean Nash

Why commented out?

Why commented out?

12:49 pm

Sean Nash

Why needed?

Why needed?

12:48 pm

Sean Nash

Change /* CIRC to /* GENE

Change /* CIRC to /* GENE

12:48 pm

Sean Nash

Do we need this state? What's difference between the 2 states now that VDr is never recirculating?

Do we need this state? What's difference between the 2 states now that VDr is never recirculating?

11:44 am

Sean Nash

Why needed?

Why needed?

11:43 am

Sean Nash

Is ADC range check necessary?

Is ADC range check necessary?

11:41 am

Sean Nash

Is there a problem with this alarm? Need a TODO?

Is there a problem with this alarm? Need a TODO?

Tuesday 10 Aug 2021
2:19 pm

Sean Nash

DEN-8886: Made DG op mode data broadcast interval overrideable.

Options
    • -1
    • +77
    /firmware/App/Modes/OperationModes.c
    • -0
    • +3
    /firmware/App/Modes/OperationModes.h
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -0
    • +32
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
Saturday 07 Aug 2021
2:28 pm

Dara Navaei

DEN-9480, DEN-8886 added range check to the load cells

Options
    • -16
    • +84
    /firmware/App/Controllers/Fans.c
    • -0
    • +3
    /firmware/App/Controllers/Fans.h
    • -20
    • +46
    /firmware/App/Controllers/LoadCell.c
    • -10
    • +10
    /firmware/App/Controllers/Thermistors.c
    • -1
    • +5
    /firmware/App/Services/SystemComm.c
    • -0
    • +32
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
    • -1
    • +1
    /firmware/App/Services/WatchdogMgmt.c
Friday 06 Aug 2021
2:12 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Refactor re-circ mode to generation idle mode

Options
    • -4
    • +4
    /firmware/App/Modes/ModeDrain.c
    • -8
    • +8
    /firmware/App/Modes/ModeFill.c
    • -0
    • +226
    /firmware/App/Modes/ModeGenIdle.c
    • -0
    • +46
    /firmware/App/Modes/ModeGenIdle.h
    • -256
    • +0
    /firmware/App/Modes/ModeRecirculate.c
    • -46
    • +0
    /firmware/App/Modes/ModeRecirculate.h
    • -3
    • +3
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.h
    • -11
    • +11
    /firmware/App/Modes/OperationModes.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -15
    • +15
    /firmware/App/Services/Reservoirs.c
    • -3
    • +3
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/WatchdogMgmt.c
1:10 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
1:10 pm

Dara Navaei

Bamboo Commit: Updated dg_build_history.log with build number and build date

Options
    • -2
    • +2
    /firmware/dg_build_history.log
1:10 pm

Dara Navaei

Merge branch 'develop' of ssh://dvm-linux02:7999/dg/dgfirmware into develop

Options
1:10 pm

Dara Navaei

DEN-8819 revolved load cells accuracy issues and Added the safety shutdown temporarily.

Options
    • -0
    • +5
    /firmware/App/Modes/ModeInitPOST.c
11:32 am

Dara Navaei

DEN-8886 worked on the self tests and fans

Options
    • -68
    • +95
    /firmware/App/Controllers/Fans.c
    • -3
    • +3
    /firmware/App/Controllers/Switches.c
    • -38
    • +35
    /firmware/App/Controllers/TemperatureSensors.c
    • -37
    • +26
    /firmware/App/Controllers/Thermistors.c
    • -3
    • +8
    /firmware/App/Modes/ModeInitPOST.c
    • -2
    • +2
    /firmware/App/Services/FPGA.c
10:23 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Send water to drain during re-circ state

Options
    • -9
    • +9
    /firmware/App/Modes/ModeRecirculate.c
    • -4
    • +0
    /firmware/App/Services/Reservoirs.c
9:59 am

qnguyen  (deleted user)

Done.

Done.

9:59 am

qnguyen  (deleted user)

Done.

Done.

9:58 am

qnguyen  (deleted user)

Added a define.

Added a define.