dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 01 Mar 2022
2:12 pm

Dara Navaei

DEN-1750 merge ccvectorcast2 from the dev testers

Options
1:58 pm

hnguyen  (deleted user)

Changed CONCENTRATE_PUMP_MAX_SPEED from 40.0 to 48.0.

Changed CONCENTRATE_PUMP_MAX_SPEED from 40.0 to 48.0.

1:55 pm

hnguyen  (deleted user)

Added a blank line. Asked Dara to add acid and bicard values to the calibration record on 2/8/2022.

Added a blank line.
Asked Dara to add acid and bicard values to the calibration record on 2/8/2022.

1:49 pm

hnguyen  (deleted user)

Checked with Systems. Conductivity min value is 100. #define COND_SENSOR_CPI_MAX_VALUE 2200 #define COND_SENSOR_CPI_WARNING_HIGH 2200 #define COND_SENSOR_CPI_WARNING_LOW 2000 #define COND_SENSOR_CP...

Checked with Systems. Conductivity min value is 100.
#define COND_SENSOR_CPI_MAX_VALUE 2200
#define COND_SENSOR_CPI_WARNING_HIGH 2200
#define COND_SENSOR_CPI_WARNING_LOW 2000
#define COND_SENSOR_CPI_MIN_VALUE 100

1:45 pm

hnguyen  (deleted user)

Updated code to include checking for high conductivity

Updated code to include checking for high conductivity

1:03 pm

hnguyen  (deleted user)

Added ALARM_ID_INLET_WATER_HIGH_CONDUCTIVITY = 158, ///< Inlet water conductivity too high in AlarmDefs.h

Added ALARM_ID_INLET_WATER_HIGH_CONDUCTIVITY = 158, ///< Inlet water conductivity too high in AlarmDefs.h

11:03 am

Sean Nash

Do we need to fix this?

Do we need to fix this?

10:59 am

Sean Nash

This doesn't look like a get - status is being set. I don't think we should be setting .ovData here at all - should only be set via an override cmd message. I think .data should always be set here ...

This doesn't look like a get - status is being set. I don't think we should be setting .ovData here at all - should only be set via an override cmd message. I think .data should always be set here (no if).

10:52 am

Sean Nash

Remove blank line.

Remove blank line.

10:52 am

Sean Nash

Any reason why this declaration isn't at top of function?

Any reason why this declaration isn't at top of function?

10:51 am

Sean Nash

?

?

10:51 am

Sean Nash

Any reason why this is still a TODO?

Any reason why this is still a TODO?

10:50 am

Sean Nash

Concentrate pumps are available, right?

Concentrate pumps are available, right?

10:49 am

Sean Nash

Any reason why this is still a TODO?

Any reason why this is still a TODO?

10:49 am

Sean Nash

?

?

10:42 am

Sean Nash

Yes, I think we should do that

Yes, I think we should do that

Monday 28 Feb 2022
4:30 pm

Sean Nash

Put "none" in function headers where there is nothing in that section (throughout this module).

Put "none" in function headers where there is nothing in that section (throughout this module).

4:28 pm

Sean Nash

testValue is a parameter - not an input. There are 2 other parameters. Need to add @param for each.

testValue is a parameter - not an input. There are 2 other parameters. Need to add @param for each.

4:07 pm

Sean Nash

Is this average calculation correct? Do we need to weight samples based on CP rate?

Is this average calculation correct? Do we need to weight samples based on CP rate?

4:02 pm

Sean Nash

Do we still need temperature check here?

Do we still need temperature check here?

3:59 pm

Sean Nash

What is the point of turning off the pumps here?

What is the point of turning off the pumps here?

3:57 pm

Sean Nash

Do we need to set RO pump rate here before we move on to produce/delivery dialysate?

Do we need to set RO pump rate here before we move on to produce/delivery dialysate?

3:51 pm

Sean Nash

Do we still want to check temperature here? I thought this was no longer being done. Check with Dara.

Do we still want to check temperature here? I thought this was no longer being done. Check with Dara.

3:44 pm

Sean Nash

Is this equation correct? Doesn't look right to me.

Is this equation correct? Doesn't look right to me.

3:37 pm

Sean Nash

Put space between if and (.

Put space between if and (.

3:36 pm

Sean Nash

Is 400 mL/min rate correct? I thought it was 800.

Is 400 mL/min rate correct? I thought it was 800.

3:32 pm

Sean Nash

Do both lines prime in same amount of time? Are volumes same? Is 2 seconds the right amount of time?

Do both lines prime in same amount of time? Are volumes same? Is 2 seconds the right amount of time?

3:26 pm

Sean Nash

Does this alarm need persistence? Looks like it used to have a timeout but now it's immediate.

Does this alarm need persistence? Looks like it used to have a timeout but now it's immediate.

3:25 pm

Sean Nash

If alarm is recoverable, we should go to paused state. If not, we should not delete this line of code so we can exit fill mode. Otherwise, we get stuck here forever.

If alarm is recoverable, we should go to paused state. If not, we should not delete this line of code so we can exit fill mode. Otherwise, we get stuck here forever.

3:19 pm

Sean Nash

You must set isThisFirstFill to FALSE somewhere. This may not be the right place anymore - but it looks ok to me - why deleted?

You must set isThisFirstFill to FALSE somewhere. This may not be the right place anymore - but it looks ok to me - why deleted?