dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 06 Oct 2022
12:14 pm

Dara Navaei

Merge branch 'DEN-13834-dg_hd_dev-hd_dg_dvt-update-part-3' into develop

Options
    • -4
    • +4
    /firmware/App/Controllers/LoadCell.c
12:12 pm

Dara Navaei

DEN-13834 updated the fault mode

Options
    • -0
    • +2
    /firmware/App/Modes/ModeFault.c
11:18 am

wbracken  (deleted user)

Alarm for invalid loadCellID?

Alarm for invalid loadCellID?

11:16 am

wbracken  (deleted user)

Should there be an alarm if loadCellID is invalid?

Should there be an alarm if loadCellID is invalid?

11:13 am

wbracken  (deleted user)

Why the change?

Why the change?

10:30 am

Sean Nash

Merge branch 'DEN-13834-dg_hd_dev-hd_dg_dvt-update-part-3' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-13834-dg_hd_dev-hd_dg_dvt-update-part-3

Options
    • -19
    • +7
    /firmware/App/Controllers/LoadCell.c
10:30 am

Sean Nash

DEN-13834: Fixed loadcell range check.

Options
    • -4
    • +4
    /firmware/App/Controllers/LoadCell.c
10:04 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
10:02 am

Dara Navaei

Merged DEN-13834

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -34
    • +16
    /firmware/App/Controllers/ConductivitySensors.c
    • -11
    • +21
    /firmware/App/Controllers/Heaters.c
    • -63
    • +85
    /firmware/App/Controllers/LoadCell.c
    • -7
    • +6
    /firmware/App/Controllers/ROPump.h
    • -11
    • +21
    /firmware/App/Controllers/Switches.c
    • -16
    • +17
    /firmware/App/Controllers/TemperatureSensors.c
    • -3
    • +1
    /firmware/App/DGCommon.h
    • -1
    • +1
    /firmware/App/Drivers/CPLD.c
    • -2
    • +2
    /firmware/App/Drivers/CPLD.h
    • -2
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.c
    • -2
    • +2
    /firmware/App/Modes/OperationModes.c
    • -2
    • +2
    /firmware/App/Services/AlarmMgmt.c
    • -5
    • +6
    /firmware/App/Services/AlarmMgmtSWFaults.h
  16. … 3 more files in changeset.
9:21 am

Dara Navaei

Merge branch 'DEN-13834-dg_hd_dev-hd_dg_dvt-update-part-3' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-13834-dg_hd_dev-hd_dg_dvt-update-part-3

Options
    • -18
    • +44
    /firmware/App/Controllers/LoadCell.c
9:21 am

Dara Navaei

DEN-13834 added self test alarms

Options
    • -10
    • +18
    /firmware/App/Controllers/FlowSensors.c
    • -1
    • +1
    /firmware/App/Controllers/FlowSensors.h
    • -19
    • +7
    /firmware/App/Controllers/LoadCell.c
    • -16
    • +35
    /firmware/App/Controllers/Pressures.c
    • -9
    • +10
    /firmware/App/Controllers/ROPump.c
    • -2
    • +3
    /firmware/App/Controllers/ROPump.h
    • -12
    • +10
    /firmware/App/Modes/ModeFill.c
9:20 am

Sean Nash

DEN-13834: Added additional override of load cell after calibration but before filter/tare.

Options
    • -15
    • +42
    /firmware/App/Controllers/LoadCell.c
    • -2
    • +2
    /firmware/App/Controllers/LoadCell.h
    • -6
    • +12
    /firmware/App/Services/SystemCommMessages.c
8:54 am

Sean Nash

DEN-13834: minor change to logging data of LC drift alarm.

Options
    • -3
    • +2
    /firmware/App/Controllers/LoadCell.c
Tuesday 04 Oct 2022
5:17 pm

Sean Nash

Do we still need this? If so, can we make a s/w config instead?

Do we still need this? If so, can we make a s/w config instead?

5:14 pm

Sean Nash

Is this resolved?

Is this resolved?

5:04 pm

Sean Nash

Why are we not checking payload length?

Why are we not checking payload length?

5:03 pm

Sean Nash

If this function is not yet needed, should we remove or at least put a #ifdef PHASE_1B build flag around it? Otherwise this is dead code right now.

If this function is not yet needed, should we remove or at least put a #ifdef PHASE_1B build flag around it? Otherwise this is dead code right now.

5:00 pm

Sean Nash

Why are we not enforcing payload length check?

Why are we not enforcing payload length check?

5:00 pm

Sean Nash

Can this declaration be moved to top of function?

Can this declaration be moved to top of function?

4:57 pm

Sean Nash

Why are we hiding this condition from Vectorcast?

Why are we hiding this condition from Vectorcast?

4:55 pm

Sean Nash

This comment should precede the if statement above.

This comment should precede the if statement above.

4:52 pm

Sean Nash

Is this 109?

Is this 109?

4:51 pm

Sean Nash

This looks like 104 (not 106). And we should be noting every 5th enum anyway.

This looks like 104 (not 106). And we should be noting every 5th enum anyway.

11:29 am

Sean Nash

Is this resolved now? Can we un-comment this code?

Is this resolved now? Can we un-comment this code?

11:19 am

wbracken  (deleted user)

Remove isPOSTComplete.

Remove isPOSTComplete.

8:40 am

Sean Nash

Can we remove "TODO" since implementation is not required at this time. Re-phrase comment to something like "If temp sensors require calibration, implement here."

Can we remove "TODO" since implementation is not required at this time. Re-phrase comment to something like "If temp sensors require calibration, implement here."

8:36 am

Sean Nash

POST does nothing? If always in progress, do we get stuck in this test?

POST does nothing? If always in progress, do we get stuck in this test?

8:31 am

Sean Nash

Remove blank line.

Remove blank line.

8:29 am

Sean Nash

Can these declarations be moved to top of function?

Can these declarations be moved to top of function?

8:25 am

Sean Nash

Lets get this question answered. I don't see the harm in having a max flow. I can't imagine we're ever seeing that much flow, so not sure why this has to be commented out while we sort out its exis...

Lets get this question answered. I don't see the harm in having a max flow. I can't imagine we're ever seeing that much flow, so not sure why this has to be commented out while we sort out its existence.