dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 05 Dec 2022
10:17 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/FlowSensors.c
    • -1
    • +1
    /firmware/App/Controllers/FlowSensors.h
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
10:16 am

Dara Navaei

9:43 am

Sean Nash

9:43 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:42 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 02 Dec 2022
5:51 pm

Michael Garthwaite

5:50 pm

Dara Navaei

DEN-14253 addressed the code review comments

Options
    • -4
    • +5
    /firmware/App/Controllers/FlowSensors.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
5:50 pm

Dara Navaei

Done.

Done.

5:43 pm

Dara Navaei

Done.

Done.

4:50 pm

Sean Nash

Can't we just say isFlowLow = ( measFlow > minFlow ? FALSE : TRUE );

Can't we just say isFlowLow = ( measFlow > minFlow ? FALSE : TRUE );

4:43 pm

Sean Nash

For both sensors, the .data should only be set once to final value. Use a temporary local variable until it's ready.

For both sensors, the .data should only be set once to final value. Use a temporary local variable until it's ready.

Thursday 01 Dec 2022
2:26 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
2:26 pm

Dara Navaei

Merged DEN-14253

Options
    • -8
    • +8
    /firmware/App/Controllers/Heaters.c
    • -6
    • +5
    /firmware/App/Controllers/Pressures.c
    • -30
    • +31
    /firmware/App/Controllers/ROPump.c
    • -5
    • +4
    /firmware/App/Controllers/ROPump.h
    • -2
    • +2
    /firmware/App/Modes/ModeGenIdle.c
    • -2
    • +2
    /firmware/App/Modes/ModeGenIdle.h
    • -4
    • +4
    /firmware/App/Modes/ModeInitPOST.c
    • -2
    • +3
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -75
    • +100
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
1:58 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13505 Remove previous change.

Options
    • -3
    • +0
    /firmware/App/Modes/ModeGenIdle.c
12:34 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14267 Initialize VRf, VRi and VRo when transitioning to GEN_IDLE.

Options
    • -0
    • +3
    /firmware/App/Modes/ModeGenIdle.c
10:51 am

Dara Navaei

DEN-14253 updated the code so the trimmer heater with no flow uses the raw dialysate flow prior to applying the calibration to it.

Options
    • -12
    • +27
    /firmware/App/Controllers/FlowSensors.c
    • -2
    • +3
    /firmware/App/Controllers/FlowSensors.h
    • -8
    • +8
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
10:46 am

Dara Navaei

DG-DEN-14253_Dialysate Flow Too Low Alarm Occurs AT 100 ML Min
DG-DEN-14253_Dialysate Flow Too Low Alarm Occurs AT 100 ML Min
9:38 am

jtaylor  (deleted user)

9:37 am

Dara Navaei

DEN-14307 updated the usage info records in the NV data management

Options
    • -27
    • +20
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -3
    • +32
    /firmware/App/Modes/ModeFlush.c
    • -61
    • +54
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -0
    • +23
    /firmware/App/Modes/ModeStandby.c
    • -6
    • +0
    /firmware/App/Services/Reservoirs.c
    • -6
    • +2
    /firmware/App/Services/SystemCommMessages.c
9:27 am

Dara Navaei

DG-DEN-14403_DG Voltages Alarm 77 Not Triggered
DG-DEN-14403_DG Voltages Alarm 77 Not Triggered
Wednesday 30 Nov 2022
5:02 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14403-dg-voltages-alarm-77-not-triggered FPGA 1V alarm limits modified to +/-5% from +/-10%, to match requirements

Options
    • -2
    • +7
    /firmware/App/Controllers/Voltages.c
4:44 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13050 - Correct VPi transition to DG_STANDBY_MODE_STATE_FLUSH_FILTER_IDLE from DG_STANDBY_MODE_STATE_SAMPLE_WATER.

Options
    • -0
    • +1
    /firmware/App/Modes/ModeStandby.c
3:18 pm

wbracken  (deleted user)

Alignment

Alignment

3:13 pm

wbracken  (deleted user)

Remove

Remove

3:10 pm

wbracken  (deleted user)

Remove.

Remove.

3:10 pm

wbracken  (deleted user)

Think the deleted def is correct.

Think the deleted def is correct.

3:09 pm

wbracken  (deleted user)

Alignment

Alignment

3:08 pm

wbracken  (deleted user)

Remove.

Remove.

3:08 pm

wbracken  (deleted user)

Alignment

Alignment

2:55 pm

wbracken  (deleted user)

Alignment

Alignment