dgfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle' into develop

    • -21
    • +13
    /firmware/App/Controllers/LoadCell.c
DEN-13757 - Remove unused function monitorLoadCellsWeightOutOfRange/

    • -20
    • +0
    /firmware/App/Controllers/LoadCell.c
DG-DEN-13050_Vpi Does Not Close After Sample Water Returns TO Flush Idle
DG-DEN-13050_Vpi Does Not Close After Sample Water Returns TO Flush Idle
DEN-13757 - Correction to load cell alarm.

DEN-13757 - All 4 load cells have a single persistent alarm. Change to correspond to how pressure alarms are handled.

    • -1
    • +13
    /firmware/App/Controllers/LoadCell.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
DEN-14316-chemical-disinfect. This is a testing version. It is not yet complete.

    • -272
    • +470
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -731
    • +667
    /firmware/App/Modes/ModeFlush.c
DEN-13050

    • -2
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    /firmware/App/Controllers/FlowSensors.c
    • -1
    • +1
    /firmware/App/Controllers/FlowSensors.h
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-14253 addressed the code review comments

    • -4
    • +5
    /firmware/App/Controllers/FlowSensors.c
Done.

Done.

Done.

Done.

Can't we just say isFlowLow = ( measFlow > minFlow ? FALSE : TRUE );

Can't we just say isFlowLow = ( measFlow > minFlow ? FALSE : TRUE );

For both sensors, the .data should only be set once to final value. Use a temporary local variable until it's ready.

For both sensors, the .data should only be set once to final value. Use a temporary local variable until it's ready.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merged DEN-14253

    • -30
    • +31
    /firmware/App/Controllers/ROPump.c
DEN-13505 Remove previous change.

DEN-14267 Initialize VRf, VRi and VRo when transitioning to GEN_IDLE.

DEN-14253 updated the code so the trimmer heater with no flow uses the raw dialysate flow prior to applying the calibration to it.

    • -12
    • +27
    /firmware/App/Controllers/FlowSensors.c
    • -2
    • +3
    /firmware/App/Controllers/FlowSensors.h
DG-DEN-14253_Dialysate Flow Too Low Alarm Occurs AT 100 ML Min
DG-DEN-14253_Dialysate Flow Too Low Alarm Occurs AT 100 ML Min