dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 10 Jan 2023
3:46 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
3:33 pm

Sean Nash

Fixed merge conflicts.

Options
    • -52
    • +28
    /firmware/App/Controllers/ConductivitySensors.c
    • -6
    • +7
    /firmware/App/Controllers/ConductivitySensors.h
    • -88
    • +113
    /firmware/App/Controllers/DrainPump.c
    • -5
    • +4
    /firmware/App/Controllers/DrainPump.h
    • -18
    • +86
    /firmware/App/Controllers/Heaters.c
    • -0
    • +3
    /firmware/App/Controllers/Heaters.h
    • -10
    • +20
    /firmware/App/Controllers/Pressures.c
    • -25
    • +37
    /firmware/App/Controllers/ROPump.c
    • -0
    • +1
    /firmware/App/Controllers/ROPump.h
    • -4
    • +15
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +2
    /firmware/App/Drivers/CPLD.h
    • -300
    • +224
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -193
    • +157
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +0
    /firmware/App/Modes/ModeDrain.c
    • -10
    • +55
    /firmware/App/Modes/ModeFill.c
  16. … 8 more files in changeset.
8:30 am

Sean Nash

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum). Could also create a redundant 0 enum like below and use the "first" enum to initial...

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum).
Could also create a redundant 0 enum like below and use the "first" enum to initialize a loop iterator safely:
enum list
{
FIRST_TEMP_SENSOR = 0,
TPI_SENSOR = FIRST_TEMP_SENSOR,
TPO_SENSOR,
TD1_SENSOR,
....
}
RESOLVED in CODE WALKTHROUGH.

8:24 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 09 Jan 2023
6:01 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-13946-certain-temperature-sensors-trigger-wrong-alarm

Options
    • -7
    • +14
    /firmware/App/Controllers/LoadCell.c
5:59 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 - Use typedefs for iterating over sensors.

Options
    • -3
    • +1
    /firmware/App/Controllers/LoadCell.c
3:04 pm

Dara Navaei

DEN-14497 updated the drain pump flow control algorithm. Fixed the inlet water pressure, temperature, conductivity alarm recovery in treatment modes. Updated chemical disinfect flush mode

Options
    • -16
    • +27
    /firmware/App/Controllers/ConductivitySensors.c
    • -11
    • +9
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.h
    • -9
    • +19
    /firmware/App/Controllers/Pressures.c
    • -4
    • +14
    /firmware/App/Controllers/TemperatureSensors.c
    • -145
    • +117
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -193
    • +157
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -8
    • +2
    /firmware/App/Modes/ModeFill.c
    • -45
    • +61
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -0
    • +2
    /firmware/App/Services/AlarmMgmt.c
    • -3
    • +3
    /firmware/App/Services/PIControllers.c
1:03 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Use typedefs for itterating over sensors.

Options
    • -4
    • +4
    /firmware/App/Controllers/LoadCell.c
    • -4
    • +3
    /firmware/App/Controllers/Pressures.c
    • -6
    • +6
    /firmware/App/Controllers/TemperatureSensors.c
    • -2
    • +1
    /firmware/App/Controllers/Thermistors.c
11:37 am

wbracken  (deleted user)

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typ...

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typedef THERMISTORS_TEMP_SENSORS_T. Changed load cells to use U08 to be consistent with temperature and pressure monitoring.

Should probably change temperature, pressure and load cells to use correct typedef.

Also, it looks like why the typedefs weren't used was in order to set the initial value of the iterator to 0 (i.e, the first sensor in the list). Seems like there should be a value that is the first item in the list, i.e. TEMPSENSORS_FIRST_SENSOR.

11:07 am

wbracken  (deleted user)

Removed.

Removed.

10:15 am

Sean Nash

Remove blank line.

Remove blank line.

Friday 06 Jan 2023
5:46 pm

Sean Nash

DEN-14497: Added CPo and RR alarms to fill mode recoverable list.

Options
    • -4
    • +12
    /firmware/App/Modes/ModeFill.c
5:38 pm

Sean Nash

DEN-14497: Changed CPo and RR alarms to only occur at end of fill based on average conductivity.

Options
    • -34
    • +0
    /firmware/App/Controllers/ConductivitySensors.c
    • -6
    • +7
    /firmware/App/Controllers/ConductivitySensors.h
    • -1
    • +0
    /firmware/App/Modes/ModeDrain.c
    • -4
    • +47
    /firmware/App/Modes/ModeFill.c
    • -1
    • +0
    /firmware/App/Modes/ModeGenIdle.c
4:36 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
4:36 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfectActiveCool.c
4:35 pm

Dara Navaei

4:33 pm

wbracken  (deleted user) and Sean Nash

4:12 pm

Dara Navaei

DEN-14548 changed the time for heat disinfect cooling from 3 hours to 5 hours

Options
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfectActiveCool.c
4:02 pm

Sean Nash

Why change this to U08?

Why change this to U08?

3:00 pm

Dara Navaei

DG-DEN-14548_Alarm 247 ON DG Heat Disinfect
DG-DEN-14548_Alarm 247 ON DG Heat Disinfect
1:37 pm

Dara Navaei

DEN-14548 increased the heat disinfect cooling timeout from 90 minutes to 180 minutes

Options
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfectActiveCool.c
10:58 am

wbracken  (deleted user)

Add to header and alignment.

Add to header and alignment.

Thursday 05 Jan 2023
4:36 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
4:36 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Controllers/LoadCell.c
4:30 pm

Dara Navaei

4:22 pm

jtaylor  (deleted user) , wbracken  (deleted user) and Dara Navaei

11:38 am

Sean Nash

Use get function for override.

Use get function for override.

10:12 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
10:12 am

Sean Nash

Merge branch 'develop' of ssh://dvm-linux02:7999/dg/dgfirmware into develop

Options
10:11 am

Sean Nash

Merge branch 'DEN-14086-alarm-159-dialysate-inlet-pump-failed-flow-vs-motor-speed-check' into develop

Options
    • -2
    • +1
    /firmware/App/Controllers/LoadCell.c