dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14559 updated the cleaning modes with the SRS changes

    • -71
    • +84
    /firmware/App/Modes/ModeChemicalDisinfect.c
    • -33
    • +18
    /firmware/App/Modes/ModeHeatDisinfect.c
DEN-13946 Darren comments DEN-14075 Corrected thermistor override in previous commit

    • -6
    • +2
    /firmware/App/Controllers/Thermistors.c
Corrected.

Corrected.

Only used if Temperature is in alarm.

Only used if Temperature is in alarm.

Only used if the load cell is out of range.

Only used if the load cell is out of range.

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

Why remove initial value for alarmIndex?

Why remove initial value for alarmIndex?

Comment does not explain what the numbers are - 3, 10, 10.

Comment does not explain what the numbers are - 3, 10, 10.

Comment is 12bit specific, but code updated to use different references per thermistor.

Comment is 12bit specific, but code updated to use different references per thermistor.

DEN-13676 Add acid and bicarb low volume defines per SRS.

DG-DEN-13676_Bicarb Low Alarm Threshold Incorrect
DG-DEN-13676_Bicarb Low Alarm Threshold Incorrect
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-13946-certain-temperature-sensors-trigger-wrong-alarm' into develop

DEN-13946 Correction to thermistor timeout.

    • -1
    • +1
    /firmware/App/Controllers/Thermistors.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-13946-certain-temperature-sensors-trigger-wrong-alarm' into develop

# Conflicts:

# firmware/App/DGCommon.h

    • -14
    • +16
    /firmware/App/Controllers/LoadCell.c
DEN-13946 Complete and tested for termperatures, pressures, load cells and thermistors. DEN-14075 Corrected thermistor override limits.

    • -30
    • +42
    /firmware/App/Controllers/Thermistors.c
Merge branch 'staging' into DEN-13946-certain-temperature-sensors-trigger-wrong-alarm

    • -11
    • +21
    /firmware/App/Controllers/Pressures.c
Merge branch 'staging' into DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle

DG-DEN-14559_DG HD Dev HD DG Dvt Update Part 8
DG-DEN-14559_DG HD Dev HD DG Dvt Update Part 8
DEN-13946 Update thermistor init.

    • -7
    • +21
    /firmware/App/Controllers/Thermistors.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 9 more files in changeset.
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

DEN-14497 addressed the code review comment

DEN-13946 - Alarm generation is complete. Thermistors now configured based upon beta or DVT hardware configurations. Working with Noe to address FPGA thermistor values after reset.

    • -14
    • +34
    /firmware/App/Controllers/Thermistors.c
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.