Activity dgfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 17 May 2023

8:52 am

Dara Navaei

More
dcca963
changed 2 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 117 more DG-DEN-15274-1

DEN-15274 addressed the code review comments

- -3
- +3
/firmware/App/Controllers/LoadCell.h
- History
- Source
- Diff
/firmware/App/Controllers/LoadCell.h
- -0
- +5
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c

8:37 am

Sean Nash

More
Re: DG-DEN-15274-1
replied to Sean Nash

Purpose is to account for cooling of dialysate from reservoir to dialyzer. The faster Qd is, the less cooling will occur (less time to cool). RESOLVED in CODE WALKTHROUGH.

Purpose is to account for cooling of dialysate from reservoir to dialyzer. The faster Qd is, the less cooling will occur (less time to cool).
RESOLVED in CODE WALKTHROUGH.

8:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:34 am

Dara Navaei

More
3839f1c
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 117 more DG-DEN-15274-1

DEN-15274 addressed the code review comment

- -43
- +43
/firmware/App/Controllers/LoadCell.c
- History
- Source
- Diff
/firmware/App/Controllers/LoadCell.c

8:34 am

Dara Navaei

More
Re: DG-DEN-15274-1
replied to Sean Nash

Done

Done

8:30 am

Sean Nash

More
Re: DG-DEN-15274-1
commented on review

If these are only for Dialin, move down to test support functions area.

If these are only for Dialin, move down to test support functions area.

8:20 am

Dara Navaei

More
3d87e97
changed 4 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 117 more DG-DEN-15274-1

DEN-15274 addressed the code review comments

- -4
- +4
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -0
- +3
/firmware/App/Controllers/LoadCell.c
- History
- Source
- Diff
/firmware/App/Controllers/LoadCell.c
- -1
- +1
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c
- -3
- +4
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c

8:11 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 16 May 2023

5:49 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

5:49 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

5:32 pm

wbracken (deleted user)

More
Re: DG-DEN-14902-1
commented on review

Includes should be in alphabetical order.

Includes should be in alphabetical order.

5:16 pm

Dara Navaei

More
Re: DG-DEN-15274-1
replied to Sean Nash

Done

Done

5:16 pm

Dara Navaei

More
Re: DG-DEN-15274-1
replied to wbracken (deleted user)

Done

Done

5:15 pm

Dara Navaei

More
Re: DG-DEN-15274-1
replied to Sean Nash

Done

Done

5:12 pm

Dara Navaei

More
e5713fc
changed 8 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 117 more DG-DEN-15274-1

Merge branch 'staging' into DEN-15274-hd_dg_test_configuration_setup

- -3
- +3
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c
- -3
- +3
/firmware/App/Modes/ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
/firmware/.../ModeChemicalDisinfectFlush.c
- -2
- +3
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c
- -3
- +3
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -3
- +3
/firmware/App/Modes/ModeFlush.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.c
- -3
- +8
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c
- -3
- +3
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c
- -3
- +3
/firmware/App/Modes/ModeHeatDisinfectActiveCool.c
- History
- Source
- Diff
/firmware/.../ModeHeatDisinfectActiveCool.c

4:36 pm

Michael Garthwaite

More
DG-DEN-13989-2
finished reviewing

4:05 pm

Dara Navaei

More
f94932e
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 117 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

4:04 pm

Dara Navaei

More
eeaab2a
changed 14 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 117 more DG-DEN-15274-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c
- -2
- +2
/firmware/App/Modes/ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
/firmware/.../ModeChemicalDisinfectFlush.c
- -2
- +2
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c
- -2
- +2
/firmware/App/Modes/ModeFault.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFault.c
- -2
- +2
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -2
- +2
/firmware/App/Modes/ModeFlush.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.c
- -2
- +2
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c
- -2
- +2
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c
- -2
- +2
/firmware/App/Modes/ModeHeatDisinfectActiveCool.c
- History
- Source
- Diff
/firmware/.../ModeHeatDisinfectActiveCool.c
- -2
- +2
/firmware/App/Modes/ModeInitPOST.c
- History
- Source
- Diff
/firmware/App/Modes/ModeInitPOST.c
- -2
- +2
/firmware/App/Modes/ModeService.c
- History
- Source
- Diff
/firmware/App/Modes/ModeService.c
- -2
- +2
/firmware/App/Modes/ModeSolo.c
- History
- Source
- Diff
/firmware/App/Modes/ModeSolo.c
- -2
- +2
/firmware/App/Modes/OperationModes.c
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.c
- -2
- +2
/firmware/App/Modes/OperationModes.h
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.h

3:47 pm

Michael Garthwaite

More
799e94e
changed 0 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 117 more

Merge branch 'DEN-15196-DIAL-251' into staging

3:45 pm

Michael Garthwaite

More
DG-DEN-15196-3
Closed

3:43 pm

Sean Nash and wbracken (deleted user)

More
DG-DEN-15196-3
finished reviewing

3:37 pm

Sean Nash

More
Re: DG-DEN-15274-1
commented on review

Don't forget to roll compatibility for all 3 stacks.

Don't forget to roll compatibility for all 3 stacks.

2:33 pm

wbracken (deleted user)

RESOLVED IN CODE WALK THROUGH

RESOLVED IN CODE WALK THROUGH

2:32 pm

Michael Garthwaite

More
a8976d6
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 118 more DG-DEN-15196-3

DIAL-251: code review comments.

- -1
- +1
/firmware/App/Modes/OperationModes.c
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.c

2:31 pm

wbracken (deleted user)

More
Re: DG-DEN-15196-3
commented on review

#define for initial/undefined.

#define for initial/undefined.

2:31 pm

Michael Garthwaite

More
Re: DG-DEN-15196-3
replied to wbracken (deleted user)

Fixed. Thanks!

Fixed. Thanks!

1:27 pm

Sean Nash

More
Re: DG-DEN-15274-1
replied to wbracken (deleted user)

function wants a U32. C will convert automatically, so not necessary I guess.

function wants a U32. C will convert automatically, so not necessary I guess.

12:44 pm

Michael Garthwaite

More
8c5fef6
changed 4 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 118 more DG-DEN-15196-3

Merge branch 'staging' into DEN-15196-DIAL-251

- -1
- +4
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c
- -1
- +6
/firmware/App/Modes/ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
/firmware/.../ModeChemicalDisinfectFlush.c
- -2
- +9
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -2
- +5
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c

12:43 pm

Michael Garthwaite

More
d19a072
changed 14 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 118 more DG-DEN-15196-3

DIAL-251: DG changes for operation status event handling.

- -1
- +1
/firmware/App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
/firmware/App/.../ModeChemicalDisinfect.c
- -1
- +1
/firmware/App/Modes/ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
/firmware/.../ModeChemicalDisinfectFlush.c
- -0
- +1
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c
- -1
- +1
/firmware/App/Modes/ModeFault.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFault.c
- -1
- +1
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -1
- +1
/firmware/App/Modes/ModeFlush.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.c
- -1
- +6
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c
- -1
- +1
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c
- -1
- +1
/firmware/App/Modes/ModeHeatDisinfectActiveCool.c
- History
- Source
- Diff
/firmware/.../ModeHeatDisinfectActiveCool.c
- -1
- +1
/firmware/App/Modes/ModeInitPOST.c
- History
- Source
- Diff
/firmware/App/Modes/ModeInitPOST.c
- -1
- +1
/firmware/App/Modes/ModeService.c
- History
- Source
- Diff
/firmware/App/Modes/ModeService.c
- -1
- +1
/firmware/App/Modes/ModeSolo.c
- History
- Source
- Diff
/firmware/App/Modes/ModeSolo.c
- -2
- +48
/firmware/App/Modes/OperationModes.c
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.c
- -0
- +3
/firmware/App/Modes/OperationModes.h
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.h

11:28 am

Dara Navaei

More
0210b8e
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-24 10:24 -0700