dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 09 Aug 2023
5:36 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -2
    • +2
    /firmware/App/Controllers/ConcentratePumps.h
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Controllers/FlowSensors.c
    • -1
    • +1
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -1
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
5:34 pm

Dara Navaei

Merged DEN-15125

Options
5:29 pm

Dara Navaei

5:26 pm

Sean Nash

5:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:59 pm

wbracken  (deleted user) and Sean Nash

4:55 pm

wbracken  (deleted user)

That's what it looked like when reviewed HD side. RESOLVED IN CODE WALKTHROUGH

That's what it looked like when reviewed HD side.

RESOLVED IN CODE WALKTHROUGH

4:44 pm

Dara Navaei

DEN-16125 updated the concentrate pumps code to set the direction speed of the concentrate pumps when the measured speed is called

Options
    • -8
    • +7
    /firmware/App/Controllers/ConcentratePumps.c
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.h
    • -0
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Controllers/FlowSensors.c
    • -2
    • +2
    /firmware/App/Modes/ModeFill.c
    • -2
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.c
4:25 pm

Michael Garthwaite

Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

Options
    • -7
    • +14
    /firmware/App/Services/SystemCommMessages.c
4:24 pm

Michael Garthwaite

DEN-15634: code review comments.

Options
    • -0
    • +1
    /firmware/App/Modes/ModeDrain.h
4:22 pm

Michael Garthwaite

Fixed!

Fixed!

3:10 pm

Sean Nash

For DG, it's not used (yet at least). But there are common macros that call this function, so had to change HD and DG versions of this function.

For DG, it's not used (yet at least). But there are common macros that call this function, so had to change HD and DG versions of this function.

3:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:05 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:05 pm

Sean Nash

Move blank line up one.

Move blank line up one.

3:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:03 pm

Sean Nash

Move blank line down one.

Move blank line down one.

2:44 pm

Michael Garthwaite

DEN-15634: code review comments.

Options
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
1:48 pm

wbracken  (deleted user)

Where is outside used?

Where is outside used?

1:43 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:33 pm

Dara Navaei

DEN-15125 addressed the compiler warnings

Options
    • -8
    • +3
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
    • -19
    • +0
    /firmware/App/Modes/ModeFill.c
    • -3
    • +0
    /firmware/App/Services/SystemCommMessages.c
1:16 pm

Michael Garthwaite

DEN-15634: fixed warnings

Options
    • -0
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -0
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
1:10 pm

Michael Garthwaite

DEN-15634: fixed compiler error.

Options
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
1:09 pm

Michael Garthwaite

DEN-15634: added drain mode msg_id to publish.

Options
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
12:42 pm

Dara Navaei

DG-DEN-16125_DG Chem Flush DG Does Not Transition From Flush R1 TO R2 Drain R2 TO Cancel Water
DG-DEN-16125_DG Chem Flush DG Does Not Transition From Flush R1 TO R2 Drain R2 TO Cancel Water
12:41 pm

Dara Navaei

DEN-16125 removed the code in chemical flush that was checking the drain timeout in some of the states

Options
    • -34
    • +0
    /firmware/App/Modes/ModeChemicalDisinfectFlush.c
10:36 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
10:32 am

Sean Nash

Merge branch 'DENBUG-59-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow' into develop

Options
    • -1
    • +2
    /firmware/App/Services/SystemComm.c
    • -3
    • +0
    /firmware/App/Services/SystemCommMessages.c
10:30 am

Sean Nash

DENBUG-59: Distinguish between alarms originating outside.

Options
    • -3
    • +4
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmt.h
Tuesday 08 Aug 2023
4:30 pm

Sean Nash

DENBUG-59: Added alarm properties to prevent alarm trigger while in rinseback or post-tx states.

Options
    • -6
    • +16
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +2
    /firmware/App/Services/SystemComm.c
    • -3
    • +0
    /firmware/App/Services/SystemCommMessages.c