dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-16309 added a new heat disinfect state

    • -7
    • +11
    /firmware/App/Controllers/Heaters.c
    • -10
    • +62
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -0
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.h
DEN-16309 removed the clearance period some of the persistence alarms

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the chec...

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the check as it looks to be able to handle different modes, but again doesn't have access to the last set PWM value.

Merge branch 'staging' into DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment

DEN-15973 Address code review comments

Corrected

Corrected

Corrected

Corrected

Corrected

Corrected

Done.

Done.

Done.

Done.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

DEN-16093 code review comments added

DEN-16093 fixed code review comments

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is redu...

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is reduced, this level should also be reduced accordingly."

100% now.

100% now.

Merge branch 'staging' into DIAL-276-dg-event-event-id-15-prints-duplicate-events-with-different-state-time

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

DEN-16093 fixed merging conflicts

DEN-16093-Increased conductivity percentage check and time out values

take latest changes from staging

    • -4
    • +58
    /firmware/App/Services/SystemComm.c
As we discussed, I think alarm 150 and related inlet water alarms are already set to block triggering during rinseback and post-treatment modes. So these changes are likely not needed.

As we discussed, I think alarm 150 and related inlet water alarms are already set to block triggering during rinseback and post-treatment modes. So these changes are likely not needed.

DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT
DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merged DENBUG-59