dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

These fields have been moved to a different broadcast at some point, and were no longer being set by the reservoir data broadcast. The fields regularly contained "NAN" values, so I removed them.

These fields have been moved to a different broadcast at some point, and were no longer being set by the reservoir data broadcast. The fields regularly contained "NAN" values, so I removed them.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Why are these fields removed?

Why are these fields removed?

DG-DEN-16383_Heat Disinfect R1 TO R2 Timer Overflows And Stuck IN State
DG-DEN-16383_Heat Disinfect R1 TO R2 Timer Overflows And Stuck IN State
Done. Code updates pushed.

Done. Code updates pushed.

I don't see these being used anywhere.

I don't see these being used anywhere.

DG Staging Unreviewed Commits
DG Staging Unreviewed Commits
DG-DEN-16381_Chemical Disinfect 1St Transition TO Disinfect R1 TO R2 Lasting Only 50 MS
DG-DEN-16381_Chemical Disinfect 1St Transition TO Disinfect R1 TO R2 Lasting Only 50 MS
DG-DEN-16323_FW Alarm 243 Disinfection Interrupted Triggers During Chemical Disinfect
DG-DEN-16323_FW Alarm 243 Disinfection Interrupted Triggers During Chemical Disinfect
Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

We typically dont #define for 0. However, the logic has been reworked that we no longer need to compare by 0.

We typically dont #define for 0. However, the logic has been reworked that we no longer need to compare by 0.

DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low
DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low
DG-DEN-15614_New Updated Disinfect Actuators Requirement Issues List
DG-DEN-15614_New Updated Disinfect Actuators Requirement Issues List
Removed blank line

Removed blank line

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.