dgfirmware / firmware / App / Controllers

Heaters.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 07 Sep 2022
5:32 pm

Michael Garthwaite

DEN-13427: changes need in order for staging to build successfully post merge.

Options
    • -13
    • +1
    ./Heaters.c
  2. … 1 more file in changeset.
5:16 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

5:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:19 am

Michael Garthwaite

Merge branch 'staging' into DEN-13427-sw_dev-sprint-75_mg

Options
    • -3
    • +4
    ./Heaters.c
10:19 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:19 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:19 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:05 am

Dara Navaei

Merged DEN-13834

Options
    • -41
    • +59
    ./Heaters.c
  2. … 10 more files in changeset.
Tuesday 06 Sep 2022
5:56 pm

Dara Navaei

DEN-13834 updated the heaters driver

Options
    • -3
    • +15
    ./Heaters.c
  2. … 3 more files in changeset.
10:32 am

Dara Navaei

DEN-13834 updated the heaters duty cycle record step. Tested the RO pump duty cycle feedback

Options
    • -25
    • +32
    ./Heaters.c
  2. … 2 more files in changeset.
Monday 05 Sep 2022
2:43 pm

Dara Navaei

DEN-13834 removed and addressed some of the TODOs in the code base and renamed the heaters' voltage enums for better clarification. Updated the DG RO volume generated calculations

Options
    • -27
    • +26
    ./Heaters.c
  2. … 19 more files in changeset.
Thursday 01 Sep 2022
4:04 pm

Dara Navaei

Merge branch 'DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2' into develop

Options
    • -1
    • +1
    ./Heaters.c
4:03 pm

Dara Navaei

DEN-13460 updated the heates voltages

Options
    • -1
    • +1
    ./Heaters.c
9:35 am

Dara Navaei

Merge branch 'DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2' into develop

Options
    • -12
    • +9
    ./Heaters.c
  2. … 5 more files in changeset.
Wednesday 31 Aug 2022
5:08 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-13786-hd_dg_dev-s78_bb' into develop

Options
    • -2
    • +1
    ./Heaters.c
5:06 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13786 DEN-13573 Correct MIN_INLET_TEMPERATURE_C value and minor logic bug. DEN-13786 DEN-13582 Delta temperature calculation requires fabs.

Options
    • -2
    • +1
    ./Heaters.c
  2. … 1 more file in changeset.
4:22 pm

wbracken  (deleted user)

Line 1902 is the same check but reverses the order.

Line 1902 is the same check but reverses the order.

2:42 pm

Dara Navaei

This code is un-commented.

This code is un-commented.

2:41 pm

Dara Navaei

Done.

Done.

2:39 pm

Dara Navaei

In in DEN-13834.

In in DEN-13834.

2:38 pm

Dara Navaei

Done.

Done.

2:37 pm

Dara Navaei

Added TODO to un-comment this line of code.

Added TODO to un-comment this line of code.

2:35 pm

Dara Navaei

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

2:33 pm

Dara Navaei

Done.

Done.

9:27 am

Dara Navaei

DEN-13460 updated the heaters driver. Moved the heaters data broadcast structure to the fwcommon so the HD can use it too. Updated the temperature sensors FPGA persistent alarm

Options
    • -12
    • +9
    ./Heaters.c
  2. … 3 more files in changeset.
Tuesday 30 Aug 2022
6:04 pm

Dara Navaei

Done.

Done.

Monday 29 Aug 2022
5:08 pm

wbracken  (deleted user)

Align on "*" maybe?

Align on "*" maybe?

4:38 pm

wbracken  (deleted user)

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the sema...

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the semaphore could hold onto it for a time much longer than SEMAPHORE_IN_USE_TIMEOUT.

4:31 pm

wbracken  (deleted user)

Should this function handle invalid hex characters?

Should this function handle invalid hex characters?